Completed
Pull Request — master (#696)
by Sascha
15:14
created
Classes/Facet/DateRangeFacetRenderer.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -106,6 +106,7 @@
 block discarded – undo
106 106
 
107 107
     /**
108 108
      * tbd
109
+     * @param string $facetName
109 110
      */
110 111
     protected function buildAddFacetUrl($facetName)
111 112
     {
Please login to merge, or discard this patch.
Classes/IndexQueue/PageIndexerResponse.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Turns a JSON encoded result string back into its PHP representation.
54 54
      *
55
-     * @param string $jsonEncodedResults JSON encoded result string
55
+     * @param string $jsonEncodedResponse JSON encoded result string
56 56
      * @return array|boolean An array of action => result pairs or FALSE if the response could not be decoded
57 57
      */
58 58
     public static function getResultsFromJson($jsonEncodedResponse)
Please login to merge, or discard this patch.
Classes/IndexQueue/Queue.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -856,7 +856,7 @@
 block discarded – undo
856 856
      * Marks an item as failed and causes the indexer to skip the item in the
857 857
      * next run.
858 858
      *
859
-     * @param int|Item $item Either the item's Index Queue
859
+     * @param Item $item Either the item's Index Queue
860 860
      *      uid or the complete item
861 861
      * @param string $errorMessage Error message
862 862
      */
Please login to merge, or discard this patch.
Classes/Plugin/PluginBase.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -438,7 +438,7 @@
 block discarded – undo
438 438
      * This method executes the requested commands and applies the changes to
439 439
      * the template.
440 440
      *
441
-     * @param $actionResult
441
+     * @param string $actionResult
442 442
      * @return string Rendered plugin content
443 443
      */
444 444
     abstract protected function render($actionResult);
Please login to merge, or discard this patch.
Classes/Plugin/Results/NoResultsCommand.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@
 block discarded – undo
80 80
     /**
81 81
      * Constructs label markers.
82 82
      *
83
-     * @return array Array of label markers.
83
+     * @return string Array of label markers.
84 84
      */
85 85
     protected function getLabelMarkers()
86 86
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
         $markers = $this->getLabelMarkers();
65 65
 
66 66
         if ($this->parentPlugin->typoScriptConfiguration->getSearchSpellcheckingSearchUsingSpellCheckerSuggestion()) {
67
-            $suggestionResults =  $this->getSuggestionResults();
67
+            $suggestionResults = $this->getSuggestionResults();
68 68
             $markers['suggestion_results'] = $suggestionResults;
69 69
             $markers['has_suggestion_results'] = trim($suggestionResults) !== '';
70 70
         }
Please login to merge, or discard this patch.
Classes/Query.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -941,7 +941,7 @@
 block discarded – undo
941 941
     /**
942 942
      * Sets the fields to return by a query.
943 943
      *
944
-     * @param array|string $fieldList an array or comma-separated list of field names
944
+     * @param string $fieldList an array or comma-separated list of field names
945 945
      * @throws \UnexpectedValueException on parameters other than comma-separated lists and arrays
946 946
      */
947 947
     public function setFieldList($fieldList = array('*', 'score'))
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -157,7 +157,7 @@
 block discarded – undo
157 157
      */
158 158
     public function __construct($keywords, $solrConfiguration = null)
159 159
     {
160
-        $keywords = (string) $keywords;
160
+        $keywords = (string)$keywords;
161 161
         if ($solrConfiguration == null) {
162 162
             $this->solrConfiguration = Util::getSolrConfiguration();
163 163
         } else {
Please login to merge, or discard this patch.
Classes/Query/FilterEncoder/DateRange.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,6 @@
 block discarded – undo
48 48
      * Parses the given date range from a GET parameter and returns a Solr
49 49
      * date range filter.
50 50
      *
51
-     * @param string $rangeFilter The range filter query string from the query URL
52 51
      * @param array $configuration Facet configuration
53 52
      * @return string Lucene query language filter to be used for querying Solr
54 53
      */
Please login to merge, or discard this patch.
Classes/System/Configuration/TypoScriptConfiguration.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -544,7 +544,7 @@  discard block
 block discarded – undo
544 544
      *
545 545
      * @param string $configurationName
546 546
      * @param string $defaultIfEmpty
547
-     * @return mixed
547
+     * @return string
548 548
      */
549 549
     public function getIndexQueueInitializerClassByConfigurationName($configurationName, $defaultIfEmpty = 'ApacheSolrForTypo3\\Solr\\IndexQueue\\Initializer\\Record')
550 550
     {
@@ -1237,7 +1237,7 @@  discard block
 block discarded – undo
1237 1237
      * plugin.tx_solr.search.query.allowEmptyQuery
1238 1238
      *
1239 1239
      * @param string $defaultIfEmpty
1240
-     * @return string
1240
+     * @return boolean
1241 1241
      */
1242 1242
     public function getSearchQueryAllowEmptyQuery($defaultIfEmpty = '')
1243 1243
     {
@@ -1299,7 +1299,7 @@  discard block
 block discarded – undo
1299 1299
      *
1300 1300
      * plugin.tx_solr.search.query.returnFields
1301 1301
      *
1302
-     * @param array $defaultIfEmpty
1302
+     * @param string[] $defaultIfEmpty
1303 1303
      * @return array
1304 1304
      */
1305 1305
     public function getSearchQueryReturnFieldsAsArray($defaultIfEmpty = array())
Please login to merge, or discard this patch.
Indentation   -3 removed lines patch added patch discarded remove patch
@@ -767,7 +767,6 @@  discard block
 block discarded – undo
767 767
      * Returns if a log message should be written when a page was indexed.
768 768
      *
769 769
      * plugin.tx_solr.logging.indexing.pageIndexed
770
-
771 770
      * @param bool $defaultIfEmpty
772 771
      * @return bool
773 772
      */
@@ -781,7 +780,6 @@  discard block
 block discarded – undo
781 780
      * Returns if a log message should be written when the TYPO3 search markers are missing in the page.
782 781
      *
783 782
      * plugin.tx_solr.logging.indexing.missingTypo3SearchMarkers
784
-
785 783
      * @param bool $defaultIfEmpty
786 784
      * @return bool
787 785
      */
@@ -809,7 +807,6 @@  discard block
 block discarded – undo
809 807
      * Indicates if the debug mode is enabled or not.
810 808
      *
811 809
      * plugin.tx_solr.enableDebugMode
812
-
813 810
      * @param bool $defaultIfEmpty
814 811
      * @return bool
815 812
      */
Please login to merge, or discard this patch.
Classes/Task/IndexQueueWorkerTask.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -186,7 +186,7 @@
 block discarded – undo
186 186
     }
187 187
 
188 188
     /**
189
-     * @return mixed
189
+     * @return integer
190 190
      */
191 191
     public function getDocumentsToIndexLimit()
192 192
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@
 block discarded – undo
145 145
             $message .= ' Failures: ' . $failedItemsCount;
146 146
         }
147 147
 
148
-        $message .=  ' / Using webroot: ' . htmlspecialchars($this->getWebRoot());
148
+        $message .= ' / Using webroot: ' . htmlspecialchars($this->getWebRoot());
149 149
 
150 150
         return $message;
151 151
     }
Please login to merge, or discard this patch.