Passed
Pull Request — master (#1401)
by Timo
18:55
created
Classes/Query.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -548,7 +548,7 @@  discard block
 block discarded – undo
548 548
     /**
549 549
      * Activates and deactivates grouping for the current query.
550 550
      *
551
-     * @param bool|Grouping $grouping TRUE to enable grouping, FALSE to disable grouping
551
+     * @param Grouping $grouping TRUE to enable grouping, FALSE to disable grouping
552 552
      * @return void
553 553
      */
554 554
     public function setGrouping($grouping = true)
@@ -736,7 +736,7 @@  discard block
 block discarded – undo
736 736
     /**
737 737
      * Activates and deactivates faceting for the current query.
738 738
      *
739
-     * @param bool|Faceting $faceting TRUE to enable faceting, FALSE to disable faceting
739
+     * @param Faceting $faceting TRUE to enable faceting, FALSE to disable faceting
740 740
      * @return void
741 741
      */
742 742
     public function setFaceting($faceting = true)
@@ -1043,7 +1043,7 @@  discard block
 block discarded – undo
1043 1043
      *
1044 1044
      * This query supports the complete Lucene Query Language.
1045 1045
      *
1046
-     * @param mixed $alternativeQuery String alternative query or boolean FALSE to disable / reset the q.alt parameter.
1046
+     * @param string $alternativeQuery String alternative query or boolean FALSE to disable / reset the q.alt parameter.
1047 1047
      * @see http://wiki.apache.org/solr/DisMaxQParserPlugin#q.alt
1048 1048
      */
1049 1049
     public function setAlternativeQuery($alternativeQuery)
@@ -1231,7 +1231,7 @@  discard block
 block discarded – undo
1231 1231
     /**
1232 1232
      * Enables or disables highlighting of search terms in result teasers.
1233 1233
      *
1234
-     * @param Highlighting|bool $highlighting Enables highlighting when set to TRUE, deactivates highlighting when set to FALSE, defaults to TRUE.
1234
+     * @param Highlighting $highlighting Enables highlighting when set to TRUE, deactivates highlighting when set to FALSE, defaults to TRUE.
1235 1235
      * @param int $fragmentSize Size, in characters, of fragments to consider for highlighting.
1236 1236
      * @see http://wiki.apache.org/solr/HighlightingParameters
1237 1237
      * @return void
Please login to merge, or discard this patch.
Classes/Query/Modifier/Faceting.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
 
85 85
         $facetParameters = $this->buildFacetingParameters($allFacets, $typoScriptConfiguration);
86 86
         foreach ($facetParameters as $facetParameter => $value) {
87
-            if(strtolower($facetParameter) === 'facet.field') {
87
+            if (strtolower($facetParameter) === 'facet.field') {
88 88
                 $query->getFaceting()->setFields($value);
89 89
             } else {
90 90
                 $query->getFaceting()->addAdditionalParameter($facetParameter, $value);
Please login to merge, or discard this patch.
Classes/Domain/Search/ResultSet/Facets/RequirementsService.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -39,11 +39,11 @@  discard block
 block discarded – undo
39 39
             return true;
40 40
         }
41 41
 
42
-        foreach($requirements as $requirement) {
42
+        foreach ($requirements as $requirement) {
43 43
             $requirementMet = $this->getRequirementMet($facet, $requirement);
44 44
             $requirementMet = $this->getNegationWhenConfigured($requirementMet, $requirement);
45 45
 
46
-            if($requirementMet) {
46
+            if ($requirementMet) {
47 47
                 // early return
48 48
                 return true;
49 49
             }
@@ -86,11 +86,11 @@  discard block
 block discarded – undo
86 86
     protected function getActiveItemValues(AbstractFacet $facet, $facetNameToCheckRequirementsOn)
87 87
     {
88 88
         $facetToCheckRequirements = $facet->getResultSet()->getFacets()->getByName($facetNameToCheckRequirementsOn)->getByPosition(0);
89
-        if(!$facetToCheckRequirements instanceof AbstractFacet) {
89
+        if (!$facetToCheckRequirements instanceof AbstractFacet) {
90 90
             throw new \InvalidArgumentException('Requirement for unexisting facet configured');
91 91
         }
92 92
 
93
-        if(!$facetToCheckRequirements->getIsUsed()) {
93
+        if (!$facetToCheckRequirements->getIsUsed()) {
94 94
             // unused facets do not have active values.
95 95
             return [];
96 96
         }
@@ -114,10 +114,10 @@  discard block
 block discarded – undo
114 114
      */
115 115
     protected function getNegationWhenConfigured($value, $configuration)
116 116
     {
117
-        if(!is_array($configuration) || empty($configuration['negate']) || (bool)$configuration['negate'] === false) {
117
+        if (!is_array($configuration) || empty($configuration['negate']) || (bool)$configuration['negate'] === false) {
118 118
             return $value;
119 119
         }
120 120
 
121
-        return ! ((bool) $value);
121
+        return !((bool)$value);
122 122
     }
123 123
 }
124 124
\ No newline at end of file
Please login to merge, or discard this patch.