Complex classes like Typo3PageIndexer often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Typo3PageIndexer, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
44 | class Typo3PageIndexer |
||
45 | { |
||
46 | |||
47 | /** |
||
48 | * ID of the current page's Solr document. |
||
49 | * |
||
50 | * @var string |
||
51 | */ |
||
52 | protected static $pageSolrDocumentId = ''; |
||
53 | /** |
||
54 | * The Solr document generated for the current page. |
||
55 | * |
||
56 | * @var \Apache_Solr_Document |
||
57 | */ |
||
58 | protected static $pageSolrDocument = null; |
||
59 | /** |
||
60 | * The mount point parameter used in the Frontend controller. |
||
61 | * |
||
62 | * @var string |
||
63 | */ |
||
64 | protected $mountPointParameter; |
||
65 | /** |
||
66 | * Solr server connection. |
||
67 | * |
||
68 | * @var SolrService |
||
69 | */ |
||
70 | protected $solrConnection = null; |
||
71 | /** |
||
72 | * Frontend page object (TSFE). |
||
73 | * |
||
74 | * @var TypoScriptFrontendController |
||
75 | */ |
||
76 | protected $page = null; |
||
77 | /** |
||
78 | * Content extractor to extract content from TYPO3 pages |
||
79 | * |
||
80 | * @var Typo3PageContentExtractor |
||
81 | */ |
||
82 | protected $contentExtractor = null; |
||
83 | /** |
||
84 | * URL to be indexed as the page's URL |
||
85 | * |
||
86 | * @var string |
||
87 | */ |
||
88 | protected $pageUrl = ''; |
||
89 | /** |
||
90 | * The page's access rootline |
||
91 | * |
||
92 | * @var Rootline |
||
93 | */ |
||
94 | protected $pageAccessRootline = null; |
||
95 | /** |
||
96 | * Documents that have been sent to Solr |
||
97 | * |
||
98 | * @var array |
||
99 | */ |
||
100 | protected $documentsSentToSolr = []; |
||
101 | |||
102 | /** |
||
103 | * @var TypoScriptConfiguration |
||
104 | */ |
||
105 | protected $configuration; |
||
106 | |||
107 | /** |
||
108 | * @var Item |
||
109 | */ |
||
110 | protected $indexQueueItem; |
||
111 | |||
112 | /** |
||
113 | * @var IdBuilder |
||
114 | */ |
||
115 | protected $variantIdBuilder; |
||
116 | |||
117 | /** |
||
118 | * Constructor |
||
119 | * |
||
120 | * @param TypoScriptFrontendController $page The page to index |
||
121 | * @param IdBuilder $variantIdBuilder |
||
122 | */ |
||
123 | 41 | public function __construct(TypoScriptFrontendController $page, IdBuilder $variantIdBuilder = null) |
|
124 | { |
||
125 | 41 | $this->page = $page; |
|
126 | 41 | $this->pageUrl = GeneralUtility::getIndpEnv('TYPO3_REQUEST_URL'); |
|
127 | 41 | $this->configuration = Util::getSolrConfiguration(); |
|
128 | |||
129 | try { |
||
130 | 41 | $this->initializeSolrConnection(); |
|
131 | 41 | } catch (\Exception $e) { |
|
132 | $this->log($e->getMessage() . ' Error code: ' . $e->getCode(), 3); |
||
133 | |||
134 | // TODO extract to a class "ExceptionLogger" |
||
135 | if ($this->configuration->getLoggingExceptions()) { |
||
136 | GeneralUtility::devLog('Exception while trying to index a page', 'solr', 3, [$e->__toString()]); |
||
137 | } |
||
138 | } |
||
139 | |||
140 | 41 | $this->contentExtractor = GeneralUtility::makeInstance(Typo3PageContentExtractor::class, $this->page->content); |
|
141 | 41 | $this->pageAccessRootline = GeneralUtility::makeInstance(Rootline::class, ''); |
|
142 | 41 | $this->variantIdBuilder = is_null($variantIdBuilder) ? GeneralUtility::makeInstance(IdBuilder::class) : $variantIdBuilder; |
|
143 | 41 | } |
|
144 | |||
145 | /** |
||
146 | * @param Item $indexQueueItem |
||
147 | */ |
||
148 | 5 | public function setIndexQueueItem($indexQueueItem) |
|
152 | |||
153 | |||
154 | /** |
||
155 | * Initializes the Solr server connection. |
||
156 | * |
||
157 | * @throws \Exception when no Solr connection can be established. |
||
158 | */ |
||
159 | 41 | protected function initializeSolrConnection() |
|
173 | |||
174 | /** |
||
175 | * Logs messages to devlog and TS log (admin panel) |
||
176 | * |
||
177 | * @param string $message Message to set |
||
178 | * @param int $errorNum Error number |
||
179 | * @param array $data Additional data to log |
||
180 | * @return void |
||
181 | */ |
||
182 | 41 | protected function log($message, $errorNum = 0, array $data = []) |
|
183 | { |
||
184 | 41 | if (is_object($GLOBALS['TT'])) { |
|
185 | 41 | $GLOBALS['TT']->setTSlogMessage('tx_solr: ' . $message, $errorNum); |
|
186 | 41 | } |
|
187 | |||
188 | 41 | if ($this->configuration->getLoggingIndexing()) { |
|
189 | $logData = []; |
||
190 | if (!empty($data)) { |
||
191 | foreach ($data as $value) { |
||
192 | $logData[] = (array)$value; |
||
193 | } |
||
194 | } |
||
195 | |||
196 | GeneralUtility::devLog($message, 'solr', $errorNum, $logData); |
||
197 | } |
||
198 | 41 | } |
|
199 | |||
200 | /** |
||
201 | * Gets the current page's Solr document ID. |
||
202 | * |
||
203 | * @return string|NULL The page's Solr document ID or NULL in case no document was generated yet. |
||
204 | */ |
||
205 | public static function getPageSolrDocumentId() |
||
209 | |||
210 | /** |
||
211 | * Gets the Solr document generated for the current page. |
||
212 | * |
||
213 | * @return \Apache_Solr_Document|NULL The page's Solr document or NULL if it has not been generated yet. |
||
214 | */ |
||
215 | 5 | public static function getPageSolrDocument() |
|
219 | |||
220 | /** |
||
221 | * Allows to provide a Solr server connection other than the one |
||
222 | * initialized by the constructor. |
||
223 | * |
||
224 | * @param SolrService $solrConnection Solr connection |
||
225 | * @throws \Exception if the Solr server cannot be reached |
||
226 | */ |
||
227 | 5 | public function setSolrConnection(SolrService $solrConnection) |
|
238 | |||
239 | /** |
||
240 | * Indexes a page. |
||
241 | * |
||
242 | * @return bool TRUE after successfully indexing the page, FALSE on error |
||
243 | * @throws \UnexpectedValueException if a page document post processor fails to implement interface ApacheSolrForTypo3\Solr\PageDocumentPostProcessor |
||
244 | */ |
||
245 | 41 | public function indexPage() |
|
273 | |||
274 | /** |
||
275 | * Applies the configured post processors (indexPagePostProcessPageDocument) |
||
276 | * |
||
277 | * @param \Apache_Solr_Document $pageDocument |
||
278 | */ |
||
279 | 41 | protected function applyIndexPagePostProcessors($pageDocument) |
|
280 | { |
||
281 | 41 | if (!is_array($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPagePostProcessPageDocument'])) { |
|
282 | 40 | return; |
|
283 | } |
||
284 | |||
285 | 1 | foreach ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPagePostProcessPageDocument'] as $classReference) { |
|
286 | 1 | $postProcessor = GeneralUtility::getUserObj($classReference); |
|
287 | 1 | if (!$postProcessor instanceof PageDocumentPostProcessor) { |
|
288 | throw new \UnexpectedValueException(get_class($pageDocument) . ' must implement interface ' . PageDocumentPostProcessor::class, 1397739154); |
||
289 | } |
||
290 | |||
291 | 1 | $postProcessor->postProcessPageDocument($pageDocument, $this->page); |
|
292 | 1 | } |
|
293 | 1 | } |
|
294 | |||
295 | /** |
||
296 | * Builds the Solr document for the current page. |
||
297 | * |
||
298 | * @return \Apache_Solr_Document A document representing the page |
||
299 | */ |
||
300 | 41 | protected function getPageDocument() |
|
301 | { |
||
302 | 41 | $document = GeneralUtility::makeInstance(Apache_Solr_Document::class); |
|
303 | /* @var $document \Apache_Solr_Document */ |
||
304 | 41 | $site = Site::getSiteByPageId($this->page->id); |
|
305 | 41 | $pageRecord = $this->page->page; |
|
306 | |||
307 | 41 | self::$pageSolrDocumentId = $documentId = Util::getPageDocumentId( |
|
308 | 41 | $this->page->id, |
|
309 | 41 | $this->page->type, |
|
310 | 41 | $this->page->sys_language_uid, |
|
311 | 41 | $this->getDocumentIdGroups(), |
|
312 | 41 | $this->getMountPointParameter() |
|
313 | 41 | ); |
|
314 | 41 | $document->setField('id', $documentId); |
|
315 | 41 | $document->setField('site', $site->getDomain()); |
|
316 | 41 | $document->setField('siteHash', $site->getSiteHash()); |
|
317 | 41 | $document->setField('appKey', 'EXT:solr'); |
|
318 | 41 | $document->setField('type', 'pages'); |
|
319 | |||
320 | // system fields |
||
321 | 41 | $document->setField('uid', $this->page->id); |
|
322 | 41 | $document->setField('pid', $pageRecord['pid']); |
|
323 | |||
324 | // variantId |
||
325 | 41 | $variantId = $this->variantIdBuilder->buildFromTypeAndUid('pages', $this->page->id); |
|
326 | 41 | $document->setField('variantId', $variantId); |
|
327 | |||
328 | 41 | $document->setField('typeNum', $this->page->type); |
|
329 | 41 | $document->setField('created', $pageRecord['crdate']); |
|
330 | 41 | $document->setField('changed', $pageRecord['SYS_LASTCHANGED']); |
|
331 | |||
332 | 41 | $rootline = $this->getRootLineFieldValue(); |
|
333 | 41 | $document->setField('rootline', $rootline); |
|
334 | |||
335 | // access |
||
336 | 41 | $this->addAccessField($document); |
|
337 | 41 | $this->addEndtimeField($document, $pageRecord); |
|
338 | |||
339 | // content |
||
340 | 41 | $document->setField('title', $this->contentExtractor->getPageTitle()); |
|
341 | 41 | $document->setField('subTitle', $pageRecord['subtitle']); |
|
342 | 41 | $document->setField('navTitle', $pageRecord['nav_title']); |
|
343 | 41 | $document->setField('author', $pageRecord['author']); |
|
344 | 41 | $document->setField('description', $pageRecord['description']); |
|
345 | 41 | $document->setField('abstract', $pageRecord['abstract']); |
|
346 | 41 | $document->setField('content', $this->contentExtractor->getIndexableContent()); |
|
347 | 41 | $document->setField('url', $this->pageUrl); |
|
348 | |||
349 | 41 | $this->addKeywordsField($document, $pageRecord); |
|
350 | 41 | $this->addTagContentFields($document); |
|
351 | |||
352 | 41 | return $document; |
|
353 | } |
||
354 | |||
355 | /** |
||
356 | * Adds the access field to the document if needed. |
||
357 | * |
||
358 | * @param \Apache_Solr_Document $document |
||
359 | */ |
||
360 | 41 | protected function addAccessField(\Apache_Solr_Document $document) |
|
361 | { |
||
362 | 41 | $access = (string)$this->pageAccessRootline; |
|
363 | 41 | if (trim($access) !== '') { |
|
364 | 8 | $document->setField('access', $access); |
|
365 | 8 | } |
|
366 | 41 | } |
|
367 | |||
368 | /** |
||
369 | * @param $document |
||
370 | * @param $pageRecord |
||
371 | */ |
||
372 | 41 | protected function addEndtimeField(\Apache_Solr_Document $document, $pageRecord) |
|
378 | |||
379 | /** |
||
380 | * Adds keywords, multi valued. |
||
381 | * |
||
382 | * @param \Apache_Solr_Document $document |
||
383 | * @param array $pageRecord |
||
384 | */ |
||
385 | 41 | protected function addKeywordsField(\Apache_Solr_Document $document, $pageRecord) |
|
386 | { |
||
387 | 41 | $keywords = array_unique(GeneralUtility::trimExplode(',', $pageRecord['keywords'], true)); |
|
388 | 41 | foreach ($keywords as $keyword) { |
|
389 | $document->addField('keywords', $keyword); |
||
390 | 41 | } |
|
391 | 41 | } |
|
392 | |||
393 | /** |
||
394 | * Add content from several tags like headers, anchors, ... |
||
395 | * |
||
396 | * @param \Apache_Solr_Document $document |
||
397 | */ |
||
398 | 41 | protected function addTagContentFields(\Apache_Solr_Document $document) |
|
399 | { |
||
400 | 41 | $tagContent = $this->contentExtractor->getTagContent(); |
|
401 | 41 | foreach ($tagContent as $fieldName => $fieldValue) { |
|
402 | $document->setField($fieldName, $fieldValue); |
||
403 | 41 | } |
|
404 | 41 | } |
|
405 | |||
406 | /** |
||
407 | * Builds the content for the rootline field. |
||
408 | * |
||
409 | * @return string |
||
410 | */ |
||
411 | 41 | protected function getRootLineFieldValue() |
|
412 | { |
||
413 | 41 | $rootline = $this->page->id; |
|
414 | 41 | $mountPointParameter = $this->getMountPointParameter(); |
|
415 | 41 | if ($mountPointParameter !== '') { |
|
416 | 36 | $rootline .= ',' . $mountPointParameter; |
|
417 | 36 | } |
|
418 | 41 | return $rootline; |
|
419 | } |
||
420 | |||
421 | /** |
||
422 | * Gets a comma separated list of frontend user groups to use for the |
||
423 | * document ID. |
||
424 | * |
||
425 | * @return string A comma separated list of frontend user groups. |
||
426 | */ |
||
427 | 41 | protected function getDocumentIdGroups() |
|
428 | { |
||
429 | 41 | $groups = $this->pageAccessRootline->getGroups(); |
|
430 | 41 | $groups = Rootline::cleanGroupArray($groups); |
|
431 | |||
432 | 41 | if (empty($groups)) { |
|
433 | 35 | $groups[] = 0; |
|
434 | 35 | } |
|
435 | |||
436 | 41 | $groups = implode(',', $groups); |
|
437 | |||
438 | 41 | return $groups; |
|
439 | } |
||
440 | |||
441 | // Logging |
||
442 | // TODO replace by a central logger |
||
443 | |||
444 | /** |
||
445 | * Gets the mount point parameter that is used in the Frontend controller. |
||
446 | * |
||
447 | * @return string |
||
448 | */ |
||
449 | 41 | public function getMountPointParameter() |
|
453 | |||
454 | // Misc |
||
455 | |||
456 | /** |
||
457 | * Sets the mount point parameter that is used in the Frontend controller. |
||
458 | * |
||
459 | * @param string $mountPointParameter |
||
460 | */ |
||
461 | 5 | public function setMountPointParameter($mountPointParameter) |
|
465 | |||
466 | /** |
||
467 | * Allows third party extensions to replace or modify the page document |
||
468 | * created by this indexer. |
||
469 | * |
||
470 | * @param \Apache_Solr_Document $pageDocument The page document created by this indexer. |
||
471 | * @return \Apache_Solr_Document An Apache Solr document representing the currently indexed page |
||
472 | */ |
||
473 | 41 | protected function substitutePageDocument(\Apache_Solr_Document $pageDocument) |
|
474 | { |
||
475 | 41 | if (!is_array($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPageSubstitutePageDocument'])) { |
|
476 | 36 | return $pageDocument; |
|
477 | } |
||
478 | |||
479 | 5 | $indexConfigurationName = $this->getIndexConfigurationNameForCurrentPage(); |
|
480 | 5 | foreach ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPageSubstitutePageDocument'] as $classReference) { |
|
481 | 5 | $substituteIndexer = GeneralUtility::getUserObj($classReference); |
|
482 | |||
483 | 5 | if (!$substituteIndexer instanceof SubstitutePageIndexer) { |
|
484 | $message = get_class($substituteIndexer) . ' must implement interface ' . SubstitutePageIndexer::class; |
||
485 | throw new \UnexpectedValueException($message, 1310491001); |
||
486 | } |
||
487 | |||
488 | 5 | if ($substituteIndexer instanceof PageFieldMappingIndexer) { |
|
489 | 5 | $substituteIndexer->setPageIndexingConfigurationName($indexConfigurationName); |
|
490 | 5 | } |
|
491 | |||
492 | 5 | $substituteDocument = $substituteIndexer->getPageDocument($pageDocument); |
|
493 | 5 | if (!$substituteDocument instanceof \Apache_Solr_Document) { |
|
|
|||
494 | $message = 'The document returned by ' . get_class($substituteIndexer) . ' is not a valid Apache_Solr_Document document.'; |
||
495 | throw new \UnexpectedValueException($message, 1310490952); |
||
496 | } |
||
497 | 5 | $pageDocument = $substituteDocument; |
|
498 | 5 | } |
|
499 | |||
500 | 5 | return $pageDocument; |
|
501 | } |
||
502 | |||
503 | /** |
||
504 | * Retrieves the indexConfigurationName from the related queueItem, or falls back to pages when no queue item set. |
||
505 | * |
||
506 | * @return string |
||
507 | */ |
||
508 | 5 | protected function getIndexConfigurationNameForCurrentPage() |
|
512 | |||
513 | /** |
||
514 | * Allows third party extensions to provide additional documents which |
||
515 | * should be indexed for the current page. |
||
516 | * |
||
517 | * @param \Apache_Solr_Document $pageDocument The main document representing this page. |
||
518 | * @param \Apache_Solr_Document[] $existingDocuments An array of documents already created for this page. |
||
519 | * @return array An array of additional \Apache_Solr_Document objects to index |
||
520 | */ |
||
521 | 41 | protected function getAdditionalDocuments(\Apache_Solr_Document $pageDocument, array $existingDocuments) |
|
522 | { |
||
523 | 41 | $documents = $existingDocuments; |
|
524 | |||
525 | 41 | if (!is_array($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPageAddDocuments'])) { |
|
526 | 40 | return $documents; |
|
527 | } |
||
528 | |||
529 | 1 | foreach ($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPageAddDocuments'] as $classReference) { |
|
530 | 1 | $additionalIndexer = GeneralUtility::getUserObj($classReference); |
|
531 | |||
532 | 1 | if (!$additionalIndexer instanceof AdditionalPageIndexer) { |
|
533 | $message = get_class($additionalIndexer) . ' must implement interface ' . AdditionalPageIndexer::class; |
||
534 | throw new \UnexpectedValueException($message, 1310491024); |
||
535 | } |
||
536 | |||
537 | 1 | $additionalDocuments = $additionalIndexer->getAdditionalPageDocuments($pageDocument, $documents); |
|
538 | 1 | if (is_array($additionalDocuments)) { |
|
539 | 1 | $documents = array_merge($documents, $additionalDocuments); |
|
540 | 1 | } |
|
541 | 1 | } |
|
542 | |||
543 | 1 | return $documents; |
|
544 | } |
||
545 | |||
546 | /** |
||
547 | * Sends the given documents to the field processing service which takes |
||
548 | * care of manipulating fields as defined in the field's configuration. |
||
549 | * |
||
550 | * @param array $documents An array of documents to manipulate |
||
551 | */ |
||
552 | 41 | protected function processDocuments(array $documents) |
|
553 | { |
||
554 | 41 | $processingInstructions = $this->configuration->getIndexFieldProcessingInstructionsConfiguration(); |
|
555 | 41 | if (count($processingInstructions) > 0) { |
|
556 | 41 | $service = GeneralUtility::makeInstance(Service::class); |
|
557 | 41 | $service->processDocuments($documents, $processingInstructions); |
|
558 | 41 | } |
|
559 | 41 | } |
|
560 | |||
561 | /** |
||
562 | * Adds the collected documents to the Solr index. |
||
563 | * |
||
564 | * @param array $documents An array of \Apache_Solr_Document objects. |
||
565 | * @return bool TRUE if documents were added successfully, FALSE otherwise |
||
566 | */ |
||
567 | 41 | protected function addDocumentsToSolrIndex(array $documents) |
|
568 | { |
||
569 | 41 | $documentsAdded = false; |
|
570 | |||
571 | 41 | if (!count($documents)) { |
|
572 | return $documentsAdded; |
||
573 | } |
||
574 | |||
575 | try { |
||
576 | 41 | $this->log('Adding ' . count($documents) . ' documents.', 0, $documents); |
|
577 | |||
578 | // chunk adds by 20 |
||
579 | 41 | $documentChunks = array_chunk($documents, 20); |
|
580 | 41 | foreach ($documentChunks as $documentChunk) { |
|
581 | 41 | $response = $this->solrConnection->addDocuments($documentChunk); |
|
582 | |||
583 | 41 | if ($response->getHttpStatus() != 200) { |
|
584 | $transportException = new \Apache_Solr_HttpTransportException($response); |
||
585 | throw new \RuntimeException('Solr Request failed.', 1331834983, $transportException); |
||
586 | } |
||
587 | 41 | } |
|
588 | |||
589 | 41 | $documentsAdded = true; |
|
590 | 41 | } catch (\Exception $e) { |
|
591 | $this->log($e->getMessage() . ' Error code: ' . $e->getCode(), 2); |
||
592 | |||
593 | if ($this->configuration->getLoggingExceptions()) { |
||
594 | GeneralUtility::devLog('Exception while adding documents', 'solr', 3, [$e->__toString()]); |
||
595 | } |
||
596 | } |
||
597 | |||
598 | 41 | return $documentsAdded; |
|
599 | } |
||
600 | |||
601 | /** |
||
602 | * Gets the current page's URL. |
||
603 | * |
||
604 | * @return string URL of the current page. |
||
605 | */ |
||
606 | public function getPageUrl() |
||
610 | |||
611 | /** |
||
612 | * Sets the URL to use for the page document. |
||
613 | * |
||
614 | * @param string $url The page's URL. |
||
615 | */ |
||
616 | 5 | public function setPageUrl($url) |
|
620 | |||
621 | /** |
||
622 | * Gets the page's access rootline. |
||
623 | * |
||
624 | * @return Rootline The page's access rootline |
||
625 | */ |
||
626 | public function getPageAccessRootline() |
||
630 | |||
631 | /** |
||
632 | * Sets the page's access rootline. |
||
633 | * |
||
634 | * @param Rootline $accessRootline The page's access rootline |
||
635 | */ |
||
636 | 40 | public function setPageAccessRootline(Rootline $accessRootline) |
|
640 | |||
641 | /** |
||
642 | * Gets the documents that have been sent to Solr |
||
643 | * |
||
644 | * @return array An array of \Apache_Solr_Document objects |
||
645 | */ |
||
646 | 5 | public function getDocumentsSentToSolr() |
|
650 | } |
||
651 |