Passed
Pull Request — master (#1744)
by Georg
19:22
created
Classes/Query/Modifier/Faceting.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@
 block discarded – undo
84 84
 
85 85
         $facetParameters = $this->buildFacetingParameters($allFacets, $typoScriptConfiguration);
86 86
         foreach ($facetParameters as $facetParameter => $value) {
87
-            if(strtolower($facetParameter) === 'facet.field') {
87
+            if (strtolower($facetParameter) === 'facet.field') {
88 88
                 $query->getFaceting()->setFields($value);
89 89
             } else {
90 90
                 $query->getFaceting()->addAdditionalParameter($facetParameter, $value);
Please login to merge, or discard this patch.
Classes/System/Service/ConfigurationService.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -14,11 +14,9 @@
 block discarded – undo
14 14
  * The TYPO3 project - inspiring people to share!
15 15
  */
16 16
 
17
-use ApacheSolrForTypo3\Solr\System\Configuration\ConfigurationManager;
18 17
 use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
19 18
 use TYPO3\CMS\Core\TypoScript\TypoScriptService;
20 19
 use TYPO3\CMS\Core\Utility\GeneralUtility;
21
-use TYPO3\CMS\Extbase\Configuration\ConfigurationManager as ExtbaseConfigurationManager;
22 20
 use TYPO3\CMS\Extbase\Reflection\ObjectAccess;
23 21
 use TYPO3\CMS\Extbase\Service\FlexFormService;
24 22
 
Please login to merge, or discard this patch.
Classes/Controller/Backend/AjaxController.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1,5 +1,5 @@
 block discarded – undo
1 1
 <?php
2
-declare(strict_types=1);
2
+declare(strict_types = 1);
3 3
 namespace ApacheSolrForTypo3\Solr\Controller\Backend;
4 4
 
5 5
 /***************************************************************
Please login to merge, or discard this patch.
Classes/System/UserFunctions/FlexFormUserFunctions.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -148,7 +148,7 @@
 block discarded – undo
148 148
     }
149 149
 
150 150
     /**
151
-     * @param $pid
151
+     * @param integer $pid
152 152
      * @return \ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration|array
153 153
      */
154 154
     protected function getConfigurationFromPageId($pid)
Please login to merge, or discard this patch.
Classes/Controller/SearchController.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -63,13 +63,13 @@
 block discarded – undo
63 63
      */
64 64
     public function initializeView(ViewInterface $view)
65 65
     {
66
-        if($view instanceof TemplateView) {
66
+        if ($view instanceof TemplateView) {
67 67
             $customTemplate = $this->getCustomTemplateFromConfiguration();
68
-            if($customTemplate === '') {
68
+            if ($customTemplate === '') {
69 69
                 return;
70 70
             }
71 71
 
72
-            if(strpos($customTemplate, 'EXT:') !== false) {
72
+            if (strpos($customTemplate, 'EXT:') !== false) {
73 73
                 $view->setTemplatePathAndFilename($customTemplate);
74 74
             } else {
75 75
                 $view->setTemplate($customTemplate);
Please login to merge, or discard this patch.
Classes/IndexQueue/RecordMonitor.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@
 block discarded – undo
93 93
         $this->mountPageUpdater = is_null($mountPageUpdater) ? GeneralUtility::makeInstance(MountPagesUpdater::class) : $mountPageUpdater;
94 94
         $this->tcaService = is_null($TCAService) ? GeneralUtility::makeInstance(TCAService::class) : $TCAService;
95 95
         $this->rootPageResolver = is_null($rootPageResolver) ? GeneralUtility::makeInstance(RootPageResolver::class) : $rootPageResolver;
96
-        $this->pagesRepository = isset($pagesRepository) ? $pagesRepository: GeneralUtility::makeInstance(PagesRepository::class);
96
+        $this->pagesRepository = isset($pagesRepository) ? $pagesRepository : GeneralUtility::makeInstance(PagesRepository::class);
97 97
     }
98 98
 
99 99
     /**
Please login to merge, or discard this patch.
Classes/Domain/Search/ResultSet/Facets/AbstractFacetPackage.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@
 block discarded – undo
85 85
     public function getQueryBuilder()
86 86
     {
87 87
         $urlDecoder = $this->objectManager->get($this->getQueryBuilderClassName());
88
-        if(!$urlDecoder instanceof FacetQueryBuilderInterface) {
88
+        if (!$urlDecoder instanceof FacetQueryBuilderInterface) {
89 89
             throw new InvalidQueryBuilderException('Invalid querybuilder for package ' . __CLASS__);
90 90
         }
91 91
         return $urlDecoder;
Please login to merge, or discard this patch.
Classes/System/Records/AbstractRepository.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -90,6 +90,7 @@
 block discarded – undo
90 90
      * Note: Rollback will not work in case of different connections.
91 91
      *
92 92
      * @param string[] ...$tableNames
93
+     * @param string $tableNames
93 94
      * @return Connection
94 95
      */
95 96
     public function getConnectionForAllInTransactionInvolvedTables(string ...$tableNames) : Connection
Please login to merge, or discard this patch.
Classes/Domain/Search/SearchRequestBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@
 block discarded – undo
175 175
      * This methods sets the page argument to an expected positive integer value in the arguments array.
176 176
      *
177 177
      * @param array $arguments
178
-     * @return array
178
+     * @return integer
179 179
      */
180 180
     protected function adjustPageArgumentToPositiveInteger(array $arguments)
181 181
     {
Please login to merge, or discard this patch.