TYPO3-Solr / ext-solr

Tests/Integration/Domain/Index/IndexServiceTest.php

Unused Use Statements -3 removed lines

@@ -26,13 +26,10 @@
  ***************************************************************/
 
 use ApacheSolrForTypo3\Solr\Domain\Index\IndexService;
-use ApacheSolrForTypo3\Solr\IndexQueue\Indexer;
 use ApacheSolrForTypo3\Solr\IndexQueue\Queue;
 use ApacheSolrForTypo3\Solr\Site;
 use ApacheSolrForTypo3\Solr\System\Environment\CliEnvironment;
 use ApacheSolrForTypo3\Solr\Tests\Integration\IntegrationTest;
-use ApacheSolrForTypo3\Solr\IndexQueue\RecordMonitor;
-use TYPO3\CMS\Backend\Utility\BackendUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**

Spacing +2 added lines, -2 removed lines

@@ -117,7 +117,7 @@ 
         $GLOBALS['TCA']['tx_fakeextension_domain_model_bar'] = include($this->getFixturePath('fake_extension2_bar_tca.php'));
         $GLOBALS['TCA']['tx_fakeextension_domain_model_directrelated'] = include($this->getFixturePath('fake_extension2_directrelated_tca.php'));
 
-        $this->importDataSetFromFixture('can_index_custom_record_absRefPrefix_'.$absRefPrefix.'.xml');
+        $this->importDataSetFromFixture('can_index_custom_record_absRefPrefix_' . $absRefPrefix . '.xml');
 
         $this->addToIndexQueue('tx_fakeextension_domain_model_bar', 111);
 
@@ -139,7 +139,7 @@ 
         sleep(2);
         $solrContent = file_get_contents('http://localhost:8080/solr/core_en/select?q=*:*');
         $this->assertContains('"numFound":1', $solrContent, 'Could not index document into solr');
-        $this->assertContains('"url":"'.$expectedUrl.'"', $solrContent, 'Generated unexpected url with absRefPrefix = auto');
+        $this->assertContains('"url":"' . $expectedUrl . '"', $solrContent, 'Generated unexpected url with absRefPrefix = auto');
         $this->assertNotContains('auto', $solrContent, 'absRefPrefix=auto was not resolved');
         $this->cleanUpSolrServerAndAssertEmpty();
     }

Tests/Integration/IndexQueue/FrontendHelper/PageIndexerTest.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  ***************************************************************/
 
-use ApacheSolrForTypo3\Solr\Site;
 use TYPO3\CMS\Core\TimeTracker\TimeTracker;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use ApacheSolrForTypo3\Solr\Tests\Integration\IntegrationTest;

Tests/Integration/IndexQueue/IndexerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -219,7 +219,7 @@
     /**
      * @param string $table
      * @param integer $uid
-     * @return \Apache_Solr_Response
+     * @return boolean
      */
     protected function addToQueueAndIndexRecord($table, $uid)
     {

Unused Use Statements -3 removed lines

@@ -27,10 +27,7 @@
 use ApacheSolrForTypo3\Solr\IndexQueue\Indexer;
 use ApacheSolrForTypo3\Solr\IndexQueue\Queue;
 use ApacheSolrForTypo3\Solr\Tests\Integration\IntegrationTest;
-use ApacheSolrForTypo3\Solr\IndexQueue\RecordMonitor;
-use TYPO3\CMS\Backend\Utility\BackendUtility;
 use TYPO3\CMS\Core\Charset\CharsetConverter;
-use TYPO3\CMS\Core\DataHandling\DataHandler;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**

Tests/Integration/IndexQueue/QueueTest.php

Unused Use Statements -5 removed lines

@@ -24,14 +24,9 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  ***************************************************************/
 
-use ApacheSolrForTypo3\Solr\IndexQueue\Indexer;
 use ApacheSolrForTypo3\Solr\IndexQueue\Queue;
 use ApacheSolrForTypo3\Solr\Site;
 use ApacheSolrForTypo3\Solr\Tests\Integration\IntegrationTest;
-use ApacheSolrForTypo3\Solr\IndexQueue\RecordMonitor;
-use TYPO3\CMS\Backend\Utility\BackendUtility;
-use TYPO3\CMS\Core\Charset\CharsetConverter;
-use TYPO3\CMS\Core\DataHandling\DataHandler;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**

Spacing +1 added lines, -1 removed lines

@@ -73,7 +73,7 @@
     protected function assertItemsInQueue($expectedAmount)
     {
         $itemCount = $this->indexQueue->getAllItemsCount();
-        $this->assertSame($itemCount, $expectedAmount, 'Indexqueue contains unexpected amount of items. Expected amount: '.$expectedAmount);
+        $this->assertSame($itemCount, $expectedAmount, 'Indexqueue contains unexpected amount of items. Expected amount: ' . $expectedAmount);
     }
 
     /**

Tests/Integration/IndexQueue/RecordMonitorTest.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use ApacheSolrForTypo3\Solr\IndexQueue\Queue;
 use ApacheSolrForTypo3\Solr\Tests\Integration\IntegrationTest;
 use ApacheSolrForTypo3\Solr\IndexQueue\RecordMonitor;
-use TYPO3\CMS\Backend\Utility\BackendUtility;
 use TYPO3\CMS\Core\DataHandling\DataHandler;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 

Spacing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
     protected function assertIndexQueueContainsItemAmount($amount)
     {
         $this->assertEquals($amount, $this->indexQueue->getAllItemsCount(),
-            'Index queue is empty and was expected to contain '.(int) $amount.' items.');
+            'Index queue is empty and was expected to contain ' . (int)$amount . ' items.');
     }
 
     /**

Doc Comments +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
     }
 
     /**
-     * @param $amount
+     * @param integer $amount
      */
     protected function assertIndexQueryContainsItemAmount($amount)
     {

Tests/Integration/IntegrationTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -65,7 +65,7 @@ 
     /**
      * Loads a Fixture from the Fixtures folder beside the current test case.
      *
-     * @param $fixtureName
+     * @param string $fixtureName
      * @throws \TYPO3\CMS\Core\Tests\Exception
      */
     protected function importDataSetFromFixture($fixtureName)
@@ -86,7 +86,7 @@ 
     /**
      * Returns the absolute path to a fixture file.
      *
-     * @param $fixtureName
+     * @param string $fixtureName
      * @return string
      */
     protected function getFixturePath($fixtureName)

Tests/Integration/Plugin/Results/ResultsTest.php

Unused Use Statements -4 removed lines

@@ -25,13 +25,9 @@
  ***************************************************************/
 
 use ApacheSolrForTypo3\Solr\Domain\Search\SearchRequest;
-use ApacheSolrForTypo3\Solr\Site;
 use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
-use ApacheSolrForTypo3\Solr\Tests\Integration\IntegrationTest;
 use ApacheSolrForTypo3\Solr\Tests\Integration\Plugin\AbstractPluginTest;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer;
-use TYPO3\CMS\Frontend\Page\PageGenerator;
 
 /**
  * Integration testcase to test the results plugin.

Tests/Integration/Task/IndexQueueWorkerTaskTest.php

Unused Use Statements -2 removed lines

@@ -56,8 +56,6 @@
 use ApacheSolrForTypo3\Solr\IndexQueue\Queue;
 use ApacheSolrForTypo3\Solr\Site;
 use ApacheSolrForTypo3\Solr\Tests\Integration\IntegrationTest;
-use ApacheSolrForTypo3\Solr\IndexQueue\RecordMonitor;
-use TYPO3\CMS\Core\DataHandling\DataHandler;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**

Tests/Integration/Task/ReIndexTaskTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
     }
 
     /**
-     * @param $amount
+     * @param integer $amount
      */
     protected function assertIndexQueryContainsItemAmount($amount)
     {

Spacing +1 added lines, -1 removed lines

@@ -87,7 +87,7 @@
     protected function assertIndexQueueContainsItemAmount($amount)
     {
         $this->assertEquals($amount, $this->indexQueue->getAllItemsCount(),
-            'Index queue is empty and was expected to contain '.(int) $amount.' items.');
+            'Index queue is empty and was expected to contain ' . (int)$amount . ' items.');
     }
 
     /**