TYPO3-Solr / ext-solr

Classes/Task/IndexQueueWorkerTask.php

Doc Comments +1 added lines, -1 removed lines

@@ -186,7 +186,7 @@
     }
 
     /**
-     * @return mixed
+     * @return integer
      */
     public function getDocumentsToIndexLimit()
     {

Unused Use Statements -5 removed lines

@@ -25,13 +25,8 @@
  ***************************************************************/
 
 use ApacheSolrForTypo3\Solr\Domain\Index\IndexService;
-use ApacheSolrForTypo3\Solr\IndexQueue\Indexer;
-use ApacheSolrForTypo3\Solr\IndexQueue\Item;
 use ApacheSolrForTypo3\Solr\Site;
 use ApacheSolrForTypo3\Solr\System\Environment\CliEnvironment;
-use ApacheSolrForTypo3\Solr\Util;
-use TYPO3\CMS\Backend\Utility\BackendUtility;
-use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Scheduler\ProgressProviderInterface;
 use TYPO3\CMS\Scheduler\Task\AbstractTask;

Spacing +1 added lines, -1 removed lines

@@ -145,7 +145,7 @@
             $message .= ' Failures: ' . $failedItemsCount;
         }
 
-        $message .=  ' / Using webroot: ' . htmlspecialchars($this->getWebRoot());
+        $message .= ' / Using webroot: ' . htmlspecialchars($this->getWebRoot());
 
         return $message;
     }

Classes/Template.php

Doc Comments +2 added lines, -1 removed lines

@@ -130,6 +130,7 @@ 
     /**
      * Finds the view helpers in the template and loads them.
      *
+     * @param string $content
      * @return void
      */
     protected function initializeViewHelpers($content)
@@ -1158,7 +1159,7 @@ 
     }
 
     /**
-     * @param $templateContent
+     * @param string $templateContent
      * @return mixed
      */
     public function setTemplateContent($templateContent)

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 
 use ApacheSolrForTypo3\Solr\ViewHelper\SubpartViewHelper;
 use ApacheSolrForTypo3\Solr\ViewHelper\ViewHelper;
-use TYPO3\CMS\Core\Html\HtmlParser;
 use TYPO3\CMS\Core\Service\MarkerBasedTemplateService;
 use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;

Spacing +1 added lines, -1 removed lines

@@ -218,7 +218,7 @@
             $ucHelperKey = Util::underscoredToUpperCamelCase($helperKey);
             $vendorNameSpace = 'ApacheSolrForTypo3\\Solr\\';
             $possibleFilename = $ucHelperKey . '.php';
-            $possibleClassName =  $vendorNameSpace . str_replace('/', '\\',
+            $possibleClassName = $vendorNameSpace . str_replace('/', '\\',
                     $viewHelperRealPath) . '\\' . $ucHelperKey;
 
             $viewHelperIncludePath = ExtensionManagementUtility::extPath($extensionKey)

Classes/Typo3PageContentExtractor.php

Unused Use Statements -1 removed lines

@@ -24,7 +24,6 @@
  *  This copyright notice MUST APPEAR in all copies of the script!
  ***************************************************************/
 
-use TYPO3\CMS\Core\Utility\ArrayUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**

Spacing +1 added lines, -1 removed lines

@@ -96,7 +96,7 @@
         $doc->loadHTML('<?xml version="1.0" encoding="UTF-8"?>' . PHP_EOL . $indexableContent);
         $xpath = new \DOMXPath($doc);
         foreach ($excludeClasses as $excludePart) {
-            $elements = $xpath->query("//*[contains(@class,'".$excludePart."')]");
+            $elements = $xpath->query("//*[contains(@class,'" . $excludePart . "')]");
             if (count($elements) == 0) {
                 continue;
             }

Classes/Typo3PageIndexer.php

Doc Comments +1 added lines, -1 removed lines

@@ -441,7 +441,7 @@
      * should be indexed for the current page.
      *
      * @param \Apache_Solr_Document $pageDocument The main document representing this page.
-     * @param array $existingDocuments An array of documents already created for this page.
+     * @param \Apache_Solr_Document[] $existingDocuments An array of documents already created for this page.
      * @return array An array of additional \Apache_Solr_Document objects to index
      */
     protected function getAdditionalDocuments(

Classes/Util.php

Doc Comments +4 added lines, -4 removed lines

@@ -239,7 +239,7 @@ 
      * @param integer $pageId Id of the (root) page to get the Solr configuration from.
      * @param string $path The TypoScript configuration path to retrieve.
      * @param boolean $initializeTsfe Optionally initializes a full TSFE to get the configuration, defaults to FALSE
-     * @param integer|boolean $language System language uid or FALSE to disable language usage, optional, defaults to 0
+     * @param integer $language System language uid or FALSE to disable language usage, optional, defaults to 0
      * @return TypoScriptConfiguration The Solr configuration for the requested tree.
      */
     public static function getConfigurationFromPageId(
@@ -314,9 +314,9 @@ 
 
     /**
      * This function is used to retrieve the configuration from an existing TSFE instance
-     * @param $pageId
-     * @param $path
-     * @param $language
+     * @param integer $pageId
+     * @param string $path
+     * @param integer $language
      * @return mixed
      */
     private static function getConfigurationFromExistingTSFE($pageId, $path, $language)

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 
 use ApacheSolrForTypo3\Solr\System\Configuration\ConfigurationManager;
 use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
-use InvalidArgumentException;
 use TYPO3\CMS\Backend\Utility\BackendUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Frontend\Controller\TypoScriptFrontendController;

Classes/ViewHelper/CurrentResultNumber.php

Doc Comments +1 added lines, -1 removed lines

@@ -62,7 +62,7 @@
      * number counting from zero of the total number of results.
      *
      * @param array $arguments
-     * @return string
+     * @return integer
      */
     public function execute(array $arguments = array())
     {

Classes/ViewHelper/SortUrl.php

Doc Comments +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
     /**
      * Returns an URL that switches sorting to the given sort option
      *
-     * @param array $arguments
+     * @param string[] $arguments
      * @return string
      */
     public function execute(array $arguments = array())

Resources/Private/Php/SolrPhpClient/Apache/Solr/Document.php

Doc Comments +1 added lines, -1 removed lines

@@ -102,7 +102,7 @@
     /**
      * Get current document boost
      *
-     * @return mixed will be false for default, or else a float
+     * @return double will be false for default, or else a float
      */
     public function getBoost()
     {

Resources/Private/Php/SolrPhpClient/Apache/Solr/Service.php

Doc Comments +9 added lines, -9 removed lines

@@ -187,7 +187,7 @@ 
      * if not specified.
      *
      * @param string $host
-     * @param string $port
+     * @param integer $port
      * @param string $path
      * @param Apache_Solr_HttpTransport_Interface $httpTransport
      */
@@ -375,7 +375,7 @@ 
     /**
      * Get the set port
      *
-     * @return integer
+     * @return string
      */
     public function getPort()
     {
@@ -557,7 +557,7 @@ 
      * Call the /admin/ping servlet, can be used to quickly tell if a connection to the
      * server is able to be made.
      *
-     * @param float $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
+     * @param integer $timeout maximum time to wait for ping in seconds, -1 for unlimited (default is 2)
      * @return float Actual time taken to ping the server, FALSE if timeout or HTTP error status occurs
      */
     public function ping($timeout = 2)
@@ -817,7 +817,7 @@ 
      * @param boolean $expungeDeletes Defaults to false, merge segments with deletes away
      * @param boolean $waitFlush Not used, will be removed with EXT:solr version 4.0
      * @param boolean $waitSearcher Defaults to true, block until a new searcher is opened and registered as the main query searcher, making the changes visible
-     * @param float $timeout Maximum expected duration (in seconds) of the commit operation on the server (otherwise, will throw a communication exception). Defaults to 1 hour
+     * @param integer $timeout Maximum expected duration (in seconds) of the commit operation on the server (otherwise, will throw a communication exception). Defaults to 1 hour
      * @return Apache_Solr_Response
      *
      * @throws Apache_Solr_HttpTransportException If an error occurs during the service call
@@ -842,7 +842,7 @@ 
      * @param string $id Expected to be utf-8 encoded
      * @param boolean $fromPending
      * @param boolean $fromCommitted
-     * @param float $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
+     * @param integer $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
      * @return Apache_Solr_Response
      *
      * @throws Apache_Solr_HttpTransportException If an error occurs during the service call
@@ -869,7 +869,7 @@ 
      * a complete and well formed "delete" xml document
      *
      * @param string $rawPost Expected to be utf-8 encoded xml document
-     * @param float $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
+     * @param integer $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
      * @return Apache_Solr_Response
      *
      * @throws Apache_Solr_HttpTransportException If an error occurs during the service call
@@ -885,7 +885,7 @@ 
      * @param array $ids Expected to be utf-8 encoded strings
      * @param boolean $fromPending
      * @param boolean $fromCommitted
-     * @param float $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
+     * @param integer $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
      * @return Apache_Solr_Response
      *
      * @throws Apache_Solr_HttpTransportException If an error occurs during the service call
@@ -919,7 +919,7 @@ 
      * @param string $rawQuery Expected to be utf-8 encoded
      * @param boolean $fromPending
      * @param boolean $fromCommitted
-     * @param float $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
+     * @param integer $timeout Maximum expected duration of the delete operation on the server (otherwise, will throw a communication exception)
      * @return Apache_Solr_Response
      *
      * @throws Apache_Solr_HttpTransportException If an error occurs during the service call
@@ -1145,7 +1145,7 @@ 
      *
      * @param boolean $waitFlush Not used, will be removed with EXT:solr version 4.0
      * @param boolean $waitSearcher
-     * @param float $timeout Maximum expected duration of the commit operation on the server (otherwise, will throw a communication exception)
+     * @param integer $timeout Maximum expected duration of the commit operation on the server (otherwise, will throw a communication exception)
      * @return Apache_Solr_Response
      *
      * @throws Apache_Solr_HttpTransportException If an error occurs during the service call