Passed
Pull Request — master (#1817)
by Timo
12:16
created
Classes/System/Records/AbstractRepository.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -90,6 +90,7 @@
 block discarded – undo
90 90
      * Note: Rollback will not work in case of different connections.
91 91
      *
92 92
      * @param string[] ...$tableNames
93
+     * @param string $tableNames
93 94
      * @return Connection
94 95
      */
95 96
     public function getConnectionForAllInTransactionInvolvedTables(string ...$tableNames) : Connection
Please login to merge, or discard this patch.
Classes/Domain/Search/SearchRequestBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -175,7 +175,7 @@
 block discarded – undo
175 175
      * This methods sets the page argument to an expected positive integer value in the arguments array.
176 176
      *
177 177
      * @param array $arguments
178
-     * @return array
178
+     * @return integer
179 179
      */
180 180
     protected function adjustPageArgumentToPositiveInteger(array $arguments)
181 181
     {
Please login to merge, or discard this patch.
Classes/System/Configuration/TypoScriptConfiguration.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -2231,13 +2231,13 @@
 block discarded – undo
2231 2231
         $specificResultsPerGroup = $this->getValueByPathOrDefaultValue($specificPath, null);
2232 2232
 
2233 2233
         if ($specificResultsPerGroup !== null) {
2234
-            return (int) $specificResultsPerGroup;
2234
+            return (int)$specificResultsPerGroup;
2235 2235
         }
2236 2236
 
2237 2237
         $commonPath = 'plugin.tx_solr.search.grouping.numberOfResultsPerGroup';
2238 2238
         $commonValue = $this->getValueByPathOrDefaultValue($commonPath, null);
2239 2239
         if ($commonValue !== null) {
2240
-            return (int) $commonValue;
2240
+            return (int)$commonValue;
2241 2241
         }
2242 2242
 
2243 2243
         return $defaultIfEmpty;
Please login to merge, or discard this patch.
Classes/Domain/Search/SearchRequest.php 1 patch
Braces   +3 added lines, -1 removed lines patch added patch discarded remove patch
@@ -467,7 +467,9 @@
 block discarded – undo
467 467
         $path = $this->prefixWithNamespace('groupPage');
468 468
         $groupPages = $this->argumentsAccessor->get($path);
469 469
         foreach ($groupPages as $groups) {
470
-            if (!is_array($groups)) continue;
470
+            if (!is_array($groups)) {
471
+                continue;
472
+            }
471 473
             foreach ($groups as $groupItemPage) {
472 474
                 if ($groupItemPage > $max) {
473 475
                     $max = $groupItemPage;
Please login to merge, or discard this patch.
Classes/Domain/Search/ResultSet/SearchResultSetService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -361,7 +361,7 @@
 block discarded – undo
361 361
     protected function doASearch($query, $offSet)
362 362
     {
363 363
         $response = $this->search->search($query, $offSet, null);
364
-        if($response === null) {
364
+        if ($response === null) {
365 365
             throw new SolrIncompleteResponseException('The response retrieved from solr was incomplete', 1505989678);
366 366
         }
367 367
 
Please login to merge, or discard this patch.
Classes/ViewHelpers/Facet/Options/Group/Prefix/LabelPrefixesViewHelper.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -89,12 +89,12 @@
 block discarded – undo
89 89
      */
90 90
     protected static function applySortBy(array $prefixes, $sortBy): array
91 91
     {
92
-        if($sortBy === 'count' || $sortBy === '')
92
+        if ($sortBy === 'count' || $sortBy === '')
93 93
         {
94 94
             return $prefixes;
95 95
         }
96 96
 
97
-        if($sortBy === 'alpha')
97
+        if ($sortBy === 'alpha')
98 98
         {
99 99
             sort($prefixes);
100 100
             return $prefixes;
Please login to merge, or discard this patch.
Classes/Controller/Backend/Search/AbstractModuleController.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -277,6 +277,7 @@
 block discarded – undo
277 277
 
278 278
     /**
279 279
      * @param SolrCoreConnection[] $solrCoreConnections
280
+     * @param \ApacheSolrForTypo3\Solr\System\Mvc\Backend\ModuleData $moduleData
280 281
      */
281 282
     private function initializeFirstAvailableSolrCoreConnection(array $solrCoreConnections, $moduleData)
282 283
     {
Please login to merge, or discard this patch.
Classes/Domain/Search/LastSearches/LastSearchesRepository.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@
 block discarded – undo
66 66
         return $queryBuilder
67 67
             ->select('keywords')
68 68
             ->addSelectLiteral(
69
-                $queryBuilder->expr()->max('tstamp','maxtstamp')
69
+                $queryBuilder->expr()->max('tstamp', 'maxtstamp')
70 70
             )
71 71
             ->from($this->table)
72 72
             // There is no support for DISTINCT, a ->groupBy() has to be used instead.
Please login to merge, or discard this patch.
Classes/Domain/Search/ApacheSolrDocument/Repository.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -133,6 +133,7 @@
 block discarded – undo
133 133
      * Initializes Search for given language
134 134
      *
135 135
      * @param int $languageId
136
+     * @param integer $pageId
136 137
      */
137 138
     protected function initializeSearch($pageId, $languageId = 0)
138 139
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -27,7 +27,6 @@
 block discarded – undo
27 27
 use ApacheSolrForTypo3\Solr\ConnectionManager;
28 28
 use ApacheSolrForTypo3\Solr\Domain\Search\Query\QueryBuilder;
29 29
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\Result\Parser\DocumentEscapeService;
30
-use ApacheSolrForTypo3\Solr\Domain\Site\SiteRepository;
31 30
 use ApacheSolrForTypo3\Solr\NoSolrConnectionFoundException;
32 31
 use ApacheSolrForTypo3\Solr\Search;
33 32
 use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
Please login to merge, or discard this patch.