TYPO3-Solr / ext-solr

Classes/Backend/IndexingConfigurationSelectorField.php

Unused Use Statements -2 removed lines

@@ -25,10 +25,8 @@
  ***************************************************************/
 
 use ApacheSolrForTypo3\Solr\Site;
-use ApacheSolrForTypo3\Solr\Util;
 use TYPO3\CMS\Backend\Form\FormResultCompiler;
 use TYPO3\CMS\Backend\Form\NodeFactory;
-use TYPO3\CMS\Core\Page\PageRenderer;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**

Classes/ConnectionManager.php

Unused Use Statements -1 removed lines

@@ -26,7 +26,6 @@
 
 use TYPO3\CMS\Backend\Toolbar\ClearCacheActionsHookInterface;
 use TYPO3\CMS\Backend\Utility\BackendUtility;
-use TYPO3\CMS\Backend\Utility\IconUtility;
 use TYPO3\CMS\Core\SingletonInterface;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
 use TYPO3\CMS\Core\Imaging\Icon;

Classes/ContentObject/Relation.php

Doc Comments -1 removed lines

@@ -119,7 +119,6 @@
     /**
      * Gets the related items of the current record's configured field.
      *
-     * @param array $configuration for the content object
      * @param ContentObjectRenderer $parentContentObject parent content object
      * @return array Array of related items, values already resolved from related records
      */

Unused Use Statements -1 removed lines

@@ -25,7 +25,6 @@
  ***************************************************************/
 
 use ApacheSolrForTypo3\Solr\Tests\Unit\UnitTest;
-use ApacheSolrForTypo3\Solr\Util;
 use ApacheSolrForTypo3\Solr\ViewHelper\Ts;
 use TYPO3\CMS\Core\TypoScript\TemplateService;
 use TYPO3\CMS\Core\Utility\GeneralUtility;

Classes/Controller/AdministrationController.php

Doc Comments +1 added lines, -1 removed lines

@@ -294,7 +294,7 @@
     }
 
     /**
-     * @param $site
+     * @param Site $site
      */
     protected function setSiteAndResetCore($site)
     {

Indentation +4 added lines, -4 removed lines

@@ -169,10 +169,10 @@
     {
     }
 
-     /**
-     * Call a sub-module's controller
-     *
-     */
+        /**
+         * Call a sub-module's controller
+         *
+         */
     protected function invokeModuleController()
     {
         $activeModuleDescription = $this->moduleManager->getModuleDescription($this->activeModuleName);

Classes/Domain/Index/IndexService.php

Doc Comments +1 added lines, -1 removed lines

@@ -136,7 +136,7 @@
     /**
      * Emits a signal after all items was indexed
      *
-     * @param array $itemsToIndex
+     * @param Item[] $itemsToIndex
      */
     protected function emitAfterIndexItemsSignal($itemsToIndex)
     {

Unused Use Statements -5 removed lines

@@ -30,14 +30,9 @@
 use ApacheSolrForTypo3\Solr\IndexQueue\Queue;
 use ApacheSolrForTypo3\Solr\Site;
 use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
-use ApacheSolrForTypo3\Solr\System\Environment\CliEnvironment;
 use ApacheSolrForTypo3\Solr\Task\IndexQueueWorkerTask;
-use ApacheSolrForTypo3\Solr\Util;
 use TYPO3\CMS\Backend\Utility\BackendUtility;
-use TYPO3\CMS\Core\Utility\ExtensionManagementUtility;
 use TYPO3\CMS\Core\Utility\GeneralUtility;
-use TYPO3\CMS\Core\SingletonInterface;
-use TYPO3\CMS\Core\Utility\ArrayUtility;
 
 /**
  * Service to perform indexing operations

Classes/Domain/Search/LastSearches/LastSearchesService.php

Doc Comments +1 added lines, -1 removed lines

@@ -136,7 +136,7 @@
     /**
      * Gets the last searched keywords from the database
      *
-     * @param integer|bool $limit
+     * @param integer $limit
      * @return array An array containing the last searches of the current user
      */
     protected function getLastSearchesFromDatabase($limit = false)

Spacing +2 added lines, -2 removed lines

@@ -98,7 +98,7 @@ 
      */
     public function addToLastSearches($keywords)
     {
-        $mode   = $this->configuration->getSearchLastSearchesMode();
+        $mode = $this->configuration->getSearchLastSearchesMode();
         switch ($mode) {
             case 'user':
                 $this->storeKeywordsToSession($keywords);
@@ -227,7 +227,7 @@ 
     protected function getNextSequenceId()
     {
         $nextSequenceId = 0;
-        $numberOfLastSearchesToLog = (int) $this->configuration->getSearchLastSearchesLimit();
+        $numberOfLastSearchesToLog = (int)$this->configuration->getSearchLastSearchesLimit();
 
         $row = $this->database->exec_SELECTgetRows(
             '(sequence_id + 1) % ' . $numberOfLastSearchesToLog . ' as next_sequence_id',

Classes/Domain/Search/ResultSet/SearchResultSetService.php

Doc Comments +2 added lines, -2 removed lines

@@ -421,7 +421,7 @@ 
     /**
      * Checks it the results should be hidden in the response.
      *
-     * @param $rawQuery
+     * @param string $rawQuery
      * @return bool
      */
     protected function shouldHideResultsFromInitialSearch($rawQuery)
@@ -613,7 +613,7 @@ 
     }
 
     /**
-     * @param $requestedPerPage
+     * @param integer $requestedPerPage
      */
     protected function setPerPageInSession($requestedPerPage)
     {

Spacing +7 added lines, -9 removed lines

@@ -287,7 +287,7 @@ 
      * @param Query $query The query that has been searched for.
      * @param \Apache_Solr_Response $response The search's response.
      */
-    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response &$response)
+    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response & $response)
     {
         if ($this->shouldHideResultsFromInitialSearch($rawQuery)) {
             // explicitly set number of results to 0 as we just wanted
@@ -315,7 +315,7 @@ 
      *
      * @param \Apache_Solr_Response $response
      */
-    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response &$response)
+    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response & $response)
     {
         if (!is_array($response->response->docs)) {
             return;
@@ -367,7 +367,7 @@ 
      * @param \Apache_Solr_Response $response
      * @throws \InvalidArgumentException
      */
-    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response &$response)
+    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response & $response)
     {
         if (!is_array($response->response->docs)) {
             return;
@@ -392,7 +392,7 @@ 
         $searchResultClassName = $this->getResultClassName();
         $result = GeneralUtility::makeInstance($searchResultClassName, $originalDocument);
         if (!$result instanceof SearchResult) {
-            throw new \InvalidArgumentException("Could not create result object with class: " . (string) $searchResultClassName, 1470037679);
+            throw new \InvalidArgumentException("Could not create result object with class: " . (string)$searchResultClassName, 1470037679);
         }
 
         return $result;
@@ -404,8 +404,7 @@ 
     protected function getResultClassName()
     {
         return isset($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultClassName ']) ?
-            $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultClassName '] :
-            'ApacheSolrForTypo3\\Solr\\Domain\\Search\\ResultSet\\SearchResult';
+            $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultClassName '] : 'ApacheSolrForTypo3\\Solr\\Domain\\Search\\ResultSet\\SearchResult';
     }
 
     /**
@@ -414,8 +413,7 @@ 
     protected function getResultSetClassName()
     {
         return isset($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultSetClassName ']) ?
-            $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultSetClassName '] :
-            'ApacheSolrForTypo3\\Solr\\Domain\\Search\\ResultSet\\SearchResultSet';
+            $GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultSetClassName '] : 'ApacheSolrForTypo3\\Solr\\Domain\\Search\\ResultSet\\SearchResultSet';
     }
 
     /**
@@ -561,7 +559,7 @@ 
         $response = $this->search->search($query, 0, 1);
         $this->processResponse($documentId, $query, $response);
 
-        $resultDocument = isset($response->response->docs[0]) ?  $response->response->docs[0] : null;
+        $resultDocument = isset($response->response->docs[0]) ? $response->response->docs[0] : null;
         return $resultDocument;
     }
 

Unused Use Statements -1 removed lines

@@ -29,7 +29,6 @@
 use ApacheSolrForTypo3\Solr\Domain\Search\ResultSet\SearchResultSetService;
 use ApacheSolrForTypo3\Solr\Domain\Search\SearchRequest;
 use ApacheSolrForTypo3\Solr\Search;
-use ApacheSolrForTypo3\Solr\SolrService;
 use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
 use ApacheSolrForTypo3\Solr\Tests\Unit\UnitTest;
 use TYPO3\CMS\Frontend\Plugin\AbstractPlugin;

Classes/Domain/Search/SearchRequest.php

Unused Use Statements -3 removed lines

@@ -24,12 +24,9 @@
  *
  *  This copyright notice MUST APPEAR in all copies of the script!
  ***************************************************************/
-use ApacheSolrForTypo3\Solr\System\Configuration\ConfigurationManager;
 use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
 use ApacheSolrForTypo3\Solr\System\Util\ArrayAccessor;
-use ApacheSolrForTypo3\Solr\Util;
 use TYPO3\CMS\Core\Utility\ArrayUtility;
-use TYPO3\CMS\Core\Utility\GeneralUtility;
 
 /**
  * The searchRequest is used to act as an api to the arguments that have been passed

Spacing +5 added lines, -5 removed lines

@@ -143,7 +143,7 @@ 
      */
     protected function prefixWithNamespace($path)
     {
-        return $this->argumentNameSpace . ':'.$path;
+        return $this->argumentNameSpace . ':' . $path;
     }
 
     /**
@@ -227,7 +227,7 @@ 
         }
 
         $facetValues = $this->getActiveFacets();
-        $facetValues[] = $facetName.':'.$facetValue;
+        $facetValues[] = $facetName . ':' . $facetValue;
         $this->setActiveFacets($facetValues);
 
         $this->stateChanged = true;
@@ -248,7 +248,7 @@ 
             return $this;
         }
         $facetValues = $this->getActiveFacets();
-        $facetValueToLookFor = $facetName.':'.$facetValue;
+        $facetValueToLookFor = $facetName . ':' . $facetValue;
 
         foreach ($facetValues as $index => $facetValue) {
             if ($facetValue === $facetValueToLookFor) {
@@ -306,7 +306,7 @@ 
      */
     public function getHasFacetValue($facetName, $facetValue)
     {
-        $facetNameAndValueToCheck = $facetName.':'.$facetValue;
+        $facetNameAndValueToCheck = $facetName . ':' . $facetValue;
         foreach ($this->getActiveFacets() as $activeFacet) {
             if ($activeFacet == $facetNameAndValueToCheck) {
                 return true;
@@ -392,7 +392,7 @@ 
      */
     public function setSorting($sortingName, $direction = 'asc')
     {
-        $value = $sortingName.' '.$direction;
+        $value = $sortingName . ' ' . $direction;
         $path = $this->prefixWithNamespace('sort');
         $this->argumentsAccessor->set($path, $value);
         $this->stateChanged = true;

Doc Comments +5 added lines, -5 removed lines

@@ -138,7 +138,7 @@ 
     /**
      * Helper method to prefix an accessor with the arguments namespace.
      *
-     * @param $path
+     * @param string $path
      * @return string
      */
     protected function prefixWithNamespace($path)
@@ -200,7 +200,7 @@ 
 
     /**
      * @param $activeFacets
-     * @return array|null
+     * @return SearchRequest
      *
      * @return SearchRequest
      */
@@ -328,7 +328,7 @@ 
     /**
      * Returns the sorting string in the url e.g. title asc.
      *
-     * @return string|null
+     * @return string
      */
     protected function getSorting()
     {
@@ -339,8 +339,8 @@ 
     /**
      * Helper function to get the sorting configuration name or direction.
      *
-     * @param $index
-     * @return null
+     * @param integer $index
+     * @return string
      */
     protected function getSortingPart($index)
     {

Classes/Facet/AbstractFacetRenderer.php

Doc Comments +1 added lines

@@ -153,6 +153,7 @@
     /**
      * Renders a numeric range facet by providing a slider
      *
+     * @return string
      */
     abstract protected function renderFacetOptions();