TYPO3-Solr / ext-solr

Classes/ConnectionManager.php

Unused Use Statements -1 removed lines

@@ -27,7 +27,6 @@
 use ApacheSolrForTypo3\Solr\NoSolrConnectionFoundException;
 use ApacheSolrForTypo3\Solr\Site;
 use ApacheSolrForTypo3\Solr\SolrService;
-use ApacheSolrForTypo3\Solr\System\Configuration\TypoScriptConfiguration;
 use ApacheSolrForTypo3\Solr\System\Page\Rootline;
 use TYPO3\CMS\Backend\Routing\UriBuilder;
 use TYPO3\CMS\Backend\Toolbar\ClearCacheActionsHookInterface;

Classes/Backend/SolrModule/IndexMaintenanceModuleController.php

Spacing +1 added lines, -1 removed lines

@@ -123,7 +123,7 @@
 
         if ($coresReloaded) {
             $this->addFlashMessage(
-                'Core configuration reloaded ('.implode(', ', $reloadedCores).').',
+                'Core configuration reloaded (' . implode(', ', $reloadedCores) . ').',
                 '',
                 FlashMessage::OK
             );

Classes/IndexQueue/FrontendHelper/PageIndexer.php

Spacing +1 added lines, -1 removed lines

@@ -173,7 +173,7 @@
             'auth', // service type
             AuthorizationService::class,
             // service key
-            [ // service meta data
+            [// service meta data
                 'title' => 'Solr Indexer Authorization',
                 'description' => 'Authorizes the Solr Index Queue indexer to access protected pages.',
 

Classes/System/TCA/TCAService.php

Spacing +1 added lines, -1 removed lines

@@ -48,7 +48,7 @@
      */
     public function __construct($TCA = null)
     {
-        $this->tca = (array) (is_null($TCA) ? $GLOBALS['TCA'] : $TCA);
+        $this->tca = (array)(is_null($TCA) ? $GLOBALS['TCA'] : $TCA);
     }
 
     /**

Classes/Query.php

Doc Comments +3 added lines, -3 removed lines

@@ -194,7 +194,7 @@ 
      *
      * @param string $msg
      * @param int $severity
-     * @param mixed $dataVar
+     * @param string[] $dataVar
      */
     protected function writeDevLog($msg, $severity = 0, $dataVar = false)
     {
@@ -1024,7 +1024,7 @@ 
     /**
      * Sets the fields to return by a query.
      *
-     * @param array|string $fieldList an array or comma-separated list of field names
+     * @param string $fieldList an array or comma-separated list of field names
      * @throws \UnexpectedValueException on parameters other than comma-separated lists and arrays
      */
     public function setFieldList($fieldList = ['*', 'score'])
@@ -1100,7 +1100,7 @@ 
      *
      * This query supports the complete Lucene Query Language.
      *
-     * @param mixed $alternativeQuery String alternative query or boolean FALSE to disable / reset the q.alt parameter.
+     * @param string $alternativeQuery String alternative query or boolean FALSE to disable / reset the q.alt parameter.
      * @see http://wiki.apache.org/solr/DisMaxQParserPlugin#q.alt
      */
     public function setAlternativeQuery($alternativeQuery)

Spacing +4 added lines, -4 removed lines

@@ -164,7 +164,7 @@ 
      */
     public function __construct($keywords, $solrConfiguration = null, SiteHashService $siteHashService = null)
     {
-        $keywords = (string) $keywords;
+        $keywords = (string)$keywords;
 
         $this->solrConfiguration = is_null($solrConfiguration) ? Util::getSolrConfiguration() : $solrConfiguration;
         $this->siteHashService = is_null($siteHashService) ? GeneralUtility::makeInstance(SiteHashService::class) : $siteHashService;
@@ -683,7 +683,7 @@ 
      */
     public function getGroupFields()
     {
-        return (array) $this->getQueryParameter('group.field', []);
+        return (array)$this->getQueryParameter('group.field', []);
     }
 
     /**
@@ -706,7 +706,7 @@ 
      */
     public function getGroupSortings()
     {
-        return (array) $this->getQueryParameter('group.sort', []);
+        return (array)$this->getQueryParameter('group.sort', []);
     }
 
     // faceting
@@ -732,7 +732,7 @@ 
      */
     public function getGroupQueries()
     {
-        return (array) $this->getQueryParameter('group.query', []);
+        return (array)$this->getQueryParameter('group.query', []);
     }
 
     /**

Classes/ViewHelper/Split.php

Spacing +2 added lines, -2 removed lines

@@ -51,14 +51,14 @@
     public function execute(array $arguments = [])
     {
         try {
-            $iterator  = unserialize($arguments[0]);
+            $iterator = unserialize($arguments[0]);
         } catch (\Exception $e) {
             $iterator = [];
         }
         if ($iterator === false) {
             $iterator = [];
         }
-        $variable  = $arguments[1];
+        $variable = $arguments[1];
 
         $data = '';
         foreach ($iterator as $value) {

Classes/Site.php

Spacing +3 added lines, -3 removed lines

@@ -255,7 +255,7 @@ 
     {
         /** @var $registry Registry */
         $registry = GeneralUtility::makeInstance(Registry::class);
-        $servers = (array) $registry->get('tx_solr', 'servers', []);
+        $servers = (array)$registry->get('tx_solr', 'servers', []);
         return $servers;
     }
 
@@ -339,7 +339,7 @@ 
         $recursionRootPageId = intval($rootPageId);
         if ($rootPageId == 'SITE_ROOT') {
             $recursionRootPageId = $this->rootPage['uid'];
-            $pageIds[] = (int) $this->rootPage['uid'];
+            $pageIds[] = (int)$this->rootPage['uid'];
         }
 
         if ($maxDepth <= 0) {
@@ -381,7 +381,7 @@ 
         $result = $GLOBALS['TYPO3_DB']->exec_SELECTquery('uid', 'pages', 'pid = ' . $recursionRootPageId . ' ' . BackendUtility::deleteClause('pages') . $initialPagesAdditionalWhereClause);
 
         while ($page = $GLOBALS['TYPO3_DB']->sql_fetch_assoc($result)) {
-            $pageIds[] = (int) $page['uid'];
+            $pageIds[] = (int)$page['uid'];
 
             if ($maxDepth > 1) {
                 $pageIds = array_merge($pageIds, $this->getPages($page['uid'], $maxDepth - 1));

Classes/Domain/Search/ResultSet/SearchResultSetService.php

Spacing +3 added lines, -3 removed lines

@@ -282,7 +282,7 @@ 
      * @param Query $query The query that has been searched for.
      * @param \Apache_Solr_Response $response The search's response.
      */
-    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response &$response)
+    protected function processResponse($rawQuery, Query $query, \Apache_Solr_Response & $response)
     {
         if ($this->shouldHideResultsFromInitialSearch($rawQuery)) {
             // explicitly set number of results to 0 as we just wanted
@@ -310,7 +310,7 @@ 
      *
      * @param \Apache_Solr_Response $response
      */
-    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response &$response)
+    protected function addExpandedDocumentsFromVariants(\Apache_Solr_Response & $response)
     {
         if (!is_array($response->response->docs)) {
             return;
@@ -362,7 +362,7 @@ 
      * @param \Apache_Solr_Response $response
      * @throws \Apache_Solr_ParserException
      */
-    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response &$response)
+    protected function wrapResultDocumentInResultObject(\Apache_Solr_Response & $response)
     {
         try {
             $documents = $response->response->docs;

Classes/Domain/Search/Statistics/StatisticsRepository.php

Spacing +9 added lines, -9 removed lines

@@ -43,9 +43,9 @@ 
     public function getSearchStatistics($rootPageId, $days = 30, $limit = 10)
     {
         $now = time();
-        $timeStart = (int) ($now - 86400 * intval($days)); // 86400 seconds/day
-        $rootPageId = (int) $rootPageId;
-        $limit = (int) $limit;
+        $timeStart = (int)($now - 86400 * intval($days)); // 86400 seconds/day
+        $rootPageId = (int)$rootPageId;
+        $limit = (int)$limit;
 
         $statisticsRows = $this->getDatabase()->exec_SELECTgetRows(
             'keywords, count(keywords) as count, num_found as hits',
@@ -63,7 +63,7 @@ 
             $sumCount += $statisticsRow['count'];
         }
 
-        $statisticsRows = array_map(function ($row) use ($sumCount) {
+        $statisticsRows = array_map(function($row) use ($sumCount) {
             $row['percent'] = $row['count'] * 100 / $sumCount;
 
             return $row;
@@ -109,9 +109,9 @@ 
      */
     protected function getTopKeyWordsWithOrWithoutHits($rootPageId, $days = 30, $limit, $withoutHits)
     {
-        $rootPageId = (int) $rootPageId;
-        $limit = (int) $limit;
-        $withoutHits = (bool) $withoutHits;
+        $rootPageId = (int)$rootPageId;
+        $limit = (int)$limit;
+        $withoutHits = (bool)$withoutHits;
 
         $now = time();
         $timeStart = $now - 86400 * intval($days); // 86400 seconds/day
@@ -155,7 +155,7 @@ 
 
                 // for the hits we need to take the average
             $avgHits = $this->getAverageFromField($mergedRow, $statisticsRow, 'hits');
-            $mergedRow['hits'] = (int) $avgHits;
+            $mergedRow['hits'] = (int)$avgHits;
 
                 // for the count we need to take the sum, because it's the sum of searches
             $mergedRow['count'] = $mergedRow['count'] + $statisticsRow['count'];
@@ -199,7 +199,7 @@ 
      * @param string $fieldName
      * @return float|int
      */
-    protected function getAverageFromField(array &$mergedRow, array $statisticsRow,  $fieldName)
+    protected function getAverageFromField(array &$mergedRow, array $statisticsRow, $fieldName)
     {
         // when this is the first row we can take it.
         if ($mergedRow['mergedrows'] === 1) {