ApacheSolrForTypo3\Solr\Eid\ApiEid::main()

Complexity

Conditions	3
Paths	3

Size

Total Lines	23
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function main(ServerRequestInterface $request): ResponseInterface
    {
        $api = GeneralUtility::_GP('api');
        $apiKey = trim(GeneralUtility::_GP('apiKey'));

It seems like TYPO3\CMS\Core\Utility\GeneralUtility::_GP('apiKey') can also be of type null; however, parameter $string of trim() does only seem to accept string, maybe add an additional type check?

        if (!Api::isValidApiKey($apiKey)) {
            header(HttpUtility::HTTP_STATUS_403);
            header('Content-Type: application/json; charset=utf-8');
            echo json_encode(['errorMessage' => 'Invalid API key']);
        } else {
            switch ($api) {
                case 'siteHash':
                    include('SiteHash.php');
                    break;

                default:
                    header(HttpUtility::HTTP_STATUS_400);
                    header('Content-Type: application/json; charset=utf-8');
                    echo json_encode(['errorMessage' => 'You must provide an available API method, e.g. siteHash.']);
                    break;
            }
        }
        return new Response();
    }