ManageCronTask::createCronTask() - Code Metrics - TMSolution/CronBundle - Measure and Improve Code Quality continuously with Scrutinizer

ManageCronTask::createCronTask() A
last analyzed 2015-12-01 14:21 UTC

↳ Parent: ManageCronTask

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	14
rs	9.4286
cc	1
eloc	11
nc	1
nop	6

<?php

/**
 * Copyright (c) 2014,TMSolution <[email protected]>
 * All rights reserved.
 *
 * For the full copyright and license information, please view
 * the file LICENSE.md that was distributed with this source code.
 */

namespace TMSolution\CronBundle\Service;

use TMSolution\CronBundle\Entity\CronTask;
use Doctrine\ORM\EntityManager;

/**
 * @author Łukasz Wawrzyniak <[email protected]>
 * 
 */
class ManageCronTask
{

    const EXEC_CLI = 1;
    const EXEC_SYMFONYCLI = 2;
    const EXEC_REST = 3;
    const EXEC_SYMFONYSERVICE = 4;

    protected $em;

    public function __construct(EntityManager $entityManager)
    {
        $this->em = $entityManager;
    }

    public function createCronTask($name, array $commands, $execType, \DateTime $firstRun, $interval = 0, $repeatable = 0)
    {
        $cronTask = new CronTask();
        $cronTask->setName($name);
        $cronTask->setCommands($commands);
        $cronTask->setExecType($execType);
        $cronTask->setFirstRun($firstRun);
        $cronTask->setInterval($interval);
        $cronTask->setRepeatable($repeatable);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->em->persist($cronTask);
        $this->em->flush();

        return $cronTask;
    }

}


1			<?php
2
3			/**
4			* Copyright (c) 2014,TMSolution <[email protected]>
5			* All rights reserved.
6			*
7			* For the full copyright and license information, please view
8			* the file LICENSE.md that was distributed with this source code.
9			*/
10
11			namespace TMSolution\CronBundle\Service;
12
13			use TMSolution\CronBundle\Entity\CronTask;
14			use Doctrine\ORM\EntityManager;
15
16			/**
17			* @author Łukasz Wawrzyniak <[email protected]>
18			*
19			*/
20			class ManageCronTask
21			{
22
23			const EXEC_CLI = 1;
24			const EXEC_SYMFONYCLI = 2;
25			const EXEC_REST = 3;
26			const EXEC_SYMFONYSERVICE = 4;
27
28			protected $em;
29
30			public function __construct(EntityManager $entityManager)
31			{
32			$this->em = $entityManager;
33			}
34
35			public function createCronTask($name, array $commands, $execType, \DateTime $firstRun, $interval = 0, $repeatable = 0)
36			{
37			$cronTask = new CronTask();
38			$cronTask->setName($name);
39			$cronTask->setCommands($commands);
40			$cronTask->setExecType($execType);
41			$cronTask->setFirstRun($firstRun);
42			$cronTask->setInterval($interval);
43			$cronTask->setRepeatable($repeatable);
			0 ignored issues – show Documentation introduced 2015-12-01 14:21 UTC by Report Bug Copy Issue Report `$repeatable` is of type `integer`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
44			$this->em->persist($cronTask);
45			$this->em->flush();
46
47			return $cronTask;
48			}
49
50			}
51

TMSolution / CronBundle

GitHub Access Token became invalid

ManageCronTask::createCronTask() A last analyzed 2015-12-01 14:21 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

ManageCronTask::createCronTask() A
last analyzed 2015-12-01 14:21 UTC