FilesystemWriter::write() - Code Metrics - Inspection of "Before di" - Symplify/PHP7_Sculpin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#10)

by Tomáš

created 2016-09-23 19:59 UTC

FilesystemWriter::write() A

↳ Parent: FilesystemWriter

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2.0932

Importance

Changes

Metric	Value
dl	0
loc	10
ccs	5
cts	7
cp	0.7143
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1
crap	2.0932

<?php

/*
 * This file is a part of Sculpin.
 *
 * (c) Dragonfly Development Inc.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Symplify\PHP7_Sculpin\Output;

use Symfony\Component\Filesystem\Filesystem;

final class FilesystemWriter
{
    /**
     * @var Filesystem
     */
    private $filesystem;

    /**
     * @var string
     */
    private $outputDir;

    public function __construct(Filesystem $filesystem, string $outputDir)
    {
        $this->filesystem = $filesystem;
        $this->outputDir = $outputDir;
    }

    public function write(SourceOutput $output)
    {
        $outputPath = $this->outputDir.'/'.$output->permalink()->relativeFilePath();
        if ($output->hasFileReference()) {
            $this->filesystem->copy($output->file(), $outputPath, true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } else {
            $this->filesystem->mkdir(dirname($outputPath));
            file_put_contents($outputPath, $output->formattedContent());
        }
    }
}


1		<?php
2
3		/*
4		* This file is a part of Sculpin.
5		*
6		* (c) Dragonfly Development Inc.
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Symplify\PHP7_Sculpin\Output;
13
14		use Symfony\Component\Filesystem\Filesystem;
15
16		final class FilesystemWriter
17		{
18		/**
19		* @var Filesystem
20		*/
21		private $filesystem;
22
23		/**
24		* @var string
25		*/
26		private $outputDir;
27
28	1	public function __construct(Filesystem $filesystem, string $outputDir)
29		{
30	1	$this->filesystem = $filesystem;
31	1	$this->outputDir = $outputDir;
32	1	}
33
34	1	public function write(SourceOutput $output)
35		{
36	1	$outputPath = $this->outputDir.'/'.$output->permalink()->relativeFilePath();
37	1	if ($output->hasFileReference()) {
38	1	$this->filesystem->copy($output->file(), $outputPath, true);
		0 ignored issues – show Documentation introduced 2016-09-18 20:42 UTC by Report Bug Copy Issue Report `$output->file()` is of type `object<SplFileInfo>\|null`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
39		} else {
40		$this->filesystem->mkdir(dirname($outputPath));
41		file_put_contents($outputPath, $output->formattedContent());
42		}
43	1	}
44		}
45

Symplify / PHP7_Sculpin

Pull Request — master (#10)

FilesystemWriter::write() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like