FileSource::init() - Code Metrics - Inspection of "Complete rewrite - Version 3" - Symplify/PHP7_Sculpin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Tomáš

created 2016-09-25 10:37 UTC

FileSource::init() C

↳ Parent: Project

Complexity

Conditions	11
Paths	42

Size

Total Lines	67
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	26
CRAP Score	13.0563

Importance

Changes

Metric	Value
dl	0
loc	67
ccs	26
cts	35
cp	0.7429
rs	5.8904
c	0
b	0
f	0
cc	11
eloc	39
nc	42
nop	1
crap	13.0563

How to fix Long Method Complexity

<?php


/*
 * This file is a part of Sculpin.
 *
 * (c) Dragonfly Development Inc.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Symplify\PHP7_Sculpin\Source;

use Symfony\Component\Finder\SplFileInfo;
use Dflydev\Canal\Analyzer\Analyzer;
use Dflydev\DotAccessConfiguration\Configuration as Data;
use Dflydev\DotAccessConfiguration\YamlConfigurationBuilder as YamlDataBuilder;

final class FileSource extends AbstractSource

{


    protected function init(bool $hasChanged = null)
    {
    $content = file_get_contents($this->file);

    // extract data from file!
    if (preg_match('/^\s*(?:---[\s]*[\r\n]+)(.*?)(?:---[\s]*[\r\n]+)(.*?)$/s', $content, $matches)) {
        $this->content = $matches[2];
        if (preg_match('/^(\s*[-]+\s*|\s*)$/', $matches[1])) {
            // There is nothing useful in the YAML front matter.
            $this->data = new Data();
        } else {
            // There may be YAML frontmatter
            try {
                $builder = new YamlDataBuilder($matches[1]);
                $this->data = $builder->build();
            } catch (\InvalidArgumentException $e) {
                // Likely not actually YAML front matter available,
                // treat the entire file as pure content.
                echo ' ! '.$this->sourceId().' '.$e->getMessage().' !'.PHP_EOL;
                $this->content = $content;
                $this->data = new Data();
            }
        }
    } else {
        $this->content = $content;
        $this->data = new Data();
        $this->canBeFormatted = false;
}
}



1		<?php
		0 ignored issues – show Coding Style Compatibility introduced 2016-09-25 10:41 UTC by Report Bug Copy Issue Report For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 23 and the first side effect is on line 19. The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file. The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place. To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1. Loading history...
2
3		/*
4		* This file is a part of Sculpin.
5		*
6		* (c) Dragonfly Development Inc.
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace Symplify\PHP7_Sculpin\Source;
13
14		use Symfony\Component\Finder\SplFileInfo;
15		use Dflydev\Canal\Analyzer\Analyzer;
16		use Dflydev\DotAccessConfiguration\Configuration as Data;
17		use Dflydev\DotAccessConfiguration\YamlConfigurationBuilder as YamlDataBuilder;
18
19		final class FileSource extends AbstractSource
		0 ignored issues – show Bug introduced 2016-09-25 10:41 UTC by Report Bug Copy Issue Report Possible parse error: class missing opening or closing brace Loading history...
20		{
21
22
23		protected function init(bool $hasChanged = null)
24		{
25		$content = file_get_contents($this->file);
26
27		// extract data from file!
28		if (preg_match('/^\s(?:---[\s][\r\n]+)(.?)(?:---[\s][\r\n]+)(.*?)$/s', $content, $matches)) {
29		$this->content = $matches[2];
30		if (preg_match('/^(\s[-]+\s\|\s*)$/', $matches[1])) {
31	6	// There is nothing useful in the YAML front matter.
32		$this->data = new Data();
33		} else {
34		// There may be YAML frontmatter
35		try {
36		$builder = new YamlDataBuilder($matches[1]);
37		$this->data = $builder->build();
38	6	} catch (\InvalidArgumentException $e) {
39	6	// Likely not actually YAML front matter available,
40	6	// treat the entire file as pure content.
41	6	echo ' ! '.$this->sourceId().' '.$e->getMessage().' !'.PHP_EOL;
42	6	$this->content = $content;
43	6	$this->data = new Data();
44	6	}
45		}
46	6	} else {
47	6	$this->content = $content;
48		$this->data = new Data();
49	6	$this->canBeFormatted = false;
50	6	}
51		}
52
		0 ignored issues – show Bug introduced 2016-09-25 10:41 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected EOF, expecting T_FUNCTION Loading history...

Symplify / PHP7_Sculpin

Pull Request — master (#14)

FileSource::init() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like