KernelFactory::create() - Code Metrics - Inspection of "Cleanup, php7, improve test coverage" - Symplify/PHP7_Sculpin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

by Tomáš

created 2016-09-21 14:46 UTC

KernelFactory::create() A

↳ Parent: KernelFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	19
ccs	0
cts	11
cp	0
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	8
nc	2
nop	0
crap	6

<?php

/*
 * This file is a part of Sculpin.
 *
 * (c) Dragonfly Development Inc.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Symplify\PHP7_Sculpin\Bundle\SculpinBundle\HttpKernel;

use Symfony\Component\HttpKernel\KernelInterface;

final class KernelFactory
{
    public static function create() : KernelInterface
    {
        $env = 'debug';
        $debug = true;

        // We are relying on our calling script to chdir as appropriate with any
        // --project-directory that was specified.
        $projectDir = getcwd();

        if (file_exists($customKernel = $projectDir.'/app/SculpinKernel.php')) {
            require $customKernel;

            return new \SculpinKernel($env, $debug, $projectDir);
        }

        // Fallback to using the default kernel in case
        // user does not define their own kernel somehow.
        return new DefaultKernel($env, $debug, $projectDir);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			/*
4			* This file is a part of Sculpin.
5			*
6			* (c) Dragonfly Development Inc.
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Symplify\PHP7_Sculpin\Bundle\SculpinBundle\HttpKernel;
13
14			use Symfony\Component\HttpKernel\KernelInterface;
15
16			final class KernelFactory
17			{
18			public static function create() : KernelInterface
19			{
20			$env = 'debug';
21			$debug = true;
22
23			// We are relying on our calling script to chdir as appropriate with any
24			// --project-directory that was specified.
25			$projectDir = getcwd();
26
27			if (file_exists($customKernel = $projectDir.'/app/SculpinKernel.php')) {
28			require $customKernel;
29
30			return new \SculpinKernel($env, $debug, $projectDir);
31			}
32
33			// Fallback to using the default kernel in case
34			// user does not define their own kernel somehow.
35			return new DefaultKernel($env, $debug, $projectDir);
			0 ignored issues – show Documentation introduced 2016-09-18 08:08 UTC by Report Bug Copy Issue Report `$debug` is of type `boolean`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
36			}
37			}
38

Symplify / PHP7_Sculpin

Pull Request — master (#6)

KernelFactory::create() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like