PaginationGenerator::generate() - Code Metrics - Inspection of "Cleanup, php7, improve test coverage" - Symplify/PHP7_Sculpin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

by Tomáš

created 2016-09-21 14:32 UTC

PaginationGenerator::generate() F

↳ Parent: PaginationGenerator

Complexity

Conditions	20
Paths	14416

Size

Total Lines	100
Code Lines	67

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	420

Importance

Changes

Metric	Value
dl	0
loc	100
ccs	0
cts	86
cp	0
rs	2
c	0
b	0
f	0
cc	20
eloc	67
nc	14416
nop	1
crap	420

How to fix Long Method Complexity

<?php

/*
 * This file is a part of Sculpin.
 *
 * (c) Dragonfly Development Inc.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Symplify\PHP7_Sculpin\Bundle\PaginationBundle;

use Symplify\PHP7_Sculpin\Core\DataProvider\DataProviderManager;
use Symplify\PHP7_Sculpin\Core\Generator\GeneratorInterface;
use Symplify\PHP7_Sculpin\Core\Permalink\SourcePermalinkFactory;
use Symplify\PHP7_Sculpin\Core\Source\SourceInterface;

final class PaginationGenerator implements GeneratorInterface
{
    /**
     * @var DataProviderManager
     */
    private $dataProviderManager;

    /**
     * @var int
     */
    private $maxPerPage;

    /**
     * @var SourcePermalinkFactory
     */
    private $sourcePermalinkFactory;

    public function __construct(
        DataProviderManager $dataProviderManager,
        int $maxPerPage,
        SourcePermalinkFactory $sourcePermalinkFactory
    ) {
        $this->dataProviderManager = $dataProviderManager;
        $this->maxPerPage = $maxPerPage;
        $this->sourcePermalinkFactory = $sourcePermalinkFactory;
    }

    /**
     * {@inheritdoc}
     */
    public function generate(SourceInterface $source) : array
    {
        $data = null;
        $config = $source->data()->get('pagination') ?: [];
        if (!isset($config['provider'])) {
            $config['provider'] = 'data.posts';
        }
        if (preg_match('/^(data|page)\.(.+)$/', $config['provider'], $matches)) {
            switch ($matches[1]) {
                case 'data':
                    $data = $this->dataProviderManager->dataProvider($matches[2])->provideData();
                    break;
                case 'page':
                    $data = $source->data()->get($matches[2]);
                    break;
            }
        }

        if (null === $data) {
            return [];
        }

        $maxPerPage = isset($config['max_per_page']) ? $config['max_per_page'] : $this->maxPerPage;

        $slices = [];
        $slice = [];
        $totalItems = 0;
        foreach ($data as $k => $v) {
            if (count($slice) == $maxPerPage) {
                $slices[] = $slice;
                $slice = [];
            }

            $slice[$k] = $v;
            ++$totalItems;
        }

        if (count($slice)) {
            $slices[] = $slice;
        }

        $sources = [];
        $pageNumber = 0;
        foreach ($slices as $slice) {
            ++$pageNumber;
            $permalink = null;
            if ($pageNumber > 1) {
                $permalink = $this->sourcePermalinkFactory->create($source)->relativeFilePath();
                $basename = basename($permalink);
                if (preg_match('/^(.+?)\.(.+)$/', $basename, $matches)) {
                    if ('index' === $matches[1]) {
                        $paginatedPage = '';
                        $index = '/index';
                    } else {
                        $paginatedPage = $matches[1].'/';
                        $index = '';
                    }
                    $permalink = dirname($permalink).'/'.$paginatedPage.'page/'.$pageNumber.$index.'.'.$matches[2];
                } else {
                    $permalink = dirname($permalink).'/'.$basename.'/page/'.$pageNumber.'.html';
                }

                if (0 === strpos($permalink, './')) {
                    $permalink = substr($permalink, 2);
                }
            }

            $generatedSource = $source->duplicate(
                $source->sourceId().':page='.$pageNumber
            );

            if (null !== $permalink) {
                $generatedSource->data()->set('permalink', $permalink);
            }

            $generatedSource->data()->set('pagination.items', $slice);
            $generatedSource->data()->set('pagination.page', $pageNumber);
            $generatedSource->data()->set('pagination.total_pages', count($slices));
            $generatedSource->data()->set('pagination.total_items', $totalItems);

            $sources[] = $generatedSource;
        }

        for ($i = 0; $i < count($sources); ++$i) {
for ($i=0; $i<count($array); $i++) { // calls count() on each iteration
}

// Better
for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once
}
            $generatedSource = $sources[$i];
            if (0 === $i) {
                $generatedSource->data()->set('pagination.previous_page', null);
            } else {
                $generatedSource->data()->set('pagination.previous_page', $sources[$i - 1]);
            }

            if ($i + 1 < count($sources)) {
                $generatedSource->data()->set('pagination.next_page', $sources[$i + 1]);
            } else {
                $generatedSource->data()->set('pagination.next_page', null);
            }
        }

        return $sources;
    }
}


1			<?php
2
3			/*
4			* This file is a part of Sculpin.
5			*
6			* (c) Dragonfly Development Inc.
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Symplify\PHP7_Sculpin\Bundle\PaginationBundle;
13
14			use Symplify\PHP7_Sculpin\Core\DataProvider\DataProviderManager;
15			use Symplify\PHP7_Sculpin\Core\Generator\GeneratorInterface;
16			use Symplify\PHP7_Sculpin\Core\Permalink\SourcePermalinkFactory;
17			use Symplify\PHP7_Sculpin\Core\Source\SourceInterface;
18
19			final class PaginationGenerator implements GeneratorInterface
20			{
21			/**
22			* @var DataProviderManager
23			*/
24			private $dataProviderManager;
25
26			/**
27			* @var int
28			*/
29			private $maxPerPage;
30
31			/**
32			* @var SourcePermalinkFactory
33			*/
34			private $sourcePermalinkFactory;
35
36			public function __construct(
37			DataProviderManager $dataProviderManager,
38			int $maxPerPage,
39			SourcePermalinkFactory $sourcePermalinkFactory
40			) {
41			$this->dataProviderManager = $dataProviderManager;
42			$this->maxPerPage = $maxPerPage;
43			$this->sourcePermalinkFactory = $sourcePermalinkFactory;
44			}
45
46			/**
47			* {@inheritdoc}
48			*/
49			public function generate(SourceInterface $source) : array
50			{
51			$data = null;
52			$config = $source->data()->get('pagination') ?: [];
53			if (!isset($config['provider'])) {
54			$config['provider'] = 'data.posts';
55			}
56			if (preg_match('/^(data\|page)\.(.+)$/', $config['provider'], $matches)) {
57			switch ($matches[1]) {
58			case 'data':
59			$data = $this->dataProviderManager->dataProvider($matches[2])->provideData();
60			break;
61			case 'page':
62			$data = $source->data()->get($matches[2]);
63			break;
64			}
65			}
66
67			if (null === $data) {
68			return [];
69			}
70
71			$maxPerPage = isset($config['max_per_page']) ? $config['max_per_page'] : $this->maxPerPage;
72
73			$slices = [];
74			$slice = [];
75			$totalItems = 0;
76			foreach ($data as $k => $v) {
77			if (count($slice) == $maxPerPage) {
78			$slices[] = $slice;
79			$slice = [];
80			}
81
82			$slice[$k] = $v;
83			++$totalItems;
84			}
85
86			if (count($slice)) {
87			$slices[] = $slice;
88			}
89
90			$sources = [];
91			$pageNumber = 0;
92			foreach ($slices as $slice) {
93			++$pageNumber;
94			$permalink = null;
95			if ($pageNumber > 1) {
96			$permalink = $this->sourcePermalinkFactory->create($source)->relativeFilePath();
97			$basename = basename($permalink);
98			if (preg_match('/^(.+?)\.(.+)$/', $basename, $matches)) {
99			if ('index' === $matches[1]) {
100			$paginatedPage = '';
101			$index = '/index';
102			} else {
103			$paginatedPage = $matches[1].'/';
104			$index = '';
105			}
106			$permalink = dirname($permalink).'/'.$paginatedPage.'page/'.$pageNumber.$index.'.'.$matches[2];
107			} else {
108			$permalink = dirname($permalink).'/'.$basename.'/page/'.$pageNumber.'.html';
109			}
110
111			if (0 === strpos($permalink, './')) {
112			$permalink = substr($permalink, 2);
113			}
114			}
115
116			$generatedSource = $source->duplicate(
117			$source->sourceId().':page='.$pageNumber
118			);
119
120			if (null !== $permalink) {
121			$generatedSource->data()->set('permalink', $permalink);
122			}
123
124			$generatedSource->data()->set('pagination.items', $slice);
125			$generatedSource->data()->set('pagination.page', $pageNumber);
126			$generatedSource->data()->set('pagination.total_pages', count($slices));
127			$generatedSource->data()->set('pagination.total_items', $totalItems);
128
129			$sources[] = $generatedSource;
130			}
131
132			for ($i = 0; $i < count($sources); ++$i) {
			0 ignored issues – show Performance Best Practice introduced 2016-09-17 18:55 UTC by Report Bug Copy Issue Report It seems like you are calling the size function `count()` as part of the test condition. You might want to compute the size beforehand, and not on each iteration. If the size of the collection does not change during the iteration, it is generally a good practice to compute it beforehand, and not on each iteration: for ($i=0; $i<count($array); $i++) { // calls count() on each iteration } // Better for ($i=0, $c=count($array); $i<$c; $i++) { // calls count() just once } Loading history...
133			$generatedSource = $sources[$i];
134			if (0 === $i) {
135			$generatedSource->data()->set('pagination.previous_page', null);
136			} else {
137			$generatedSource->data()->set('pagination.previous_page', $sources[$i - 1]);
138			}
139
140			if ($i + 1 < count($sources)) {
141			$generatedSource->data()->set('pagination.next_page', $sources[$i + 1]);
142			} else {
143			$generatedSource->data()->set('pagination.next_page', null);
144			}
145			}
146
147			return $sources;
148			}
149			}
150

Symplify / PHP7_Sculpin

Pull Request — master (#6)

PaginationGenerator::generate() F

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like