Symplify\PHP7_Sculpin\PostsBundle\Taxonomy\ProxySourceTaxonomyIndexGenerator::generate()

Complexity

Conditions	11
Paths	97

Size

Total Lines	59
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	132

Importance

Changes

0

<?php
    public function generate(SourceInterface $source) : array
    {
        $dataProvider = $this->dataProviderManager->dataProvider($this->dataProviderName);
        $taxons = $dataProvider->provideData();

        $generatedSources = [];
        foreach ($taxons as $taxon => $items) {
            $generatedSource = $source->duplicate(
                $source->sourceId().':'.$this->injectedTaxonKey.'='.$taxon
            );

            $permalink = $source->data()->get('permalink') ?: $source->relativePathname();
            $basename = basename($permalink);

            $permalink = dirname($permalink);

            $indexType = null;

            if (preg_match('/^(.+?)\.(.+)$/', $basename, $matches)) {
                $urlTaxon = $this->permalinkStrategyCollection->process($taxon);
                $indexType = $matches[2];
                $suffix = in_array($indexType, ['xml', 'rss', 'json']) ? '.'.$indexType : '/';
                $permalink = $permalink.'/'.$urlTaxon.$suffix;
            } else {

This else statement is empty and can be removed.

                // not sure what case this is?
            }

            if (0 === strpos($permalink, './')) {
                $permalink = substr($permalink, 2);
            }

            if (0 !== strpos($permalink, '/')) {
                $permalink = '/'.$permalink;
            }

            if ($permalink) {
                // not sure if this is ever going to happen?
                $generatedSource->data()->set('permalink', $permalink);
            }

            $generatedSource->data()->set($this->injectedTaxonKey, $taxon);
            $generatedSource->data()->set($this->injectedTaxonItemsKey, $items);

            if ($indexType) {

The expression $indexType of type string|null is loosely compared to true; this is ambiguous if the string can be empty. You might want to explicitly use !== null instead.

                foreach ($items as $item) {
                    $key = $this->injectedTaxonKey.'_'.$indexType.'_index_permalinks';
                    $taxonIndexPermalinks = $item->data()->get($key) ?: [];

                    $taxonIndexPermalinks[$taxon] = $permalink;

                    $item->data()->set($key, $taxonIndexPermalinks);
                }
            }

            $generatedSources[] = $generatedSource;
        }

        return $generatedSources;
    }
}