SculpinStandaloneExtension::getServicesFile() - Code Metrics - Inspection of "Nette di" - Symplify/PHP7_Sculpin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#9)

by Tomáš

created 2016-09-22 21:56 UTC

SculpinStandaloneExtension::getServicesFile() A

↳ Parent: SculpinStandaloneExtension

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	2

<?php

/*
 * This file is a part of Sculpin.
 *
 * (c) Dragonfly Development Inc.
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Symplify\PHP7_Sculpin\Bundle\StandaloneBundle;

use Nette\DI\Compiler;
use Nette\DI\CompilerExtension;
use Symplify\PHP7_Sculpin\Bundle\StandaloneBundle\DependencyInjection\Compiler\RegisterKernelListenersPass;
use Symfony\Component\DependencyInjection\Compiler\PassConfig;
use Symfony\Component\DependencyInjection\ContainerBuilder;

final class SculpinStandaloneExtension extends CompilerExtension
{
    public function loadConfiguration()
    {
        Compiler::loadDefinitions(
            $this->getContainerBuilder(),
            $this->loadFromFile(__DIR__.'/Resources/config/services.yml')

        );
    }

    public function build(ContainerBuilder $container)
    {
        $container->addCompilerPass(new RegisterKernelListenersPass(), PassConfig::TYPE_AFTER_REMOVING);
    }

    protected function getServicesFile() : string
    {
        return __DIR__.'/Resources/config/services.yml';
    }
}


1			<?php
2
3			/*
4			* This file is a part of Sculpin.
5			*
6			* (c) Dragonfly Development Inc.
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Symplify\PHP7_Sculpin\Bundle\StandaloneBundle;
13
14			use Nette\DI\Compiler;
15			use Nette\DI\CompilerExtension;
16			use Symplify\PHP7_Sculpin\Bundle\StandaloneBundle\DependencyInjection\Compiler\RegisterKernelListenersPass;
17			use Symfony\Component\DependencyInjection\Compiler\PassConfig;
18			use Symfony\Component\DependencyInjection\ContainerBuilder;
19
20			final class SculpinStandaloneExtension extends CompilerExtension
21			{
22			public function loadConfiguration()
23			{
24			Compiler::loadDefinitions(
25			$this->getContainerBuilder(),
26			$this->loadFromFile(__DIR__.'/Resources/config/services.yml')
			0 ignored issues – show Bug introduced 2016-09-22 22:02 UTC by Report Bug Copy Issue Report It seems like `$this->loadFromFile(__DI...s/config/services.yml')` targeting `Nette\DI\CompilerExtension::loadFromFile()` can also be of type `string`; however, `Nette\DI\Compiler::loadDefinitions()` does only seem to accept `array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
27			);
28			}
29
30			public function build(ContainerBuilder $container)
31			{
32			$container->addCompilerPass(new RegisterKernelListenersPass(), PassConfig::TYPE_AFTER_REMOVING);
33			}
34
35			protected function getServicesFile() : string
36			{
37			return __DIR__.'/Resources/config/services.yml';
38			}
39			}
40

Symplify / PHP7_Sculpin

Pull Request — master (#9)

SculpinStandaloneExtension::getServicesFile() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like