Completed
Pull Request — master (#9)
by Tomáš
06:29
created

SculpinPaginationExtension::loadConfiguration()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 7
Code Lines 4

Duplication

Lines 0
Ratio 0 %

Code Coverage

Tests 0
CRAP Score 2

Importance

Changes 0
Metric Value
dl 0
loc 7
ccs 0
cts 7
cp 0
rs 9.4285
c 0
b 0
f 0
cc 1
eloc 4
nc 1
nop 0
crap 2
1
<?php
2
3
/*
4
 * This file is a part of Sculpin.
5
 *
6
 * (c) Dragonfly Development Inc.
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace Symplify\PHP7_Sculpin\Bundle\PaginationBundle;
13
14
use Nette\DI\Compiler;
15
use Nette\DI\CompilerExtension;
16
use Symplify\PHP7_Sculpin\Bundle\PaginationBundle\DependencyInjection\Configuration;
17
use Symfony\Component\Config\Definition\ConfigurationInterface;
18
19
final class SculpinPaginationExtension extends CompilerExtension
20
{
21
    public function loadConfiguration()
22
    {
23
        Compiler::loadDefinitions(
24
            $this->getContainerBuilder(),
25
            $this->loadFromFile(__DIR__.'/Resources/config/services.yml')
0 ignored issues
show
Bug introduced by
It seems like $this->loadFromFile(__DI...s/config/services.yml') targeting Nette\DI\CompilerExtension::loadFromFile() can also be of type string; however, Nette\DI\Compiler::loadDefinitions() does only seem to accept array, maybe add an additional type check?

This check looks at variables that are passed out again to other methods.

If the outgoing method call has stricter type requirements than the method itself, an issue is raised.

An additional type check may prevent trouble.

Loading history...
26
        );
27
    }
28
29
    // todo: set configuration parameter alias
30
31
//    public function getConfiguration() : ConfigurationInterface
0 ignored issues
show
Unused Code Comprehensibility introduced by
45% of this comment could be valid code. Did you maybe forget this after debugging?

Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it.

The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production.

This check looks for comments that seem to be mostly valid code and reports them.

Loading history...
32
//    {
33
//        return new Configuration();
34
//    }
35
//
36
//    protected function getParametersAliases() : array
37
//    {
38
//        return [
39
//            'max_per_page' => 'sculpin_pagination.max_per_page',
40
//        ];
41
//    }
42
}
43