Symplify\PHP7_CodeSniffer\File\SourceFilesProvider

Complexity

Total Complexity

5

Size/Duplication

Total Lines	60
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	9	1
A	getFiles()	0	11	2
A	wrapFilesToValueObjects()	0	8	2

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\PHP7_CodeSniffer\File;

use SplFileInfo;
use Symplify\PHP7_CodeSniffer\Configuration\Configuration;
use Symplify\PHP7_CodeSniffer\Finder\SourceFinder;
use Symplify\PHP7_CodeSniffer\Ruleset;

final class SourceFilesProvider
{
    /**
     * @var File[]
     */
    private $files;

    /**
     * @var SourceFinder
     */
    private $sourceFinder;

    /**
     * @var FileFactory
     */
    private $fileFactory;

    /**
     * @var Configuration
     */
    private $configuration;

    public function __construct(
        SourceFinder $sourceFinder,
        FileFactory $fileFactory,
        Configuration $configuration
    ) {
        $this->sourceFinder = $sourceFinder;
        $this->fileFactory = $fileFactory;
        $this->configuration = $configuration;
    }

    /**
     * @return File[]
     */
    public function getFiles() : array
    {
        if ($this->files) {

The expression $this->files of type Symplify\PHP7_CodeSniffer\File\File[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->files;
        }

        $files = $this->sourceFinder->find($this->configuration->getSource());
        $this->files = $this->wrapFilesToValueObjects($files);

        return $this->files;
    }

    /**
     * @param SplFileInfo[] $files
     * @return File[]
     */
    private function wrapFilesToValueObjects(array $files) : array
    {
        foreach ($files as $name => $fileInfo) {
            $files[$name] = $this->fileFactory->create($name);
        }

        return $files;
    }
}