Inspection of "Changelog for PR #1032" - Symplify/PHP7_CodeSniffer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (d87ed9)

by Tomáš

created 2016-06-24 23:04 UTC

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -66,7 +66,7 @@  discard block
 block discarded – undo
                 40 => 2,
                 41 => 2,
                 42 => 1,
-               );
+                );
 
     }//end getErrorList()
 
@@ -86,7 +86,7 @@  discard block
 block discarded – undo
                 30 => 1,
                 34 => 1,
                 42 => 1,
-               );
+                );
 
     }//end getWarningList()
 

Please login to merge, or discard this patch.

CodeSniffer/Standards/PEAR/Tests/Commenting/FunctionCommentUnitTest.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -71,7 +71,7 @@
		block discarded – undo
71	71	272 => 1,
72	72	313 => 1,
73	73	317 => 1,
74		- );
	74	+ );
75	75
76	76	}//end getErrorList()
77	77

Please login to merge, or discard this patch.

CodeSniffer/Standards/PEAR/Tests/Commenting/FunctionCommentUnitTest.inc 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -14,7 +14,7 @@
 block discarded – undo
      * @return
      * @throws
      */
-    private function _functionCall($stackPtr, $depth=1, $index)
+    private function _functionCall($stackPtr, $depth = 1, $index)
     {
         return $stackPtr;
 

Please login to merge, or discard this patch.

CodeSniffer/Standards/PEAR/Tests/Commenting/InlineCommentUnitTest.php 1 patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

		@@ -49,7 +49,7 @@
		block discarded – undo
49	49	27 => 1,
50	50	28 => 1,
51	51	29 => 1,
52		- );
	52	+ );
53	53
54	54	}//end getErrorList()
55	55

Please login to merge, or discard this patch.

CodeSniffer/Standards/PEAR/Tests/Commenting/ClassCommentUnitTest.php 1 patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -57,7 +57,7 @@  discard block
 block discarded – undo
                 85  => 1,
                 96  => 5,
                 106 => 5,
-               );
+                );
 
     }//end getErrorList()
 
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
         return array(
                 71 => 1,
                 73 => 1,
-               );
+                );
 
     }//end getWarningList()
 

Please login to merge, or discard this patch.

CodeSniffer/Standards/Generic/Sniffs/Classes/DuplicateClassNameSniff.php 1 patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

@@ -61,11 +61,11 @@  discard block
 block discarded – undo
 
         $namespace  = '';
         $findTokens = array(
-                       T_CLASS,
-                       T_INTERFACE,
-                       T_NAMESPACE,
-                       T_CLOSE_TAG,
-                      );
+                        T_CLASS,
+                        T_INTERFACE,
+                        T_NAMESPACE,
+                        T_CLOSE_TAG,
+                        );
 
         $stackPtr = $phpcsFile->findNext($findTokens, ($stackPtr + 1));
         while ($stackPtr !== false) {
@@ -79,9 +79,9 @@  discard block
 block discarded – undo
             if ($tokens[$stackPtr]['code'] === T_NAMESPACE) {
                 $nsEnd = $phpcsFile->findNext(
                     array(
-                     T_NS_SEPARATOR,
-                     T_STRING,
-                     T_WHITESPACE,
+                        T_NS_SEPARATOR,
+                        T_STRING,
+                        T_WHITESPACE,
                     ),
                     ($stackPtr + 1),
                     null,
@@ -104,16 +104,16 @@  discard block
 block discarded – undo
                     $line  = $this->foundClasses[$compareName]['line'];
                     $error = 'Duplicate %s name "%s" found; first defined in %s on line %s';
                     $data  = array(
-                              $type,
-                              $name,
-                              $file,
-                              $line,
-                             );
+                                $type,
+                                $name,
+                                $file,
+                                $line,
+                                );
                     $phpcsFile->addWarning($error, $stackPtr, 'Found', $data);
                 } else {
                     $this->foundClasses[$compareName] = array(
-                                                         'file' => $phpcsFile->getFilename(),
-                                                         'line' => $tokens[$stackPtr]['line'],
+                                                            'file' => $phpcsFile->getFilename(),
+                                                            'line' => $tokens[$stackPtr]['line'],
                                                         );
                 }
             }//end if

Please login to merge, or discard this patch.

Standards/Generic/Sniffs/ControlStructures/InlineControlStructureSniff.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -36,9 +36,9 @@  discard block
 block discarded – undo
      * @var array
      */
     public $supportedTokenizers = array(
-                                   'PHP',
-                                   'JS',
-                                  );
+                                    'PHP',
+                                    'JS',
+                                    );
 
     /**
      * If true, an error will be thrown; otherwise a warning.
@@ -64,7 +64,7 @@  discard block
 block discarded – undo
                 T_DO,
                 T_SWITCH,
                 T_FOR,
-               );
+                );
 
     }//end register()
 

Please login to merge, or discard this patch.

Standards/Generic/Sniffs/Strings/UnnecessaryStringConcatSniff.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -35,9 +35,9 @@  discard block
 block discarded – undo
      * @var array
      */
     public $supportedTokenizers = array(
-                                   'PHP',
-                                   'JS',
-                                  );
+                                    'PHP',
+                                    'JS',
+                                    );
 
     /**
      * If true, an error will be thrown; otherwise a warning.
@@ -67,7 +67,7 @@  discard block
 block discarded – undo
         return array(
                 T_STRING_CONCAT,
                 T_PLUS,
-               );
+                );
 
     }//end register()
 

Please login to merge, or discard this patch.

CodeSniffer/Standards/Generic/Sniffs/Files/EndFileNoNewlineSniff.php 1 patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -34,10 +34,10 @@
 block discarded – undo
      * @var array
      */
     public $supportedTokenizers = array(
-                                   'PHP',
-                                   'JS',
-                                   'CSS',
-                                  );
+                                    'PHP',
+                                    'JS',
+                                    'CSS',
+                                    );
 
 
     /**

Please login to merge, or discard this patch.

		@@ -66,7 +66,7 @@ discard block
		block discarded – undo
66	66	40 => 2,
67	67	41 => 2,
68	68	42 => 1,
69		- );
	69	+ );
70	70
71	71	}//end getErrorList()
72	72
		@@ -86,7 +86,7 @@ discard block
		block discarded – undo
86	86	30 => 1,
87	87	34 => 1,
88	88	42 => 1,
89		- );
	89	+ );
90	90
91	91	}//end getWarningList()
92	92

		@@ -14,7 +14,7 @@
		block discarded – undo
14	14	* @return
15	15	* @throws
16	16	*/
17		- private function _functionCall($stackPtr, $depth=1, $index)
	17	+ private function _functionCall($stackPtr, $depth = 1, $index)
18	18	{
19	19	return $stackPtr;
20	20

		@@ -57,7 +57,7 @@ discard block
		block discarded – undo
57	57	85 => 1,
58	58	96 => 5,
59	59	106 => 5,
60		- );
	60	+ );
61	61
62	62	}//end getErrorList()
63	63
		@@ -75,7 +75,7 @@ discard block
		block discarded – undo
75	75	return array(
76	76	71 => 1,
77	77	73 => 1,
78		- );
	78	+ );
79	79
80	80	}//end getWarningList()
81	81

		@@ -61,11 +61,11 @@ discard block
		block discarded – undo
61	61
62	62	$namespace = '';
63	63	$findTokens = array(
64		- T_CLASS,
65		- T_INTERFACE,
66		- T_NAMESPACE,
67		- T_CLOSE_TAG,
68		- );
	64	+ T_CLASS,
	65	+ T_INTERFACE,
	66	+ T_NAMESPACE,
	67	+ T_CLOSE_TAG,
	68	+ );
69	69
70	70	$stackPtr = $phpcsFile->findNext($findTokens, ($stackPtr + 1));
71	71	while ($stackPtr !== false) {
		@@ -79,9 +79,9 @@ discard block
		block discarded – undo
79	79	if ($tokens[$stackPtr]['code'] === T_NAMESPACE) {
80	80	$nsEnd = $phpcsFile->findNext(
81	81	array(
82		- T_NS_SEPARATOR,
83		- T_STRING,
84		- T_WHITESPACE,
	82	+ T_NS_SEPARATOR,
	83	+ T_STRING,
	84	+ T_WHITESPACE,
85	85	),
86	86	($stackPtr + 1),
87	87	null,
		@@ -104,16 +104,16 @@ discard block
		block discarded – undo
104	104	$line = $this->foundClasses[$compareName]['line'];
105	105	$error = 'Duplicate %s name "%s" found; first defined in %s on line %s';
106	106	$data = array(
107		- $type,
108		- $name,
109		- $file,
110		- $line,
111		- );
	107	+ $type,
	108	+ $name,
	109	+ $file,
	110	+ $line,
	111	+ );
112	112	$phpcsFile->addWarning($error, $stackPtr, 'Found', $data);
113	113	} else {
114	114	$this->foundClasses[$compareName] = array(
115		- 'file' => $phpcsFile->getFilename(),
116		- 'line' => $tokens[$stackPtr]['line'],
	115	+ 'file' => $phpcsFile->getFilename(),
	116	+ 'line' => $tokens[$stackPtr]['line'],
117	117	);
118	118	}
119	119	}//end if

		@@ -36,9 +36,9 @@ discard block
		block discarded – undo
36	36	* @var array
37	37	*/
38	38	public $supportedTokenizers = array(
39		- 'PHP',
40		- 'JS',
41		- );
	39	+ 'PHP',
	40	+ 'JS',
	41	+ );
42	42
43	43	/**
44	44	* If true, an error will be thrown; otherwise a warning.
		@@ -64,7 +64,7 @@ discard block
		block discarded – undo
64	64	T_DO,
65	65	T_SWITCH,
66	66	T_FOR,
67		- );
	67	+ );
68	68
69	69	}//end register()
70	70

		@@ -35,9 +35,9 @@ discard block
		block discarded – undo
35	35	* @var array
36	36	*/
37	37	public $supportedTokenizers = array(
38		- 'PHP',
39		- 'JS',
40		- );
	38	+ 'PHP',
	39	+ 'JS',
	40	+ );
41	41
42	42	/**
43	43	* If true, an error will be thrown; otherwise a warning.
		@@ -67,7 +67,7 @@ discard block
		block discarded – undo
67	67	return array(
68	68	T_STRING_CONCAT,
69	69	T_PLUS,
70		- );
	70	+ );
71	71
72	72	}//end register()
73	73

		@@ -34,10 +34,10 @@
		block discarded – undo
34	34	* @var array
35	35	*/
36	36	public $supportedTokenizers = array(
37		- 'PHP',
38		- 'JS',
39		- 'CSS',
40		- );
	37	+ 'PHP',
	38	+ 'JS',
	39	+ 'CSS',
	40	+ );
41	41
42	42
43	43	/**

Symplify / PHP7_CodeSniffer

Branch — master (d87ed9)

Category

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +1 added lines, -1 removed lines patch added patch discarded remove patch

Indentation +2 added lines, -2 removed lines patch added patch discarded remove patch

Indentation +15 added lines, -15 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch