StandardFinder::getStandards() - Code Metrics - Inspection of "Merge pull request #2 from Symplify/exclude-option" - Symplify/PHP7_CodeSniffer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (aa8164)

by Tomáš

created 2016-08-03 18:14 UTC

StandardFinder::getStandards() A

↳ Parent: StandardFinder

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	15
ccs	8
cts	8
cp	1
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	8
nc	3
nop	0
crap	3

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\PHP7_CodeSniffer\Standard;

use Exception;
use Symfony\Component\Finder\Finder;
use Symplify\PHP7_CodeSniffer\Composer\VendorDirProvider;

final class StandardFinder
{
    /**
     * @var string[]
     */
    private $rulesets = [];

    /**
     * @param string[] $names
     * @return string[]
     */
    public function getRulesetPathsForStandardNames(array $names) : array
    {
        $rulesetPaths = [];
        foreach ($names as $name) {
            $rulesetPaths[$name] = $this->getRulesetPathForStandardName($name);
        }

        return $rulesetPaths;
    }

    public function getRulesetPathForStandardName(string $standardName) : string
    {
        if (isset($this->getStandards()[$standardName])) {
            return $this->getStandards()[$standardName];
        }

        throw new Exception(
            sprintf(
                'Ruleset for standard "%s" was not found. Found standards are: %s.',
                $standardName,
                implode($this->getRulesetNames(), ', ')
            )
        );
    }

    /**
     * @return string[]
     */
    public function getStandards() : array
    {
        if ($this->rulesets) {

            return $this->rulesets;
        }

        foreach ($this->findRulesetFiles() as $rulesetFile) {
            $rulesetXml = simplexml_load_file($rulesetFile);

            $rulesetName = (string) $rulesetXml['name'];
            $this->rulesets[$rulesetName] = $rulesetFile;
        }

        return $this->rulesets;
    }

    /**
     * @return string[]
     */
    private function findRulesetFiles() : array
    {
        $installedStandards = (new Finder())->files()
            ->in(VendorDirProvider::provide())
            ->name('ruleset.xml');

        return array_keys(iterator_to_array($installedStandards));
    }

    private function getRulesetNames() : array
    {
        return array_keys($this->getStandards());
    }
}


1		<?php
2
3		/*
4		* This file is part of Symplify
5		* Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
6		*/
7
8		namespace Symplify\PHP7_CodeSniffer\Standard;
9
10		use Exception;
11		use Symfony\Component\Finder\Finder;
12		use Symplify\PHP7_CodeSniffer\Composer\VendorDirProvider;
13
14		final class StandardFinder
15		{
16		/**
17		* @var string[]
18		*/
19		private $rulesets = [];
20
21		/**
22		* @param string[] $names
23		* @return string[]
24		*/
25	1	public function getRulesetPathsForStandardNames(array $names) : array
26		{
27	1	$rulesetPaths = [];
28	1	foreach ($names as $name) {
29	1	$rulesetPaths[$name] = $this->getRulesetPathForStandardName($name);
30		}
31
32	1	return $rulesetPaths;
33		}
34
35	3	public function getRulesetPathForStandardName(string $standardName) : string
36		{
37	3	if (isset($this->getStandards()[$standardName])) {
38	3	return $this->getStandards()[$standardName];
39		}
40
41		throw new Exception(
42		sprintf(
43		'Ruleset for standard "%s" was not found. Found standards are: %s.',
44		$standardName,
45		implode($this->getRulesetNames(), ', ')
46		)
47		);
48		}
49
50		/**
51		* @return string[]
52		*/
53	5	public function getStandards() : array
54		{
55	5	if ($this->rulesets) {
		0 ignored issues – show Bug Best Practice introduced 2016-07-15 16:34 UTC by Report Bug Copy Issue Report The expression `$this->rulesets` of type `string[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
56	4	return $this->rulesets;
57		}
58
59	5	foreach ($this->findRulesetFiles() as $rulesetFile) {
60	5	$rulesetXml = simplexml_load_file($rulesetFile);
61
62	5	$rulesetName = (string) $rulesetXml['name'];
63	5	$this->rulesets[$rulesetName] = $rulesetFile;
64		}
65
66	5	return $this->rulesets;
67		}
68
69		/**
70		* @return string[]
71		*/
72	5	private function findRulesetFiles() : array
73		{
74	5	$installedStandards = (new Finder())->files()
75	5	->in(VendorDirProvider::provide())
76	5	->name('ruleset.xml');
77
78	5	return array_keys(iterator_to_array($installedStandards));
79		}
80
81		private function getRulesetNames() : array
82		{
83		return array_keys($this->getStandards());
84		}
85		}
86

Symplify / PHP7_CodeSniffer

Branch — master (aa8164)

StandardFinder::getStandards() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like