Symplify / PHP7_CodeSniffer

src/Standards/PSR1/Sniffs/Files/SideEffectsSniff.php

Doc Comments +4 added lines, -4 removed lines

@@ -20,7 +20,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {
@@ -32,11 +32,11 @@ 
     /**
      * Processes this sniff, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token in
      *                                        the token stack.
      *
-     * @return void
+     * @return integer
      */
     public function process(File $phpcsFile, $stackPtr)
     {
@@ -68,7 +68,7 @@ 
      * side effect in the file. A NULL value for either indicates nothing was
      * found.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $start     The token to start searching from.
      * @param int                  $end       The token to search to.
      * @param array                $tokens    The stack of tokens that make up

Indentation +9 added lines, -9 removed lines

@@ -59,9 +59,9 @@ 
         if ($result['symbol'] !== null && $result['effect'] !== null) {
             $error = 'A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line %s and the first side effect is on line %s.';
             $data  = array(
-                      $tokens[$result['symbol']]['line'],
-                      $tokens[$result['effect']]['line'],
-                     );
+                        $tokens[$result['symbol']]['line'],
+                        $tokens[$result['effect']]['line'],
+                        );
             $phpcsFile->addWarning($error, 0, 'FoundWithSymbols', $data);
             $phpcsFile->recordMetric($stackPtr, 'Declarations and side effects mixed', 'yes');
         } else {
@@ -96,13 +96,13 @@ 
                     T_INTERFACE => T_INTERFACE,
                     T_TRAIT     => T_TRAIT,
                     T_FUNCTION  => T_FUNCTION,
-                   );
+                    );
 
         $conditions = array(
-                       T_IF     => T_IF,
-                       T_ELSE   => T_ELSE,
-                       T_ELSEIF => T_ELSEIF,
-                      );
+                        T_IF     => T_IF,
+                        T_ELSE   => T_ELSE,
+                        T_ELSEIF => T_ELSEIF,
+                        );
 
         $firstSymbol = null;
         $firstEffect = null;
@@ -230,7 +230,7 @@ 
         return array(
                 'symbol' => $firstSymbol,
                 'effect' => $firstEffect,
-               );
+                );
 
     }//end _searchForConflict()
 

src/Standards/PSR2/Sniffs/ControlStructures/SwitchDeclarationSniff.php

Doc Comments +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {
@@ -39,7 +39,7 @@ 
     /**
      * Processes this test, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token in the
      *                                        stack passed in $tokens.
      *
@@ -209,7 +209,7 @@ 
      *
      * Note that nested switches are ignored.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position to start looking at.
      * @param int                  $end       The position to stop looking at.
      *

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 use PHP_CodeSniffer\Sniffs\Sniff;
 use PHP_CodeSniffer\Files\File;
-use PHP_CodeSniffer\Util\Tokens;
 
 class SwitchDeclarationSniff implements Sniff
 {

Indentation +2 added lines, -2 removed lines

@@ -87,8 +87,8 @@
                 $expected = strtolower($tokens[$nextCase]['content']);
                 $error    = strtoupper($type).' keyword must be lowercase; expected "%s" but found "%s"';
                 $data     = array(
-                             $expected,
-                             $tokens[$nextCase]['content'],
+                                $expected,
+                                $tokens[$nextCase]['content'],
                             );
 
                 $fix = $phpcsFile->addFixableError($error, $nextCase, $type.'NotLower', $data);

src/Standards/PSR2/Sniffs/Files/EndFileNewlineSniff.php

Doc Comments +3 added lines, -3 removed lines

@@ -19,7 +19,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {
@@ -31,11 +31,11 @@ 
     /**
      * Processes this sniff, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token in
      *                                        the stack passed in $tokens.
      *
-     * @return void
+     * @return integer
      */
     public function process(File $phpcsFile, $stackPtr)
     {

src/Standards/PSR2/Sniffs/Namespaces/UseDeclarationSniff.php

Doc Comments +4 added lines, -4 removed lines

@@ -19,7 +19,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {
@@ -31,7 +31,7 @@ 
     /**
      * Processes this test, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token in
      *                                        the stack passed in $tokens.
      *
@@ -128,11 +128,11 @@ 
     /**
      * Check if this use statement is part of the namespace block.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token in
      *                                        the stack passed in $tokens.
      *
-     * @return void
+     * @return boolean
      */
     private function shouldIgnoreUse($phpcsFile, $stackPtr)
     {

src/Standards/PSR2/Tests/ControlStructures/SwitchDeclarationUnitTest.inc

Unused Use Statements -2 removed lines

@@ -89,8 +89,6 @@
         }
 }
 
-use Vendor\Test\FooBar;
-
 function test()
 {
     switch ($val) {

Switch Indentation +14 added lines, -14 removed lines

@@ -34,10 +34,10 @@ 
 }
 
 switch ($foo) {
-    case'Foo': {
-        echo 'foo';
-        break;
-        }
+        case'Foo': {
+            echo 'foo';
+            break;
+            }
 }
 
 while ($i < 10) {
@@ -52,10 +52,10 @@ 
 }
 
 switch (true) {
-    case is_resource($value):
-        throw new Exception('foo');
-    case is_object($value):
-        return 'object';
+        case is_resource($value):
+            throw new Exception('foo');
+        case is_object($value):
+            return 'object';
 }
 
 switch (0) {
@@ -105,13 +105,13 @@ 
 }
 
 switch ($foo) {
-    case 1: $bar = 1; break;
-    case 2:
+        case 1: $bar = 1; break;
+        case 2:
     
-        $bar = 2; break;
-    case 21:
-    case 3: return 3;
-    default: $bar = 0;
+            $bar = 2; break;
+        case 21:
+        case 3: return 3;
+        default: $bar = 0;
 }
 
 switch ($foo) {

Spacing +1 added lines, -1 removed lines

@@ -135,7 +135,7 @@
         break;
 }
 
-switch($foo)
+switch ($foo)
 {
     case ('foo'):
     default:

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.1.inc

Unused Use Statements -8 removed lines

@@ -1,15 +1,7 @@
 <?php
 namespace MyProject;
 
-use BarClass as Bar;
-use My\Full\Classname as Another;
-
-
-use Something;
-use SomethingElse;
-
 // Comment here.
-use LastThing;
 
 class Foo {
 }

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
 }
 
 $var = new MyClass(
-    function () use ($foo, $bar) {
+    function() use ($foo, $bar) {
         return true;
     }
 );

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.2.inc

Unused Use Statements -5 removed lines

@@ -1,14 +1,9 @@
 <?php
 namespace MyProject;
 
-use  BarClass as Bar;
-use My\Full\Classname as Another, My\Full\NSname;
-
 
 namespace AnotherProject;
 
-use ArrayObject;
-
 
 $foo = 'bar';
 

src/Standards/PSR2/Tests/Namespaces/UseDeclarationUnitTest.3.inc

Unused Use Statements -3 removed lines

@@ -1,9 +1,6 @@
 <?php
 namespace bug;
 
-use
-    someNS\A;
-use someNS\B;
 class Bug
 {
     public function __construct()

Spacing +1 added lines, -1 removed lines

@@ -9,7 +9,7 @@
     public function __construct()
     {
         $b = 1;
-        $a = function () use ($b) {
+        $a = function() use ($b) {
             echo $b;
         };
     }

src/Standards/Squiz/Sniffs/Arrays/ArrayBracketSpacingSniff.php

Doc Comments +2 added lines, -2 removed lines

@@ -20,7 +20,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return string[]
      */
     public function register()
     {
@@ -35,7 +35,7 @@ 
     /**
      * Processes this sniff, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The current file being checked.
+     * @param File $phpcsFile The current file being checked.
      * @param int                  $stackPtr  The position of the current token in the
      *                                        stack passed in $tokens.
      *

Indentation +5 added lines, -5 removed lines

@@ -41,7 +41,7 @@ 
         return array(
                 T_OPEN_SQUARE_BRACKET,
                 T_CLOSE_SQUARE_BRACKET,
-               );
+                );
 
     }//end register()
 
@@ -85,8 +85,8 @@ 
             $found    = $phpcsFile->getTokensAsString($nonSpace, ($stackPtr - $nonSpace)).$tokens[$stackPtr]['content'];
             $error    = 'Space found before square bracket; expected "%s" but found "%s"';
             $data     = array(
-                         $expected,
-                         $found,
+                            $expected,
+                            $found,
                         );
             $fix      = $phpcsFile->addFixableError($error, $stackPtr, 'SpaceBeforeBracket', $data);
             if ($fix === true) {
@@ -103,8 +103,8 @@ 
                 $found    = $phpcsFile->getTokensAsString($stackPtr, ($nonSpace - $stackPtr + 1));
                 $error    = 'Space found after square bracket; expected "%s" but found "%s"';
                 $data     = array(
-                             $expected,
-                             $found,
+                                $expected,
+                                $found,
                             );
                 $fix      = $phpcsFile->addFixableError($error, $stackPtr, 'SpaceAfterBracket', $data);
                 if ($fix === true) {

Spacing +2 added lines, -2 removed lines

@@ -88,7 +88,7 @@ 
                          $expected,
                          $found,
                         );
-            $fix      = $phpcsFile->addFixableError($error, $stackPtr, 'SpaceBeforeBracket', $data);
+            $fix = $phpcsFile->addFixableError($error, $stackPtr, 'SpaceBeforeBracket', $data);
             if ($fix === true) {
                 $phpcsFile->fixer->replaceToken(($stackPtr - 1), '');
             }
@@ -106,7 +106,7 @@ 
                              $expected,
                              $found,
                             );
-                $fix      = $phpcsFile->addFixableError($error, $stackPtr, 'SpaceAfterBracket', $data);
+                $fix = $phpcsFile->addFixableError($error, $stackPtr, 'SpaceAfterBracket', $data);
                 if ($fix === true) {
                     $phpcsFile->fixer->replaceToken(($stackPtr + 1), '');
                 }