Symplify / PHP7_CodeSniffer

src/Standards/PEAR/Sniffs/Functions/ValidDefaultValueSniff.php

Doc Comments +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return int[]
+     * @return integer[]
      */
     public function register()
     {
@@ -32,7 +32,7 @@ 
     /**
      * Processes this test, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token in the
      *                                        stack passed in $tokens.
      *
@@ -73,7 +73,7 @@ 
     /**
      * Returns true if the passed argument has a default value.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $argPtr    The position of the argument
      *                                        in the stack.
      *

src/Standards/PEAR/Sniffs/NamingConventions/ValidClassNameSniff.php

Doc Comments +2 added lines, -2 removed lines

@@ -19,7 +19,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {
@@ -34,7 +34,7 @@ 
     /**
      * Processes this test, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The current file being processed.
+     * @param File $phpcsFile The current file being processed.
      * @param int                  $stackPtr  The position of the current token
      *                                        in the stack passed in $tokens.
      *

Indentation +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
                 48 => 1,
                 70 => 1,
                 71 => 1,
-               );
+                );
 
     }//end getErrorList()
 

src/Standards/PEAR/Sniffs/NamingConventions/ValidFunctionNameSniff.php

Doc Comments +2 added lines, -2 removed lines

@@ -60,7 +60,7 @@ 
     /**
      * Processes the tokens within the scope.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being processed.
+     * @param File $phpcsFile The file being processed.
      * @param int                  $stackPtr  The position where this token was
      *                                        found.
      * @param int                  $currScope The position of the current scope.
@@ -164,7 +164,7 @@ 
     /**
      * Processes the tokens outside the scope.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being processed.
+     * @param File $phpcsFile The file being processed.
      * @param int                  $stackPtr  The position where this token was
      *                                        found.
      *

Indentation +26 added lines, -26 removed lines

@@ -41,22 +41,22 @@ 
      * @var array
      */
     protected $magicMethods = array(
-                               'construct'  => true,
-                               'destruct'   => true,
-                               'call'       => true,
-                               'callstatic' => true,
-                               'get'        => true,
-                               'set'        => true,
-                               'isset'      => true,
-                               'unset'      => true,
-                               'sleep'      => true,
-                               'wakeup'     => true,
-                               'tostring'   => true,
-                               'set_state'  => true,
-                               'clone'      => true,
-                               'invoke'     => true,
-                               'debuginfo'  => true,
-                              );
+                                'construct'  => true,
+                                'destruct'   => true,
+                                'call'       => true,
+                                'callstatic' => true,
+                                'get'        => true,
+                                'set'        => true,
+                                'isset'      => true,
+                                'unset'      => true,
+                                'sleep'      => true,
+                                'wakeup'     => true,
+                                'tostring'   => true,
+                                'set_state'  => true,
+                                'clone'      => true,
+                                'invoke'     => true,
+                                'debuginfo'  => true,
+                                );
 
     /**
      * A list of all PHP magic functions.
@@ -101,8 +101,8 @@ 
         if (preg_match('|^__|', $methodName) !== 0) {
             $magicPart = strtolower(substr($methodName, 2));
             if (isset($this->magicMethods[$magicPart]) === false) {
-                 $error = 'Method name "%s" is invalid; only PHP magic methods should be prefixed with a double underscore';
-                 $phpcsFile->addError($error, $stackPtr, 'MethodDoubleUnderscore', $errorData);
+                    $error = 'Method name "%s" is invalid; only PHP magic methods should be prefixed with a double underscore';
+                    $phpcsFile->addError($error, $stackPtr, 'MethodDoubleUnderscore', $errorData);
             }
 
             return;
@@ -144,9 +144,9 @@ 
         if ($isPublic === true && $scopeSpecified === true && $methodName{0} === '_') {
             $error = '%s method name "%s" must not be prefixed with an underscore';
             $data  = array(
-                      ucfirst($scope),
-                      $errorData[0],
-                     );
+                        ucfirst($scope),
+                        $errorData[0],
+                        );
             $phpcsFile->addError($error, $stackPtr, 'PublicUnderscore', $data);
             return;
         }
@@ -165,9 +165,9 @@ 
             if ($scopeSpecified === true) {
                 $error = '%s method name "%s" is not in camel caps format';
                 $data  = array(
-                          ucfirst($scope),
-                          $errorData[0],
-                         );
+                            ucfirst($scope),
+                            $errorData[0],
+                            );
                 $phpcsFile->addError($error, $stackPtr, 'ScopeNotCamelCaps', $data);
             } else {
                 $error = 'Method name "%s" is not in camel caps format';
@@ -208,8 +208,8 @@ 
         if (preg_match('|^__|', $functionName) !== 0) {
             $magicPart = strtolower(substr($functionName, 2));
             if (isset($this->magicFunctions[$magicPart]) === false) {
-                 $error = 'Function name "%s" is invalid; only PHP magic methods should be prefixed with a double underscore';
-                 $phpcsFile->addError($error, $stackPtr, 'FunctionDoubleUnderscore', $errorData);
+                    $error = 'Function name "%s" is invalid; only PHP magic methods should be prefixed with a double underscore';
+                    $phpcsFile->addError($error, $stackPtr, 'FunctionDoubleUnderscore', $errorData);
             }
 
             return;

src/Standards/PSR1/Sniffs/Files/SideEffectsSniff.php

Doc Comments +4 added lines, -4 removed lines

@@ -20,7 +20,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {
@@ -32,11 +32,11 @@ 
     /**
      * Processes this sniff, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token in
      *                                        the token stack.
      *
-     * @return void
+     * @return integer
      */
     public function process(File $phpcsFile, $stackPtr)
     {
@@ -68,7 +68,7 @@ 
      * side effect in the file. A NULL value for either indicates nothing was
      * found.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $start     The token to start searching from.
      * @param int                  $end       The token to search to.
      * @param array                $tokens    The stack of tokens that make up

Indentation +9 added lines, -9 removed lines

@@ -59,9 +59,9 @@ 
         if ($result['symbol'] !== null && $result['effect'] !== null) {
             $error = 'A file should declare new symbols (classes, functions, constants, etc.) and cause no other side effects, or it should execute logic with side effects, but should not do both. The first symbol is defined on line %s and the first side effect is on line %s.';
             $data  = array(
-                      $tokens[$result['symbol']]['line'],
-                      $tokens[$result['effect']]['line'],
-                     );
+                        $tokens[$result['symbol']]['line'],
+                        $tokens[$result['effect']]['line'],
+                        );
             $phpcsFile->addWarning($error, 0, 'FoundWithSymbols', $data);
             $phpcsFile->recordMetric($stackPtr, 'Declarations and side effects mixed', 'yes');
         } else {
@@ -96,13 +96,13 @@ 
                     T_INTERFACE => T_INTERFACE,
                     T_TRAIT     => T_TRAIT,
                     T_FUNCTION  => T_FUNCTION,
-                   );
+                    );
 
         $conditions = array(
-                       T_IF     => T_IF,
-                       T_ELSE   => T_ELSE,
-                       T_ELSEIF => T_ELSEIF,
-                      );
+                        T_IF     => T_IF,
+                        T_ELSE   => T_ELSE,
+                        T_ELSEIF => T_ELSEIF,
+                        );
 
         $firstSymbol = null;
         $firstEffect = null;
@@ -230,7 +230,7 @@ 
         return array(
                 'symbol' => $firstSymbol,
                 'effect' => $firstEffect,
-               );
+                );
 
     }//end _searchForConflict()
 

src/Standards/PSR2/Sniffs/Classes/ClassDeclarationSniff.php

Doc Comments +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
     /**
      * Processes this test, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token
      *                                         in the stack passed in $tokens.
      *
@@ -46,7 +46,7 @@ 
     /**
      * Processes the opening section of a class declaration.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token
      *                                        in the stack passed in $tokens.
      *
@@ -386,7 +386,7 @@ 
     /**
      * Processes the closing section of a class declaration.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token
      *                                        in the stack passed in $tokens.
      *

Indentation +22 added lines, -22 removed lines

@@ -90,7 +90,7 @@ 
                                     $prevContent,
                                     $stackPtrType,
                                     $spaces,
-                                   );
+                                    );
 
                     $fix = $phpcsFile->addFixableError($error, $stackPtr, 'SpaceBeforeKeyword', $data);
                     if ($fix === true) {
@@ -105,7 +105,7 @@ 
                 $data        = array(
                                 $prevContent,
                                 $stackPtrType,
-                               );
+                                );
 
                 $fix = $phpcsFile->addFixableError($error, $stackPtr, 'NewlineBeforeKeyword', $data);
                 if ($fix === true) {
@@ -137,10 +137,10 @@ 
             $found = strlen($gap);
             $error = 'Expected 1 space between %s keyword and %s name; %s found';
             $data  = array(
-                      $stackPtrType,
-                      $stackPtrType,
-                      $found,
-                     );
+                        $stackPtrType,
+                        $stackPtrType,
+                        $found,
+                        );
 
             $fix = $phpcsFile->addFixableError($error, $stackPtr, 'SpaceAfterKeyword', $data);
             if ($fix === true) {
@@ -155,9 +155,9 @@ 
                 $found = strlen($gap);
                 $error = 'Expected 1 space after %s name; %s found';
                 $data  = array(
-                          $stackPtrType,
-                          $found,
-                         );
+                            $stackPtrType,
+                            $found,
+                            );
 
                 $fix = $phpcsFile->addFixableError($error, $className, 'SpaceAfterName', $data);
                 if ($fix === true) {
@@ -227,8 +227,8 @@ 
         }
 
         $find = array(
-                 T_STRING,
-                 $keywordTokenType,
+                    T_STRING,
+                    $keywordTokenType,
                 );
 
         $classNames = array();
@@ -255,8 +255,8 @@ 
             ) {
                 $prev = $phpcsFile->findPrevious(
                     array(
-                     T_NS_SEPARATOR,
-                     T_WHITESPACE,
+                        T_NS_SEPARATOR,
+                        T_WHITESPACE,
                     ),
                     ($className - 1),
                     $implements,
@@ -319,9 +319,9 @@ 
                     if ($found !== $expected) {
                         $error = 'Expected %s spaces before interface name; %s found';
                         $data  = array(
-                                  $expected,
-                                  $found,
-                                 );
+                                    $expected,
+                                    $found,
+                                    );
                         $fix   = $phpcsFile->addFixableError($error, $className, 'InterfaceWrongIndent', $data);
                         if ($fix === true) {
                             $padding = str_repeat(' ', $expected);
@@ -358,9 +358,9 @@ 
                     if ($spaceBefore !== 1) {
                         $error = 'Expected 1 space before "%s"; %s found';
                         $data  = array(
-                                  $tokens[$className]['content'],
-                                  $spaceBefore,
-                                 );
+                                    $tokens[$className]['content'],
+                                    $spaceBefore,
+                                    );
 
                         $fix = $phpcsFile->addFixableError($error, $className, 'SpaceBeforeName', $data);
                         if ($fix === true) {
@@ -380,9 +380,9 @@ 
                     if ($tokens[($className + 2)]['code'] !== $keywordTokenType) {
                         $error = 'Expected 0 spaces between "%s" and comma; %s found';
                         $data  = array(
-                                  $tokens[$className]['content'],
-                                  strlen($tokens[($className + 1)]['content']),
-                                 );
+                                    $tokens[$className]['content'],
+                                    strlen($tokens[($className + 1)]['content']),
+                                    );
 
                         $fix = $phpcsFile->addFixableError($error, $className, 'SpaceBeforeComma', $data);
                         if ($fix === true) {

Spacing +1 added lines, -1 removed lines

@@ -322,7 +322,7 @@
                                   $expected,
                                   $found,
                                  );
-                        $fix   = $phpcsFile->addFixableError($error, $className, 'InterfaceWrongIndent', $data);
+                        $fix = $phpcsFile->addFixableError($error, $className, 'InterfaceWrongIndent', $data);
                         if ($fix === true) {
                             $padding = str_repeat(' ', $expected);
                             if ($found === 0) {

src/Standards/PSR2/Sniffs/ControlStructures/SwitchDeclarationSniff.php

Doc Comments +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {
@@ -39,7 +39,7 @@ 
     /**
      * Processes this test, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token in the
      *                                        stack passed in $tokens.
      *
@@ -209,7 +209,7 @@ 
      *
      * Note that nested switches are ignored.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position to start looking at.
      * @param int                  $end       The position to stop looking at.
      *

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 
 use PHP_CodeSniffer\Sniffs\Sniff;
 use PHP_CodeSniffer\Files\File;
-use PHP_CodeSniffer\Util\Tokens;
 
 class SwitchDeclarationSniff implements Sniff
 {

Indentation +2 added lines, -2 removed lines

@@ -87,8 +87,8 @@
                 $expected = strtolower($tokens[$nextCase]['content']);
                 $error    = strtoupper($type).' keyword must be lowercase; expected "%s" but found "%s"';
                 $data     = array(
-                             $expected,
-                             $tokens[$nextCase]['content'],
+                                $expected,
+                                $tokens[$nextCase]['content'],
                             );
 
                 $fix = $phpcsFile->addFixableError($error, $nextCase, $type.'NotLower', $data);

src/Standards/PSR2/Sniffs/Files/ClosingTagSniff.php

Doc Comments +3 added lines, -3 removed lines

@@ -20,7 +20,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {
@@ -32,11 +32,11 @@ 
     /**
      * Processes this sniff, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token in
      *                                        the stack passed in $tokens.
      *
-     * @return void
+     * @return integer
      */
     public function process(File $phpcsFile, $stackPtr)
     {

src/Standards/PSR2/Sniffs/Files/EndFileNewlineSniff.php

Doc Comments +3 added lines, -3 removed lines

@@ -19,7 +19,7 @@ 
     /**
      * Returns an array of tokens this test wants to listen for.
      *
-     * @return array
+     * @return integer[]
      */
     public function register()
     {
@@ -31,11 +31,11 @@ 
     /**
      * Processes this sniff, when one of its tokens is encountered.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file being scanned.
+     * @param File $phpcsFile The file being scanned.
      * @param int                  $stackPtr  The position of the current token in
      *                                        the stack passed in $tokens.
      *
-     * @return void
+     * @return integer
      */
     public function process(File $phpcsFile, $stackPtr)
     {

src/Standards/PSR2/Sniffs/Methods/MethodDeclarationSniff.php

Doc Comments +2 added lines, -2 removed lines

@@ -30,7 +30,7 @@ 
     /**
      * Processes the function tokens within the class.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file where this token was found.
+     * @param File $phpcsFile The file where this token was found.
      * @param int                  $stackPtr  The position where the token was found.
      * @param int                  $currScope The current scope opener token.
      *
@@ -140,7 +140,7 @@ 
      * Processes a token that is found within the scope that this test is
      * listening to.
      *
-     * @param PHP_CodeSniffer_File $phpcsFile The file where this token was found.
+     * @param File $phpcsFile The file where this token was found.
      * @param int                  $stackPtr  The position in the stack where this
      *                                        token was found.
      *

Switch Indentation +12 added lines, -12 removed lines

@@ -80,18 +80,18 @@
         $prefix = $stackPtr;
         while (($prefix = $phpcsFile->findPrevious(PHP_CodeSniffer_Tokens::$methodPrefixes, ($prefix - 1), $prev)) !== false) {
             switch ($tokens[$prefix]['code']) {
-            case T_STATIC:
-                $static = $prefix;
-                break;
-            case T_ABSTRACT:
-                $abstract = $prefix;
-                break;
-            case T_FINAL:
-                $final = $prefix;
-                break;
-            default:
-                $visibility = $prefix;
-                break;
+                case T_STATIC:
+                    $static = $prefix;
+                    break;
+                case T_ABSTRACT:
+                    $abstract = $prefix;
+                    break;
+                case T_FINAL:
+                    $final = $prefix;
+                    break;
+                default:
+                    $visibility = $prefix;
+                    break;
             }
         }