|
1
|
|
|
<?php |
|
2
|
|
|
|
|
3
|
|
|
/* |
|
4
|
|
|
* This file is part of Symplify |
|
5
|
|
|
* Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz). |
|
6
|
|
|
*/ |
|
7
|
|
|
|
|
8
|
|
|
namespace Symplify\PHP7_CodeSniffer\Sniff; |
|
9
|
|
|
|
|
10
|
|
|
use Symplify\PHP7_CodeSniffer\Configuration\ConfigurationResolver; |
|
11
|
|
|
use Symplify\PHP7_CodeSniffer\Ruleset\RulesetBuilder; |
|
12
|
|
|
|
|
13
|
|
|
final class SniffClassesResolver |
|
14
|
|
|
{ |
|
15
|
|
|
/** |
|
16
|
|
|
* @var ConfigurationResolver |
|
17
|
|
|
*/ |
|
18
|
|
|
private $configurationResolver; |
|
19
|
|
|
|
|
20
|
|
|
/** |
|
21
|
|
|
* @var RulesetBuilder |
|
22
|
|
|
*/ |
|
23
|
|
|
private $rulesetBuilder; |
|
24
|
|
|
|
|
25
|
|
|
public function __construct( |
|
26
|
|
|
ConfigurationResolver $configurationResolver, |
|
27
|
|
|
RulesetBuilder $rulesetBuilder |
|
28
|
|
|
) { |
|
29
|
|
|
$this->configurationResolver = $configurationResolver; |
|
30
|
|
|
$this->rulesetBuilder = $rulesetBuilder; |
|
31
|
|
|
} |
|
32
|
|
|
|
|
33
|
|
|
public function resolveFromStandardsAndSniffs(array $standards, array $includedSniffs) : array |
|
34
|
|
|
{ |
|
35
|
|
|
$standards = $this->configurationResolver->resolveStandards($standards); |
|
36
|
|
|
$includedSniffs = $this->configurationResolver->resolveSniffs($includedSniffs); |
|
37
|
|
|
|
|
38
|
|
|
$sniffs = []; |
|
39
|
|
|
foreach ($standards as $rulesetXmlPath) { |
|
40
|
|
|
$newSniffs = $this->rulesetBuilder->buildFromRulesetXml($rulesetXmlPath); |
|
41
|
|
|
$sniffs = array_merge($sniffs, $newSniffs); |
|
42
|
|
|
} |
|
43
|
|
|
|
|
44
|
|
|
if ($includedSniffs) { |
|
|
|
|
|
|
45
|
|
|
$sniffs = $this->excludeRestrictedSniffs($sniffs, $includedSniffs); |
|
46
|
|
|
} |
|
47
|
|
|
|
|
48
|
|
|
return $sniffs; |
|
49
|
|
|
} |
|
50
|
|
|
|
|
51
|
|
|
private function excludeRestrictedSniffs(array $sniffs, array $exclusivelyIncludedSniffs) |
|
52
|
|
|
{ |
|
53
|
|
|
$finalSniffs = []; |
|
54
|
|
|
foreach ($sniffs as $sniffCode => $sniffClass) { |
|
55
|
|
|
if (isset($exclusivelyIncludedSniffs[$sniffCode]) === false) { |
|
56
|
|
|
continue; |
|
57
|
|
|
} |
|
58
|
|
|
|
|
59
|
|
|
$finalSniffs[$sniffCode] = $sniffClass; |
|
60
|
|
|
} |
|
61
|
|
|
|
|
62
|
|
|
return $finalSniffs; |
|
63
|
|
|
} |
|
64
|
|
|
} |
|
65
|
|
|
|
Symplify /
PHP7_CodeSniffer
This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent.
Consider making the comparison explicit by using
empty(..)or! empty(...)instead.