Ruleset::decorateSniffsWithCustomRules() - Code Metrics - Inspection of "Merge pull request #1 from Symplify/cleanup" - Symplify/PHP7_CodeSniffer - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (06cb84)

by Tomáš

created 2016-08-03 12:08 UTC

Ruleset::decorateSniffsWithCustomRules() A

↳ Parent: Ruleset

Complexity

Conditions	4
Paths	3

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	20

Importance

Changes	3
Bugs	1	Features	1

Metric	Value
dl	0
loc	15
ccs	0
cts	12
cp	0
rs	9.2
c	3
b	1
f	1
cc	4
eloc	7
nc	3
nop	1
crap	20

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\PHP7_CodeSniffer;

use PHP_CodeSniffer\Sniffs\Sniff;
use Symplify\PHP7_CodeSniffer\Ruleset\RulesetBuilder;

final class Ruleset
{
    /**
     * @var RulesetBuilder
     */
    private $rulesetBuilder;

    public function __construct(RulesetBuilder $rulesetBuilder)
    {
        $this->rulesetBuilder = $rulesetBuilder;
    }

    /**
     * @param array|Sniff[] $sniffs
     */
    public function decorateSniffsWithCustomRules(array $sniffs)
    {
        // todo: put to SniffDispatcher on sniff loading?
        $ruleset = $this->rulesetBuilder->getRuleset();

        foreach ($sniffs as $sniffCode => $sniffObject) {
            if (!isset($ruleset[$sniffCode]['properties'])) {
                continue;
            }

            foreach ($ruleset[$sniffCode]['properties'] as $name => $value) {
                $this->setSniffProperty($sniffCode, $name, $value);
            }
        }
    }

    /**
     * @param string $sniffCode
     * @param string $name
     * @param string|array $value
     */
    private function setSniffProperty(string $sniffCode, string $name, $value)
    {
        if (isset($sniffs[$sniffCode]) === false) {

            return;
        }

        $name = trim($name);
        if (is_string($value)) {
            $value = trim($value);
        }

        // Special case for booleans.
        if ($value === 'true') {
            $value = true;
        } elseif ($value === 'false') {
            $value = false;
        }

        $sniffs[$sniffCode]->$name = $value;

    }
}


1			<?php
2
3			/*
4			* This file is part of Symplify
5			* Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
6			*/
7
8			namespace Symplify\PHP7_CodeSniffer;
9
10			use PHP_CodeSniffer\Sniffs\Sniff;
11			use Symplify\PHP7_CodeSniffer\Ruleset\RulesetBuilder;
12
13			final class Ruleset
14			{
15			/**
16			* @var RulesetBuilder
17			*/
18			private $rulesetBuilder;
19
20			public function __construct(RulesetBuilder $rulesetBuilder)
21			{
22			$this->rulesetBuilder = $rulesetBuilder;
23			}
24
25			/**
26			* @param array\|Sniff[] $sniffs
27			*/
28			public function decorateSniffsWithCustomRules(array $sniffs)
29			{
30			// todo: put to SniffDispatcher on sniff loading?
31			$ruleset = $this->rulesetBuilder->getRuleset();
32
33			foreach ($sniffs as $sniffCode => $sniffObject) {
34			if (!isset($ruleset[$sniffCode]['properties'])) {
35			continue;
36			}
37
38			foreach ($ruleset[$sniffCode]['properties'] as $name => $value) {
39			$this->setSniffProperty($sniffCode, $name, $value);
40			}
41			}
42			}
43
44			/**
45			* @param string $sniffCode
46			* @param string $name
47			* @param string\|array $value
48			*/
49			private function setSniffProperty(string $sniffCode, string $name, $value)
50			{
51			if (isset($sniffs[$sniffCode]) === false) {
			0 ignored issues – show Bug introduced 2016-08-03 12:14 UTC by Report Bug Copy Issue Report The variable `$sniffs` seems to never exist, and therefore `isset` should always return `false`. Did you maybe rename this variable? This check looks for calls to `isset(...)` or `empty()` on variables that are yet undefined. These calls will always produce the same result and can be removed. This is most likely caused by the renaming of a variable or the removal of a function/method parameter. Loading history...
52			return;
53			}
54
55			$name = trim($name);
56			if (is_string($value)) {
57			$value = trim($value);
58			}
59
60			// Special case for booleans.
61			if ($value === 'true') {
62			$value = true;
63			} elseif ($value === 'false') {
64			$value = false;
65			}
66
67			$sniffs[$sniffCode]->$name = $value;
			0 ignored issues – show Bug introduced 2016-08-03 12:14 UTC by Report Bug Copy Issue Report The variable `$sniffs` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
68			}
69			}
70

Symplify / PHP7_CodeSniffer

Branch — master (06cb84)

Ruleset::decorateSniffsWithCustomRules() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like