Completed
Push — master ( 8133f1...b4cba0 )
by Tomáš
09:56 queued 38s
created

ContainerBuilderTransformerTest   A

Complexity

Total Complexity 6

Size/Duplication

Total Lines 125
Duplicated Lines 32.8 %

Coupling/Cohesion

Components 1
Dependencies 8

Importance

Changes 1
Bugs 0 Features 0
Metric Value
wmc 6
c 1
b 0
f 0
lcom 1
cbo 8
dl 41
loc 125
rs 10

6 Methods

Rating   Name   Duplication   Size   Complexity  
A setUp() 0 5 1
B testAddingAlreadyExistingService() 0 26 1
A testTags() 20 20 1
A testAutowiringStep2() 21 21 1
B testPreventDuplicating() 0 29 1
A transformFromNetteToSymfonyAndCompile() 0 11 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace Symplify\NetteAdapaterForSymfonyBundles\Tests\Transformer;
4
5
use Doctrine\Common\Annotations\AnnotationReader;
6
use Doctrine\Common\Annotations\CachedReader;
7
use Doctrine\Common\Annotations\Reader;
8
use Nette\DI\ContainerBuilder;
9
use PHPUnit\Framework\TestCase;
10
use stdClass;
11
use Symfony\Component\DependencyInjection\ContainerBuilder as SymfonyContainerBuilder;
12
use Symplify\NetteAdapaterForSymfonyBundles\Tests\Transformer\ContainerBuilderTransformerSource\AutowireReader;
13
use Symplify\NetteAdapaterForSymfonyBundles\Transformer\ArgumentsTransformer;
14
use Symplify\NetteAdapaterForSymfonyBundles\Transformer\ContainerBuilderTransformer;
15
use Symplify\NetteAdapaterForSymfonyBundles\Transformer\ServiceDefinitionTransformer;
16
17
final class ContainerBuilderTransformerTest extends TestCase
18
{
19
    /**
20
     * @var ContainerBuilderTransformer
21
     */
22
    private $containerBuilderTransformer;
23
24
    protected function setUp()
25
    {
26
        $serviceDefinitionTransformer = new ServiceDefinitionTransformer(new ArgumentsTransformer());
27
        $this->containerBuilderTransformer = new ContainerBuilderTransformer($serviceDefinitionTransformer);
28
    }
29
30
    public function testAddingAlreadyExistingService()
31
    {
32
        $netteContainerBuilder = new ContainerBuilder();
33
        $netteContainerBuilder->addDefinition('someservice')
34
            ->setClass(stdClass::class)
35
            ->setAutowired(false);
36
37
        $symfonyContainerBuilder = new SymfonyContainerBuilder();
38
        $this->containerBuilderTransformer->transformFromNetteToSymfony(
39
            $netteContainerBuilder,
40
            $symfonyContainerBuilder
41
        );
42
43
        $this->containerBuilderTransformer->transformFromSymfonyToNette(
44
            $symfonyContainerBuilder,
45
            $netteContainerBuilder
46
        );
47
48
        $netteDefinition = $netteContainerBuilder->getDefinition('someservice');
49
        $this->assertSame(stdClass::class, $netteDefinition->getClass());
50
51
        $symfonyDefinition = $symfonyContainerBuilder->getDefinition('someservice');
52
        $this->assertSame(stdClass::class, $symfonyDefinition->getClass());
53
54
        $this->assertSame($netteDefinition->getClass(), $symfonyDefinition->getClass());
55
    }
56
57 View Code Duplication
    public function testTags()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
58
    {
59
        $netteContainerBuilder = new ContainerBuilder();
60
        $netteDefinition = $netteContainerBuilder->addDefinition('someService')
61
            ->setClass(stdClass::class)
62
            ->addTag('someTag');
63
64
        $symfonyContainerBuilder = new SymfonyContainerBuilder();
65
        $this->transformFromNetteToSymfonyAndCompile($netteContainerBuilder, $symfonyContainerBuilder);
66
67
        $symfonyDefinition = $symfonyContainerBuilder->getDefinition('someService');
68
        $this->assertSame(['someTag' => [[true]]], $symfonyDefinition->getTags());
69
70
        $this->containerBuilderTransformer->transformFromSymfonyToNette(
71
            $symfonyContainerBuilder,
72
            $netteContainerBuilder
73
        );
74
75
        $this->assertSame($netteDefinition, $netteContainerBuilder->getDefinition('someService'));
76
    }
77
78 View Code Duplication
    public function testAutowiringStep2()
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
79
    {
80
        $netteContainerBuilder = new ContainerBuilder();
81
        $netteDefinition = $netteContainerBuilder->addDefinition('someService')
82
            ->setClass(stdClass::class)
83
            ->addTag('someTag');
84
85
        $symfonyContainerBuilder = new SymfonyContainerBuilder();
86
87
        $this->transformFromNetteToSymfonyAndCompile($netteContainerBuilder, $symfonyContainerBuilder);
88
89
        $symfonyDefinition = $symfonyContainerBuilder->getDefinition('someService');
90
        $this->assertSame(['someTag' => [[true]]], $symfonyDefinition->getTags());
91
92
        $this->containerBuilderTransformer->transformFromSymfonyToNette(
93
            $symfonyContainerBuilder,
94
            $netteContainerBuilder
95
        );
96
97
        $this->assertSame($netteDefinition, $netteContainerBuilder->getDefinition('someService'));
98
    }
99
100
    public function testPreventDuplicating()
101
    {
102
        $netteContainerBuilder = new ContainerBuilder();
103
        $netteContainerBuilder->addDefinition('annotationReader')
104
            ->setClass(AnnotationReader::class)
105
            ->setAutowired(false);
106
107
        $netteContainerBuilder->addDefinition('reader')
108
            ->setClass(Reader::class)
109
            ->setFactory(CachedReader::class);
110
111
        $netteContainerBuilder->addDefinition('autowireReader')
112
            ->setClass(AutowireReader::class);
113
114
        $symfonyContainerBuilder = new SymfonyContainerBuilder();
115
116
        $this->transformFromNetteToSymfonyAndCompile($netteContainerBuilder, $symfonyContainerBuilder);
117
118
        $this->containerBuilderTransformer->transformFromSymfonyToNette(
119
            $symfonyContainerBuilder,
120
            $netteContainerBuilder
121
        );
122
123
        $this->assertCount(3, $netteContainerBuilder->getDefinitions());
124
125
        $netteContainerBuilder->prepareClassList();
126
        $readerDefinition = $netteContainerBuilder->getDefinition($netteContainerBuilder->getByType(Reader::class));
127
        $this->assertSame(Reader::class, $readerDefinition->getClass());
128
    }
129
130
    private function transformFromNetteToSymfonyAndCompile(
131
        ContainerBuilder $netteContainerBuilder,
132
        SymfonyContainerBuilder $symfonyContainerBuilder
133
    ) {
134
        $this->containerBuilderTransformer->transformFromNetteToSymfony(
135
            $netteContainerBuilder,
136
            $symfonyContainerBuilder
137
        );
138
139
        $symfonyContainerBuilder->compile();
140
    }
141
}
142