Symplify\MultiCodingStandard\CodeSniffer\FileSystem\RulesetFileSystem

Complexity

Total Complexity

8

Size/Duplication

Total Lines	77
Duplicated Lines	10.39 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

79.17%

Importance

Changes	2
Bugs	0	Features	1

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	getRulesetPathForStandardName()	0	14	2
A	getRulesets()	0	15	3
A	findRulesetFiles()	8	8	1
A	getRulesetNames()	0	4	1

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\MultiCodingStandard\CodeSniffer\FileSystem;

use Exception;
use Nette\Utils\Strings;
use Symfony\Component\Finder\Finder;
use Symplify\MultiCodingStandard\Contract\CodeSniffer\FileSystem\RulesetFileSystemInterface;

final class RulesetFileSystem implements RulesetFileSystemInterface
{
    /**
     * @var string
     */
    private $vendorDir;

    /**
     * @var strings[]
     */
    private $rulesets;

    /**
     * @param string $vendorDir
     */
    public function __construct($vendorDir)
    {
        $this->vendorDir = $vendorDir;
    }

    /**
     * {@inheritdoc}
     */
    public function getRulesetPathForStandardName($standardName)
    {
        if (isset($this->getRulesets()[$standardName])) {
            return $this->getRulesets()[$standardName];

The expression $this->getRulesets()[$standardName]; of type integer|string|Symplify\MultiCodingStandard\CodeSniffer\FileSystem\strings adds the type Symplify\MultiCodingStandard\CodeSniffer\FileSystem\strings to the return on line 41 which is incompatible with the return type declared by the interface Symplify\MultiCodingStandard\Contract\CodeSniffer\FileSystem\RulesetFileSystemInterface::getRulesetPathForStandardName of type string.

        }

        throw new Exception(
            sprintf(
                'Ruleset for standard "%s" was not found. Found standards are: %s.',
                $standardName,
                implode($this->getRulesetNames(), ', ')
            )
        );
    }

    /**
     * @return array
     */
    private function getRulesets()
    {
        if ($this->rulesets) {

The expression $this->rulesets of type Symplify\MultiCodingStandard\CodeSniffer\FileSystem\strings[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->rulesets;
        }

        foreach ($this->findRulesetFiles() as $rulesetFile) {
            $rulesetXml = simplexml_load_file($rulesetFile);

            $rulesetName = (string) $rulesetXml['name'];
            $this->rulesets[$rulesetName] = $rulesetFile;
        }

        return $this->rulesets;
    }

    /**
     * @return string[]
     */
    private function findRulesetFiles()

This method seems to be duplicated in your project.

    {
        $installedStandards = (new Finder())->files()
            ->in($this->vendorDir)
            ->name('ruleset.xml');

        return array_keys(iterator_to_array($installedStandards));
    }

    /**
     * @return string[]
     */
    private function getRulesetNames()
    {
        return array_keys($this->getRulesets());
    }
}