MultiCodingStandardExtension::loadConfiguration() - Code Metrics - Inspection of "Merge pull request #11 from Symplify/php-cs-fixer" - Symplify/MultiCodingStandard - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( afadea...e6376f )

by Tomáš

created 2016-08-29 12:32 UTC

MultiCodingStandardExtension::loadConfiguration() A

↳ Parent: MultiCodingStandardExtension

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes	3
Bugs	0	Features	0

Metric	Value
dl	0
loc	5
ccs	0
cts	5
cp	0
rs	9.4285
c	3
b	0
f	0
cc	1
eloc	3
nc	1
nop	0
crap	2

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\MultiCodingStandard\DI;

use Nette\DI\CompilerExtension;
use Nette\DI\Helpers;

final class MultiCodingStandardExtension extends CompilerExtension
{
    /**
     * @var string[]
     */
    private $defaults = [
        'configPath' => '%appDir%/../../multi-cs.json'
    ];

    /**
     * {@inheritdoc}
     */
    public function loadConfiguration()
    {
        $this->setConfigToContainerBuilder($this->defaults);
        $this->loadServicesFromConfigPath(__DIR__ . '/../config/services.neon');
    }

    /**
     * @param string[] $defaults
     */
    private function setConfigToContainerBuilder(array $defaults)
    {
        $config = $this->validateConfig($defaults);
        $config['configPath'] = Helpers::expand($config['configPath'], $this->getContainerBuilder()->parameters);
        $this->getContainerBuilder()->parameters += $config;
    }

    private function loadServicesFromConfigPath(string $configPath)
    {
        $containerBuilder = $this->getContainerBuilder();
        $config = $this->loadFromFile($configPath);
        $this->compiler->parseServices($containerBuilder, $config);
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }
}


1			<?php
2
3			/*
4			* This file is part of Symplify
5			* Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
6			*/
7
8			namespace Symplify\MultiCodingStandard\DI;
9
10			use Nette\DI\CompilerExtension;
11			use Nette\DI\Helpers;
12
13			final class MultiCodingStandardExtension extends CompilerExtension
14			{
15			/**
16			* @var string[]
17			*/
18			private $defaults = [
19			'configPath' => '%appDir%/../../multi-cs.json'
20			];
21
22			/**
23			* {@inheritdoc}
24			*/
25			public function loadConfiguration()
26			{
27			$this->setConfigToContainerBuilder($this->defaults);
28			$this->loadServicesFromConfigPath(__DIR__ . '/../config/services.neon');
29			}
30
31			/**
32			* @param string[] $defaults
33			*/
34			private function setConfigToContainerBuilder(array $defaults)
35			{
36			$config = $this->validateConfig($defaults);
37			$config['configPath'] = Helpers::expand($config['configPath'], $this->getContainerBuilder()->parameters);
38			$this->getContainerBuilder()->parameters += $config;
39			}
40
41			private function loadServicesFromConfigPath(string $configPath)
42			{
43			$containerBuilder = $this->getContainerBuilder();
44			$config = $this->loadFromFile($configPath);
45			$this->compiler->parseServices($containerBuilder, $config);
			0 ignored issues – show Deprecated Code introduced 2016-07-28 14:00 UTC by Report Bug Copy Issue Report The method `Nette\DI\Compiler::parseServices()` has been deprecated. This method has been deprecated. Loading history... Bug introduced 2016-08-22 14:58 UTC by Report Bug Copy Issue Report It seems like `$config` defined by `$this->loadFromFile($configPath)` on line `44` can also be of type `string`; however, `Nette\DI\Compiler::parseServices()` does only seem to accept `array`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
46			}
47			}
48

Symplify / MultiCodingStandard

Push — master ( afadea...e6376f )

MultiCodingStandardExtension::loadConfiguration() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like