CompleteTest::testIsAutowired() - Code Metrics - Inspection of "Merge pull request #2 from Symplify/default-types" - Symplify/DefaultAutowire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8c5b1a...9a26dd )

by Tomáš

created 2016-07-18 10:17 UTC

CompleteTest::testIsAutowired() A

↳ Parent: CompleteTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	7
rs	9.4285
c	1
b	0
f	0
cc	1
eloc	4
nc	1
nop	0

<?php

namespace Symplify\DefaultAutowire\Tests;

use Doctrine\ORM\EntityManagerInterface;
use PHPUnit_Framework_TestCase;
use Symfony\Component\DependencyInjection\Container;
use Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;
use Symplify\DefaultAutowire\Tests\Resources\Repository\SomeRepository;
use Symplify\DefaultAutowire\Tests\Source\SomeAutowiredService;
use Symplify\DefaultAutowire\Tests\Source\SomeService;

final class CompleteTest extends PHPUnit_Framework_TestCase
{
    /**
     * @var Container
     */
    private $container;

    protected function setUp()
    {
        $kernel = new AppKernel('test_env', true);
        $kernel->boot();

        $this->container = $kernel->getContainer();
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    public function testSomeServiceAutowire()
    {
        /** @var SomeAutowiredService $someAutowiredService */
        $someAutowiredService = $this->container->get('some_autowired_service');

        $this->assertInstanceOf(SomeAutowiredService::class, $someAutowiredService);
        $this->assertInstanceOf(SomeService::class, $someAutowiredService->getSomeService());

        $this->assertInstanceOf(EventDispatcherInterface::class, $someAutowiredService->getEventDispatcher());
        $this->assertInstanceOf(EventDispatcher::class, $someAutowiredService->getEventDispatcher());
        $this->assertNotInstanceOf(TraceableEventDispatcher::class, $someAutowiredService->getEventDispatcher());
    }

    public function testRepositoryAutowire()
    {
        /** @var SomeRepository $someRepository */
        $someRepository = $this->container->get('some_repository');
        $this->assertInstanceOf(SomeRepository::class, $someRepository);
        $this->assertInstanceOf(EntityManagerInterface::class, $someRepository->getEntityManager());
    }
}


1			<?php
2
3			namespace Symplify\DefaultAutowire\Tests;
4
5			use Doctrine\ORM\EntityManagerInterface;
6			use PHPUnit_Framework_TestCase;
7			use Symfony\Component\DependencyInjection\Container;
8			use Symfony\Component\EventDispatcher\Debug\TraceableEventDispatcher;
9			use Symfony\Component\EventDispatcher\EventDispatcher;
10			use Symfony\Component\EventDispatcher\EventDispatcherInterface;
11			use Symplify\DefaultAutowire\Tests\Resources\Repository\SomeRepository;
12			use Symplify\DefaultAutowire\Tests\Source\SomeAutowiredService;
13			use Symplify\DefaultAutowire\Tests\Source\SomeService;
14
15			final class CompleteTest extends PHPUnit_Framework_TestCase
16			{
17			/**
18			* @var Container
19			*/
20			private $container;
21
22			protected function setUp()
23			{
24			$kernel = new AppKernel('test_env', true);
25			$kernel->boot();
26
27			$this->container = $kernel->getContainer();
			0 ignored issues – show Documentation Bug introduced 2016-07-18 10:35 UTC by Report Bug Copy Issue Report It seems like `$kernel->getContainer()` can also be of type `object<Symfony\Component...ion\ContainerInterface>`. However, the property `$container` is declared as type `object<Symfony\Component...ncyInjection\Container>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
28			}
29
30			public function testSomeServiceAutowire()
31			{
32			/** @var SomeAutowiredService $someAutowiredService */
33			$someAutowiredService = $this->container->get('some_autowired_service');
34
35			$this->assertInstanceOf(SomeAutowiredService::class, $someAutowiredService);
36			$this->assertInstanceOf(SomeService::class, $someAutowiredService->getSomeService());
37
38			$this->assertInstanceOf(EventDispatcherInterface::class, $someAutowiredService->getEventDispatcher());
39			$this->assertInstanceOf(EventDispatcher::class, $someAutowiredService->getEventDispatcher());
40			$this->assertNotInstanceOf(TraceableEventDispatcher::class, $someAutowiredService->getEventDispatcher());
41			}
42
43			public function testRepositoryAutowire()
44			{
45			/** @var SomeRepository $someRepository */
46			$someRepository = $this->container->get('some_repository');
47			$this->assertInstanceOf(SomeRepository::class, $someRepository);
48			$this->assertInstanceOf(EntityManagerInterface::class, $someRepository->getEntityManager());
49			}
50			}
51

Symplify / DefaultAutowire

Push — master ( 8c5b1a...9a26dd )

CompleteTest::testIsAutowired() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like