DefaultAutowireTypesCompilerPass::process() - Code Metrics - Inspection of "Merge pull request #2 from Symplify/default-types" - Symplify/DefaultAutowire - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 8c5b1a...9a26dd )

by Tomáš

created 2016-07-18 10:17 UTC

DefaultAutowireTypesCompilerPass::process() A

↳ Parent: DefaultAutowireTypesCompilerPass

Complexity

Conditions	4
Paths	4

Size

Total Lines	16
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	4

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	16
ccs	10
cts	10
cp	1
rs	9.2
cc	4
eloc	9
nc	4
nop	1
crap	4

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\DefaultAutowire\DependencyInjection\Compiler;

use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symplify\DefaultAutowire\Config\Definition\ConfigurationResolver;

final class DefaultAutowireTypesCompilerPass implements CompilerPassInterface
{
    /**
     * {@inheritdoc}
     */
    public function process(ContainerBuilder $containerBuilder)
    {
        $autowireTypes = $this->getAutowireTypes($containerBuilder);
        foreach ($autowireTypes as $type => $serviceName) {
            if (!$containerBuilder->has($serviceName)) {
                continue;
            }

            if ($containerBuilder->hasAlias($serviceName)) {
                $serviceName = $containerBuilder->getAlias($serviceName);
            }

            $containerBuilder->getDefinition($serviceName)
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
                ->setAutowiringTypes([$type]);
        }
    }

    /**
     * @return string[]
     */
    private function getAutowireTypes(ContainerBuilder $containerBuilder)
    {
        $config = (new ConfigurationResolver())->resolveFromContainerBuilder($containerBuilder);

        return $config['autowire_types'];
    }
}


1		<?php
2
3		/*
4		* This file is part of Symplify
5		* Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
6		*/
7
8		namespace Symplify\DefaultAutowire\DependencyInjection\Compiler;
9
10		use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
11		use Symfony\Component\DependencyInjection\ContainerBuilder;
12		use Symplify\DefaultAutowire\Config\Definition\ConfigurationResolver;
13
14		final class DefaultAutowireTypesCompilerPass implements CompilerPassInterface
15		{
16		/**
17		* {@inheritdoc}
18		*/
19	2	public function process(ContainerBuilder $containerBuilder)
20		{
21	2	$autowireTypes = $this->getAutowireTypes($containerBuilder);
22	2	foreach ($autowireTypes as $type => $serviceName) {
23	2	if (!$containerBuilder->has($serviceName)) {
24	2	continue;
25		}
26
27	2	if ($containerBuilder->hasAlias($serviceName)) {
28	1	$serviceName = $containerBuilder->getAlias($serviceName);
29		}
30
31	2	$containerBuilder->getDefinition($serviceName)
		0 ignored issues – show Bug introduced 2016-07-18 10:35 UTC by Report Bug Copy Issue Report It seems like `$serviceName` defined by `$containerBuilder->getAlias($serviceName)` on line `28` can also be of type `object<Symfony\Component...endencyInjection\Alias>`; however, `Symfony\Component\Depend...uilder::getDefinition()` does only seem to accept `string`, maybe add an additional type check? If a method or function can return multiple different values and unless you are sure that you only can receive a single value in this context, we recommend to add an additional type check: /** * @return array\|string */ function returnsDifferentValues($x) { if ($x) { return 'foo'; } return array(); } $x = returnsDifferentValues($y); if (is_array($x)) { // $x is an array. } If this a common case that PHP Analyzer should handle natively, please let us know by opening an issue. Loading history...
32	2	->setAutowiringTypes([$type]);
33		}
34	2	}
35
36		/**
37		* @return string[]
38		*/
39	2	private function getAutowireTypes(ContainerBuilder $containerBuilder)
40		{
41	2	$config = (new ConfigurationResolver())->resolveFromContainerBuilder($containerBuilder);
42
43	2	return $config['autowire_types'];
44		}
45		}
46

Symplify / DefaultAutowire

Push — master ( 8c5b1a...9a26dd )

DefaultAutowireTypesCompilerPass::process() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like