Symplify\DefaultAutowire\Config\Definition\ConfigurationResolver

Complexity

Total Complexity

2

Size/Duplication

Total Lines	21
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	1	Features	2

1 Method

Rating	Name	Duplication	Size	Complexity
A	resolveFromContainerBuilder()	0	13	2

<?php

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\DefaultAutowire\Config\Definition;

use Symfony\Component\Config\Definition\Processor;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symplify\DefaultAutowire\SymplifyDefaultAutowireBundle;

final class ConfigurationResolver
{
    /**
     * @var string[]
     */
    private $resolvedConfiguration;

    public function resolveFromContainerBuilder(ContainerBuilder $containerBuilder) : array
    {
        if ($this->resolvedConfiguration) {

The expression $this->resolvedConfiguration of type string[] is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $this->resolvedConfiguration;
        }

        $processor = new Processor();
        $configs = $containerBuilder->getExtensionConfig(SymplifyDefaultAutowireBundle::ALIAS);
        $configs = $processor->processConfiguration(new Configuration(), $configs);

        return $this->resolvedConfiguration = $containerBuilder->getParameterBag()
            ->resolveValue($configs);
    }
}