Symplify\ActionAutowire\DependencyInjection\Compiler\ServicesByTypeMapCompilerPass

Complexity

Total Complexity

8

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	process()	0	14	3
A	isValidServiceDefinition()	0	16	4

<?php

declare(strict_types=1);

/*
 * This file is part of Symplify
 * Copyright (c) 2016 Tomas Votruba (http://tomasvotruba.cz).
 */

namespace Symplify\ActionAutowire\DependencyInjection\Compiler;

use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Definition;
use Symplify\ActionAutowire\DependencyInjection\Container\ServicesByTypeMap;

final class ServicesByTypeMapCompilerPass implements CompilerPassInterface
{
    /**
     * @var ServicesByTypeMap
     */
    private $serviceMap;

    public function __construct(ServicesByTypeMap $servicesByTypeMap)
    {
        $this->serviceMap = $servicesByTypeMap;
    }

    /**
     * {@inheritdoc}
     */
    public function process(ContainerBuilder $containerBuilder)
    {
        $parameterBag = $containerBuilder->getParameterBag();
        foreach ($containerBuilder->getDefinitions() as $serviceId => $definition) {
            if (! $this->isValidServiceDefinition($definition)) {
                continue;
            }

            $this->serviceMap->addService(
                $parameterBag->resolveValue($definition->getClass()),
                $serviceId
            );
        }
    }

    private function isValidServiceDefinition(Definition $definition) : bool
    {
        if ($definition->isAbstract()) {
            return false;
        }

        if (! $definition->isPublic()) {
            return false;
        }

        if (! $definition->getClass()) {

The expression $definition->getClass() of type string|null is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            return false;
        }

        return true;
    }
}