Issues in Cart.php (master) - Issues in master - Symfomany/laravelcinema - Measure and Improve Code Quality continuously with Scrutinizer

Issues (115)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/Http/Cart/Cart.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Http\Cart;

use Illuminate\Database\Eloquent\Collection;

/**
 * Class Cart.
 */
class Cart extends AbstractCart implements ItemInterface, \IteratorAggregate, \Countable
{
    /**
     * @var array
     */
    protected $products;

    /**
     * @var array
     */
    protected $total;

    /**
     * @var array
     */
    protected $promotions;

    /**
     * Constructor.
     */
    public function __construct(array $products = [])
    {
        $this->products = $products;
        $this->promotions = [];
        $this->total = 0;

    }

    /**
     * @param ItemInterface $item
     */
    public function add(ItemInterface $item)
    {
        $this->products[] = $item;

        return $this;
    }

    /**
     * @param ItemInterface $item
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function addItems(Collection $collection)
    {
        foreach ($collection as $item) {
            $this->products[] = $item;
        }

        return $this->products;
    }

    /**
     * @param ItemInterface $item
     */
    public function remove(ItemInterface $item)
    {
        $this->products[array_search($item, $this->products)] = $item;

        return $this;
    }

    /**
     * @return array
     */
    public function clear()
    {
        $this->products = [];

        return $this->products;
    }

    /**
     * @return array
     */
    public function all()
    {
        return $this->products;
    }

    /**
     * @return \ArrayIterator
     */
    public function getIterator()
    {
        return new \ArrayIterator($this->products);
    }

    /**
     * @return \ArrayIterator
     */
    public function count()
    {
        return count($this->products);
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    /**
     * Total TTC.
     *
     * @param int $taxe
     *
     * @return int
     */
    public function total($taxe = 1)
    {
        foreach ($this as $movie) {
            $this->total += $movie->getMovie()->prix;
        }

        return $this->total * $taxe;
    }

    /**
     * @return array
     */
    public function getProducts()
    {
        return $this->products;
    }

    /**
     * @param array $products
     */
    public function setProducts($products)
    {
        $this->products = $products;
    }

    /**
     * @return array
     */
    public function getTotal()
    {
        return $this->total;
    }

    /**
     * @param array $total
     */
    public function setTotal($total)
    {
        $this->total = $total;
    }

    /**
     * @return array
     */
    public function getPromotions()
    {
        return $this->promotions;
    }

    /**
     * @param array $promotions
     */
    public function setPromotions($promotions)
    {
        $this->promotions = $promotions;
    }

    /**
     * @param array $total
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function emptycart()
    {
        return empty($this->products) ? true : false;
    }
}


1			<?php
2
3			namespace App\Http\Cart;
4
5			use Illuminate\Database\Eloquent\Collection;
6
7			/**
8			* Class Cart.
9			*/
10			class Cart extends AbstractCart implements ItemInterface, \IteratorAggregate, \Countable
11			{
12			/**
13			* @var array
14			*/
15			protected $products;
16
17			/**
18			* @var array
19			*/
20			protected $total;
21
22			/**
23			* @var array
24			*/
25			protected $promotions;
26
27			/**
28			* Constructor.
29			*/
30			public function __construct(array $products = [])
31			{
32			$this->products = $products;
33			$this->promotions = [];
34			$this->total = 0;
			0 ignored issues – show Documentation Bug introduced 2016-01-10 21:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `0` of type `integer` is incompatible with the declared type `array` of property `$total`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
35			}
36
37			/**
38			* @param ItemInterface $item
39			*/
40			public function add(ItemInterface $item)
41			{
42			$this->products[] = $item;
43
44			return $this;
45			}
46
47			/**
48			* @param ItemInterface $item
			0 ignored issues – show Bug introduced 2016-01-10 21:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$item`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
49			*/
50			public function addItems(Collection $collection)
51			{
52			foreach ($collection as $item) {
53			$this->products[] = $item;
54			}
55
56			return $this->products;
57			}
58
59			/**
60			* @param ItemInterface $item
61			*/
62			public function remove(ItemInterface $item)
63			{
64			$this->products[array_search($item, $this->products)] = $item;
65
66			return $this;
67			}
68
69			/**
70			* @return array
71			*/
72			public function clear()
73			{
74			$this->products = [];
75
76			return $this->products;
77			}
78
79			/**
80			* @return array
81			*/
82			public function all()
83			{
84			return $this->products;
85			}
86
87			/**
88			* @return \ArrayIterator
89			*/
90			public function getIterator()
91			{
92			return new \ArrayIterator($this->products);
93			}
94
95			/**
96			* @return \ArrayIterator
97			*/
98			public function count()
99			{
100			return count($this->products);
			0 ignored issues – show Bug Best Practice introduced 2016-01-10 21:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this The return type of `return count($this->products);` (`integer`) is incompatible with the return type declared by the abstract method `App\Http\Cart\AbstractCart::count` of type `ArrayIterator`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
101			}
102
103			/**
104			* Total TTC.
105			*
106			* @param int $taxe
107			*
108			* @return int
109			*/
110			public function total($taxe = 1)
111			{
112			foreach ($this as $movie) {
113			$this->total += $movie->getMovie()->prix;
114			}
115
116			return $this->total * $taxe;
117			}
118
119			/**
120			* @return array
121			*/
122			public function getProducts()
123			{
124			return $this->products;
125			}
126
127			/**
128			* @param array $products
129			*/
130			public function setProducts($products)
131			{
132			$this->products = $products;
133			}
134
135			/**
136			* @return array
137			*/
138			public function getTotal()
139			{
140			return $this->total;
141			}
142
143			/**
144			* @param array $total
145			*/
146			public function setTotal($total)
147			{
148			$this->total = $total;
149			}
150
151			/**
152			* @return array
153			*/
154			public function getPromotions()
155			{
156			return $this->promotions;
157			}
158
159			/**
160			* @param array $promotions
161			*/
162			public function setPromotions($promotions)
163			{
164			$this->promotions = $promotions;
165			}
166
167			/**
168			* @param array $total
			0 ignored issues – show Bug introduced 2016-01-10 21:36 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$total`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
169			*/
170			public function emptycart()
171			{
172			return empty($this->products) ? true : false;
173			}
174			}
175

Symfomany / laravelcinema

Issues (115)

Security Analysis not enabled

app/Http/Cart/Cart.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like