MoviesController::store() - Code Metrics - Inspection of "add changes" - Symfomany/laravelcinema - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Push — master ( 4c949c...532c30 )

by Julien
created 2016-01-12 14:43 UTC
MoviesController::store() B

↳ Parent: MoviesController
Complexity

Conditions	6
Paths	8
Size

Total Lines	53
Code Lines	37
Duplication

Lines	0
Ratio	0 %
Importance

Changes	4
Bugs	0	Features	3
Metric	Value
c	4
b	0
f	3
dl	0
loc	53
rs	8.7155
cc	6
eloc	37
nc	8
nop	1
How to fix Long Method

<?php

namespace App\Http\Controllers;

use App\Http\Models\Actors;
use App\Http\Models\Categories;
use App\Http\Models\Directors;
use App\Http\Models\Movies;
use App\Http\Requests\MoviesRequest;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\Redirect;
use Illuminate\Support\Facades\Session;

/**
 * Class MoviesController
 * @package App\Http\Controllers
 */
class MoviesController extends Controller
{
    /**
     * Page Index
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function index()
    {
        $movies = Movies::all();

        return view('Movies/index', [
                'movies' => $movies,
            ]
        );
    }
    /**
     * Page create
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function create()
    {
        $categories = Categories::all();
        $actors = Actors::all();
        $directors = Directors::all();

        return view('Movies/create',
        [
            'categories' => $categories,
            'actors'     => $actors,
            'directors'  => $directors,
        ]);
    }

    /**
     * Page Read.
     */
    public function read($id)

    {
        return view('Movies/read');
    }

    /**
     * Page Read.
     */
    public function edit($id)
    {
        $categories = Categories::all();
        $actors = Actors::all();
        $directors = Directors::all();

        $movie = Movies::find($id);

        return view('Movies/edit', [
            'movie'      => $movie,
            'categories' => $categories,
            'actors'     => $actors,
            'directors'  => $directors,
        ]);
    }

    /**
     * Action qui va me permettre d'activer un film.
     *
     * @param $id
     */
    public function activate($id)

    {
        $movie = Movies::find($id);

        if ($movie->visible == 0) {
            $movie->visible = 1;
            Session::flash('success', "Le film {$movie->title} a bien été activé");
        } else {
            $movie->visible = 0;
            Session::flash('success', "Le film {$movie->title} a bien été desactivé");
        }

        $movie->save();

        return Redirect::route('movies_index');
    }

    /**
     * Action qui va me permettre de metter en avant un film.
     *
     * @param $id
     */
    public function cover($id)

    {
        $movie = Movies::find($id);

        if ($movie->cover == 0) {
            $movie->cover = 1;
            Session::flash('success', "Le film {$movie->title} a bien été mis en avant");
        } else {
            $movie->cover = 0;
            Session::flash('danger', "Le film {$movie->title} a bien été retiré de l'avant");
        }

        $movie->save();

        return Redirect::route('movies_index');
    }

    /**
     * Suppresion.
     */
    public function delete($id)
    {
        $movie = Movies::find($id);

        if ($movie) {
            Session::flash('success', "Le film {$movie->title} a bien été supprimé");
            $movie->delete();
        }

        return Redirect::route('movies_index');
    }

    /**
     * Fonction de like des films, enregistré en session
     * Session : mécanisme de stockage temporelle
     * BDD: mécanisme de stockage atemporelle.
     *
     * @param Request $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function like($id, $action)
    {
        $movie = Movies::find($id);

        $likes = session('likes', []);

        // si l'action est "like"
        if ($action == 'like') {

            // J'ajoute mon movie dans le tableaux des likes en session
            $likes[$id] = $movie->id;
            Session::flash('danger', "Le film {$movie->title} a bien été liké");
        } else {

            // je supprime le like dans le tableaux des likes
            // unset() supprimer un element dans un tableau en PHP
            unset($likes[$id]);

            Session::flash('success', "Le film {$movie->title} a bien été disliké");
        }

        //j'enregistre en session mon nouveau tableaux des likes
        Session::put('likes', $likes);

        // une redirection avec message flash
        return Redirect::route('movies_index');
    }

    /**
     * Store database.
     */
    public function store(MoviesRequest $request)
    {
        $dateoutput = \DateTime::createFromFormat('d/m/Y', $request->date_release);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie = new Movies();
        $movie->type = $request->type;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->title = $request->title;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->synopsis = $request->synopsis;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->description = $request->description;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->trailer = $request->trailer;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->date_release = $dateoutput;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->visible = $request->visible;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->cover = $request->cover;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->languages = $request->lang;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->categories_id = $request->categories_id;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->note_presse = $request->note_presse;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->distributeur = $request->distributeur;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $filename = '';

        if ($request->hasFile('image')) {
            $file = $request->file('image');
            $filename = $file->getClientOriginalName(); // Récupère le nom original du fichier
            $destinationPath = public_path().'/uploads/movies'; // Indique où stocker le fichier
            $file->move($destinationPath, $filename); // Déplace le fichier
        }

        $movie->image = asset('uploads/movies/'.$filename);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $movie->save();

        $actors = $request->actors;

        if (isset($actors)) {
            foreach ($actors as $actor) {
                DB::table('actors_movies')
                    ->insert([
                        ['movies_id' => $movie->id, 'actors_id' => $actor],
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    ]);
            }
        }

        $directors = $request->directors;

        if (isset($directors)) {
            foreach ($directors as $director) {
                DB::table('directors_movies')
                    ->insert([
                        ['movies_id' => $movie->id, 'directors_id' => $director],
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    ]);
            }
        }

        Session::flash('success', "Le film {$movie->title} a été enregistré");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        return Redirect::route('movies_index');
    }
}

1			<?php
2
3			namespace App\Http\Controllers;
4
5			use App\Http\Models\Actors;
6			use App\Http\Models\Categories;
7			use App\Http\Models\Directors;
8			use App\Http\Models\Movies;
9			use App\Http\Requests\MoviesRequest;
10			use Illuminate\Http\Request;
11			use Illuminate\Support\Facades\DB;
12			use Illuminate\Support\Facades\Redirect;
13			use Illuminate\Support\Facades\Session;
14
15			/**
16			* Class MoviesController
17			* @package App\Http\Controllers
18			*/
19			class MoviesController extends Controller
20			{
21			/**
22			* Page Index
23			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
24			*/
25			public function index()
26			{
27			$movies = Movies::all();
28
29			return view('Movies/index', [
30			'movies' => $movies,
31			]
32			);
33			}
34			/**
35			* Page create
36			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
37			*/
38			public function create()
39			{
40			$categories = Categories::all();
Symfomany / laravelcinema

Push — master ( 4c949c...532c30 )

MoviesController::store() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
