SuperAdminPolicy - Code Metrics - Inspection of "add changes for Maxime" - Symfomany/laravelcinema - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( dd0ca4...f00659 )

by Julien

created 2015-12-15 12:48 UTC

SuperAdminPolicy A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	4
c	1
b	0
f	1
lcom	0
cbo	1
dl	0
loc	35
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	isSuperAdmin()	0	8	2
A	isExpired()	0	10	2

<?php

namespace App\Policies;

use App\Http\Models\Administrators;
use Illuminate\Auth\Access\HandlesAuthorization;

/**
 * Class SuperAdminPolicy
 * @package App\Policies
 */
class SuperAdminPolicy
{

    use HandlesAuthorization;

    /**
     * Determine if the given post can be updated by the user.
     * @return bool
     */
    public function isSuperAdmin(Administrators $administrator)
    {
        if($administrator->super_admin == true){
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return true;
        }else{
            return false;
        }
    }


    /**
     * Determine if the given post can be updated by the user.
     * @return bool
     */
    public function isExpired(Administrators $administrator)
    {

        // si j'ai expiration au niveau des date d'expiratio n
        if($administrator->expiration_date > date('Y-m-d')){
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            return true;
        }else{
            return false;
        }
    }

}


1			<?php
2
3			namespace App\Policies;
4
5			use App\Http\Models\Administrators;
6			use Illuminate\Auth\Access\HandlesAuthorization;
7
8			/**
9			* Class SuperAdminPolicy
10			* @package App\Policies
11			*/
12			class SuperAdminPolicy
13			{
14
15			use HandlesAuthorization;
16
17			/**
18			* Determine if the given post can be updated by the user.
19			* @return bool
20			*/
21			public function isSuperAdmin(Administrators $administrator)
22			{
23			if($administrator->super_admin == true){
			0 ignored issues – show Documentation introduced 2015-12-15 12:51 UTC by Report Bug Copy Issue Report The property `super_admin` does not exist on `object<App\Http\Models\Administrators>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
24			return true;
25			}else{
26			return false;
27			}
28			}
29
30
31			/**
32			* Determine if the given post can be updated by the user.
33			* @return bool
34			*/
35			public function isExpired(Administrators $administrator)
36			{
37
38			// si j'ai expiration au niveau des date d'expiratio n
39			if($administrator->expiration_date > date('Y-m-d')){
			0 ignored issues – show Documentation introduced 2015-12-15 12:51 UTC by Report Bug Copy Issue Report The property `expiration_date` does not exist on `object<App\Http\Models\Administrators>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
40			return true;
41			}else{
42			return false;
43			}
44			}
45
46			}
47

Symfomany / laravelcinema

Push — master ( dd0ca4...f00659 )

SuperAdminPolicy A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like