| Conditions | 2 |
| Paths | 2 |
| Total Lines | 100 |
| Code Lines | 16 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 2 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 169 | public function store(MoviesRequest $request){ |
||
| 170 | |||
| 171 | //crée un objet qui représente mon nouveau film |
||
| 172 | $movie = new Movies(); |
||
| 173 | $movie->type = $request->type; |
||
| 174 | $movie->title = $request->title; |
||
| 175 | $movie->synopsis = $request->synopsis; |
||
| 176 | $movie->description = $request->description; |
||
| 177 | |||
| 178 | |||
| 179 | /* Traitement de l'upload d'image */ |
||
| 180 | $filename = ""; |
||
| 181 | |||
| 182 | // Si j'ai un fichier "image" |
||
| 183 | if($request->hasFile('image')) { |
||
| 184 | |||
| 185 | // je récupere mon fichier |
||
| 186 | $file = $request->file('image'); |
||
| 187 | |||
| 188 | // je récupere le nom du fichier |
||
| 189 | $filename = $file->getClientOriginalName(); // Récupère le nom original du fichier |
||
| 190 | |||
| 191 | // je stocker le chemin vers lequele mon image va etre envoyé |
||
| 192 | $destinationPath = public_path() . '/uploads/movies'; // Indique où stocker le fichier |
||
| 193 | |||
| 194 | // je bouge mon fichier uploadé |
||
| 195 | $file->move($destinationPath, $filename); // Déplace le fichier |
||
| 196 | } |
||
| 197 | |||
| 198 | //je renseigne le nom de mon image pour mon film |
||
| 199 | $movie->image = asset("uploads/movies/". $filename); |
||
| 200 | |||
| 201 | |||
| 202 | //sauevegarder mon objet Movies en BDD |
||
| 203 | $movie->save(); |
||
| 204 | |||
| 205 | |||
| 206 | |||
| 207 | |||
| 208 | // je cére un message flash |
||
| 209 | Session::flash('success', "Le film {$movie->title} a été enregistré"); |
||
| 210 | |||
| 211 | // redirection vers movies_index |
||
| 212 | return Redirect::route('movies_index'); |
||
| 213 | |||
| 214 | |||
| 215 | // $movie->trailer = $request->trailer; |
||
| 216 | // $movie->categories_id = $request->categories_id; |
||
| 217 | // $movie->languages = $request->lang; |
||
| 218 | // $movie->distributeur = $request->distributeur; |
||
| 219 | // $movie->bo = $request->bo; |
||
| 220 | // $movie->annee = $request->annee; |
||
| 221 | // $movie->budget = $request->budget; |
||
| 222 | // $movie->duree = $request->duree; |
||
| 223 | // $movie->date_release = $request->date_release; |
||
| 224 | // $movie->note_presse = $request->note_presse; |
||
| 225 | // $movie->visible = $request->visible; |
||
| 226 | // $movie->cover = $request->cover; |
||
| 227 | // |
||
| 228 | // |
||
| 229 | // /* Traitement de l'upload d'image */ |
||
| 230 | // $filename = ""; |
||
| 231 | // if($request->hasFile('image')) { |
||
| 232 | // $file = $request->file('image'); |
||
| 233 | // $filename = $file->getClientOriginalName(); // Récupère le nom original du fichier |
||
| 234 | // $destinationPath = public_path() . '/uploads/movies'; // Indique où stocker le fichier |
||
| 235 | // $file->move($destinationPath, $filename); // Déplace le fichier |
||
| 236 | // } |
||
| 237 | // $movie->image = asset("uploads/movies/". $filename); |
||
| 238 | // |
||
| 239 | // $movie->save(); |
||
| 240 | // |
||
| 241 | // |
||
| 242 | // // Traitement des champs de la relations Actors_Movies |
||
| 243 | // $actors = $request->actors; |
||
| 244 | // if (isset($actors)) { |
||
| 245 | // foreach ($actors as $actor) { |
||
| 246 | // DB::table('actors_movies') |
||
| 247 | // ->insert([ |
||
| 248 | // ['movies_id' => $movie->id, 'actors_id' => $actor] |
||
| 249 | // ]); |
||
| 250 | // } |
||
| 251 | // } |
||
| 252 | // |
||
| 253 | // // Traitement des champs de la relations Directors_Movies |
||
| 254 | // $directors = $request->directors; |
||
| 255 | // if (isset($directors)) { |
||
| 256 | // foreach ($directors as $director) { |
||
| 257 | // DB::table('directors_movies') |
||
| 258 | // ->insert([ |
||
| 259 | // ['movies_id' => $movie->id, 'directors_id' => $director] |
||
| 260 | // ]); |
||
| 261 | // } |
||
| 262 | // } |
||
| 263 | // |
||
| 264 | // |
||
| 265 | // Session::flash('success', "Le film $movie->title a été enregistré"); |
||
| 266 | // |
||
| 267 | // return Redirect::route('movies_index'); |
||
| 268 | } |
||
| 269 | |||
| 290 |
This check looks from parameters that have been defined for a function or method, but which are not used in the method body.