admin_controller::__construct() - Code Metrics - Inspection of "Add files via upload" - Sylver35/smiliescat - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 1.3.0 ( 7a4e4b...8f251a )

by Sylver

created 2020-08-28 19:48 UTC

admin_controller::__construct() A

↳ Parent: admin_controller

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	11
c	1
b	0
f	0
nc	1
nop	11
dl	0
loc	13
rs	9.9

How to fix Many Parameters

<?php
/**
*
* @package		Breizh Smilies Categories Extension
* @copyright	(c) 2020 Sylver35  https://breizhcode.com
* @license		http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/

namespace sylver35\smiliescat\controller;

use sylver35\smiliescat\core\category;
use phpbb\config\config;
use phpbb\db\driver\driver_interface as db;
use phpbb\pagination;
use phpbb\request\request;
use phpbb\template\template;
use phpbb\user;
use phpbb\language\language;
use phpbb\log\log;

class admin_controller
{
	/* @var \sylver35\smiliescat\core\category */
	protected $category;

	/** @var \phpbb\config\config */
	protected $config;

	/** @var \phpbb\db\driver\driver_interface */
	protected $db;

	/** @var \phpbb\pagination */
	protected $pagination;

	/** @var \phpbb\request\request */
	protected $request;

	/** @var \phpbb\template\template */
	protected $template;

	/** @var \phpbb\user */
	protected $user;

	/** @var \phpbb\language\language */
	protected $language;

	/** @var \phpbb\log\log */
	protected $log;

	/** @var string phpBB root path */
	protected $root_path;

	/** @var string Custom form action */
	protected $u_action;

	/**
	 * The database tables
	 *
	 * @var string */
	protected $smilies_category_table;

	/**
	 * Constructor
	 */
	public function __construct(category $category, config $config, db $db, pagination $pagination, request $request, template $template, user $user, language $language, log $log, $root_path, $smilies_category_table)
	{
		$this->category = $category;
		$this->config = $config;
		$this->db = $db;
		$this->pagination = $pagination;
		$this->request = $request;
		$this->template = $template;
		$this->user = $user;
		$this->language = $language;
		$this->log = $log;
		$this->root_path = $root_path;
		$this->smilies_category_table = $smilies_category_table;
	}

	public function acp_smilies_category()
	{
		$this->language->add_lang('acp/posting');
		$action = (string) $this->request->variable('action', '');
		$start = (int) $this->request->variable('start', 0);
		$select = (int) $this->request->variable('select', -1);
		$id = (int) $this->request->variable('id', -1);
		$form_key = 'sylver35/smiliescat';
		add_form_key($form_key);

		if ($action)
		{
			switch ($action)
			{
				case 'edit':

					$this->category->adm_edit_smiley($id, $this->u_action, $start);

				break;

				case 'modify':

					if (!check_form_key($form_key))
					{
						trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
					}

					$cat_id = (int) $this->request->variable('cat_id', 0);
					$ex_cat = (int) $this->request->variable('ex_cat', 0);

					$sql = 'UPDATE ' . SMILIES_TABLE . " SET category = $cat_id WHERE smiley_id = $id";
					$this->db->sql_query($sql);

					// Decrement nb value if wanted
					if ($ex_cat !== 0)
					{
						$sql = 'UPDATE ' . $this->smilies_category_table . " SET cat_nb = cat_nb - 1 WHERE cat_id = $ex_cat";
						$this->db->sql_query($sql);
					}
					// Increment nb value if wanted
					if ($cat_id !== 0)
					{
						$sql = 'UPDATE ' . $this->smilies_category_table . " SET cat_nb = cat_nb + 1 WHERE cat_id = $cat_id";
						$this->db->sql_query($sql);
					}

					trigger_error($this->language->lang('SMILIES_EDITED', 1) . adm_back_link($this->u_action . '&amp;start=' . $start . '#acp_smilies_category'));

				break;
			}

			$this->template->assign_vars(array(
				'IN_ACTION'			=> true,
			));
		}
		else
		{
			$this->extract_list_smilies($select, $start);

			$this->template->assign_vars(array(
				'LIST_CATEGORY'		=> $this->category->select_categories($select, true),
				'U_BACK'			=> ($select) ? $this->u_action : '',
				'U_SELECT_CAT'		=> $this->u_action . '&amp;select=' . $select,
			));
		}

		$this->template->assign_vars(array(
			'CATEGORIE_SMILIES'		=> true,
		));
	}

	public function acp_categories_config()
	{
		$this->language->add_lang('acp/language');
		$mode = (string) $this->request->variable('mode', '');
		$action = (string) $this->request->variable('action', '');
		$id = (int) $this->request->variable('id', 0);
		$form_key = 'sylver35/smiliescat';
		add_form_key($form_key);

		if ($action)
		{
			if (in_array($action, array('config_cat', 'add_cat', 'edit_cat')) && !check_form_key($form_key))
			{
				trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
			}

			switch ($action)
			{
				case 'config_cat':

					$this->config->set('smilies_per_page_cat', (int) $this->request->variable('smilies_per_page_cat', 15));

					$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_CONFIG', time());
					trigger_error($this->language->lang('CONFIG_UPDATED') . adm_back_link($this->u_action));

				break;

				case 'add':

					$this->category->adm_add_cat($this->u_action);

				break;

				case 'add_cat':

					$this->add_category();

				break;

				case 'edit':

					$this->category->adm_edit_cat($id, $this->u_action);

				break;

				case 'edit_cat':

					$this->edit_category($id);

				break;

				case 'move_up':
				case 'move_down':
					
					$this->move_cat($action, $id);

				break;

				case 'delete':

					if (confirm_box(true))
					{
						$this->delete_cat($id);
					}
					else
					{
						confirm_box(false, $this->language->lang('CONFIRM_OPERATION'), build_hidden_fields(array(
							'mode'		=> $mode,
							'id'		=> $id,
							'action'	=> 'delete',
						)));
					}

				break;
				
			}

			$this->template->assign_vars(array(
				'IN_ACTION'		=> true,
			));
		}
		else
		{
			$this->category->adm_list_cat($this->u_action);
		}

		$this->template->assign_vars(array(
			'CATEGORIE_CONFIG'		=> true,
			'SMILIES_PER_PAGE_CAT'	=> $this->config['smilies_per_page_cat'],
			'U_ACTION_CONFIG'		=> $this->u_action . '&amp;action=config_cat',
			'U_ADD'					=> $this->u_action . '&amp;action=add',
		));
	}

	private function move_cat($action, $id)
	{
		$id = (int) $id;
		// Get current order id and title...
		$sql = 'SELECT cat_order, cat_title
			FROM ' . $this->smilies_category_table . '
				WHERE cat_id = ' . $id;
		$result = $this->db->sql_query($sql);
		$row = $this->db->sql_fetchrow($result);
		$current_order = (int) $row['cat_order'];
		$title = $row['cat_title'];
		$this->db->sql_freeresult($result);

		$switch_order_id = $this->set_order($action, $current_order);
		if ($switch_order_id === 0)
		{
			return;
		}

		$sql = 'UPDATE ' . $this->smilies_category_table . "
			SET cat_order = $current_order
			WHERE cat_order = $switch_order_id
				AND cat_id <> $id";
		$this->db->sql_query($sql);
		$move_executed = (bool) $this->db->sql_affectedrows();

		// Only update the other entry too if the previous entry got updated
		if ($move_executed)
		{
			$sql = 'UPDATE ' . $this->smilies_category_table . "
				SET cat_order = $switch_order_id
				WHERE cat_order = $current_order
					AND cat_id = $id";
			$this->db->sql_query($sql);
		}

		$this->category->reset_first_cat((int) $current_order, (int) $switch_order_id);
		$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_' . strtoupper($action) . '_CAT', time(), array($title));

		trigger_error($this->language->lang('SC_MOVE_SUCCESS') . adm_back_link($this->u_action));
	}

	private function set_order($action, $current_order)
	{
		$switch_order_id = 0;
		if ($current_order === 1 && $action === 'move_up')
		{
			return $switch_order_id;
		}

		$max_order = (int) $this->category->get_max_order();

		if (($current_order === $max_order) && ($action === 'move_down'))
		{
			return $switch_order_id;
		}

		// on move_down, switch position with next order_id...
		// on move_up, switch position with previous order_id...
		$switch_order_id = ($action === 'move_down') ? $current_order + 1 : $current_order - 1;

		return $switch_order_id;
	}

	private function extract_list_smilies($select, $start)
	{
		$i = 0;
		$cat = -1;
		$lang = $this->user->lang_name;
		$smilies_count = (int) $this->category->smilies_count($select);

		if ($select === 0)
		{
			$sql = $this->db->sql_build_query('SELECT', array(
				'SELECT'	=> '*',
				'FROM'		=> array(SMILIES_TABLE => ''),
				'WHERE'		=> 'category = 0',
				'ORDER_BY'	=> 'smiley_order ASC',
			));
		}
		else
		{
			$sql = $this->db->sql_build_query('SELECT', array(
				'SELECT'	=> 's.*, c.*',
				'FROM'		=> array(SMILIES_TABLE => 's'),
				'LEFT_JOIN'	=> array(
					array(
						'FROM'	=> array($this->smilies_category_table => 'c'),
						'ON'	=> "cat_id = category AND cat_lang = '$lang'",
					),
				),
				'WHERE'		=> ($select == -1) ? "code <> ''" : "cat_id = $select AND code <> ''",
				'ORDER_BY'	=> 'cat_order ASC, smiley_order ASC',
			));
		}
		$result = $this->db->sql_query_limit($sql, (int) $this->config['smilies_per_page_cat'], $start);
		while ($row = $this->db->sql_fetchrow($result))
		{
			$row['category'] = isset($row['category']) ? $row['category'] : 0;
			$row['cat_name'] = ($row['category']) ? $row['cat_name'] : $this->language->lang('SC_CATEGORY_DEFAUT');

			$this->template->assign_block_vars('items', array(
				'SPACER_CAT'	=> ($cat !== (int) $row['category']) ? $this->language->lang('SC_CATEGORY_IN', $row['cat_name']) : '',
				'IMG_SRC'		=> $row['smiley_url'],
				'WIDTH'			=> $row['smiley_width'],
				'HEIGHT'		=> $row['smiley_height'],
				'CODE'			=> $row['code'],
				'EMOTION'		=> $row['emotion'],
				'CATEGORY'		=> $row['cat_name'],
				'U_EDIT'		=> $this->u_action . '&amp;action=edit&amp;id=' . $row['smiley_id'] . '&amp;start=' . $start,
			));
			$i++;

			// Keep this value in memory
			$cat = (int) $row['category'];
		}
		$this->db->sql_freeresult($result);

		$this->template->assign_vars(array(
			'NB_SMILIES'	=> $smilies_count,
			'U_SMILIES'		=> $this->root_path . $this->config['smilies_path'] . '/',
		));

		$this->pagination->generate_template_pagination($this->u_action . '&amp;select=' . $select, 'pagination', 'start', $smilies_count, (int) $this->config['smilies_per_page_cat'], $start);
	}

	private function delete_cat($id)
	{
		$id = (int) $id;
		$sql = 'SELECT cat_title, cat_order
			FROM ' . $this->smilies_category_table . '
				WHERE cat_id = ' . $id;
		$result = $this->db->sql_query($sql);
		$row = $this->db->sql_fetchrow($result);
		$title = $row['cat_title'];
		$order = $row['cat_order'];
		$this->db->sql_freeresult($result);

		$sql_delete = 'DELETE FROM ' . $this->smilies_category_table . ' WHERE cat_id = ' . $id;
		$this->db->sql_query($sql_delete);

		// Decrement orders if needed
		$sql_decrement = 'SELECT cat_id, cat_order
			FROM ' . $this->smilies_category_table . '
				WHERE cat_order > ' . (int) $order;
		$result = $this->db->sql_query($sql_decrement);
		while ($row = $this->db->sql_fetchrow($result))
		{
			$new_order = (int) $row['cat_order'] - 1;
			$sql_order = 'UPDATE ' . $this->smilies_category_table . '
				SET cat_order = ' . $new_order . '
					WHERE cat_id = ' . $row['cat_id'] . ' AND cat_order = ' . $row['cat_order'];
			$this->db->sql_query($sql_order);
		}
		$this->db->sql_freeresult($result);

		// Reset appropriate smilies category id
		$sql_update = 'UPDATE ' . SMILIES_TABLE . ' SET category = 0 WHERE category = ' . $id;
		$this->db->sql_query($sql_update);

		$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_DELETE_CAT', time(), array($title));

		trigger_error($this->language->lang('SC_DELETE_SUCCESS') . adm_back_link($this->u_action));
	}

	private function add_category()
	{
		$title = $this->request->variable('name_' . $this->user->lang_name, '', true);
		$cat_order = (int) $this->request->variable('order', 0);
		$cat_id = (int) $this->category->get_max_id() + 1;
		$sql_in = array();
		$i = 0;

		$sql = 'SELECT lang_id, lang_iso
			FROM ' . LANG_TABLE . "
				ORDER BY lang_id ASC";
		$result = $this->db->sql_query($sql);
		while ($row = $this->db->sql_fetchrow($result))
		{
			$iso = $row['lang_iso'];
			$lang = (string) $this->request->variable("lang_$iso", '', true);
			$name = (string) $this->request->variable("name_$iso", '', true);
			if ($name === '')
			{
				trigger_error($this->language->lang('SC_CATEGORY_ERROR') . adm_back_link($this->u_action . '&amp;action=add'), E_USER_WARNING);
			}
			else
			{
				$sql_in[$i] = array(
					'cat_id'		=> $cat_id,
					'cat_order'		=> $cat_order,
					'cat_lang'		=> $lang,
					'cat_name'		=> $this->category->capitalize($name),
					'cat_title'		=> $this->category->capitalize($title),
				);
			}
			$i++;
		}

		for ($j = 0; $j < $i; $j++)
		{
			$this->db->sql_query('INSERT INTO ' . $this->smilies_category_table . $this->db->sql_build_array('INSERT', $sql_in[$j]));
		}

		if ($cat_order === 1)
		{
			$this->config->set('smilies_category_nb', $cat_id);
		}

		$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_ADD_CAT', time(), array($title));
		trigger_error($this->language->lang('SC_CREATE_SUCCESS') . adm_back_link($this->u_action));
	}

	private function edit_category($id)
	{
		$id = (int) $id;
		$title = $this->category->capitalize($this->request->variable('name_' . $this->user->lang_name, '', true));

		$sql = 'SELECT lang_id, lang_iso
			FROM ' . LANG_TABLE . "
				ORDER BY lang_id ASC";
		$result = $this->db->sql_query($sql);
		while ($row = $this->db->sql_fetchrow($result))
		{
			$iso = $row['lang_iso'];
			$lang = (string) $this->request->variable("lang_$iso", '', true);
			$sort = (string) $this->request->variable("sort_$iso", '');
			$order = (int) $this->request->variable('order', 0);
			$name = $this->category->capitalize($this->request->variable("name_$iso", '', true));
			if ($name === '')
			{
				trigger_error($this->language->lang('SC_CATEGORY_ERROR') . adm_back_link($this->u_action . '&amp;action=edit&amp;id=' . $id), E_USER_WARNING);
			}
			else
			{
				if ($sort === 'edit')
				{
					$sql = 'UPDATE ' . $this->smilies_category_table . "
						SET cat_name = '" . $name . "', cat_title = '" . $title . "'
							WHERE cat_lang = '" . $this->db->sql_escape($lang) . "'
							AND cat_id = $id";
					$this->db->sql_query($sql);
				}
				else if ($sort === 'create')
				{
					$sql_in = array(
						'cat_id'		=> $id,
						'cat_order'		=> $order,
						'cat_lang'		=> $lang,
						'cat_name'		=> $name,
						'cat_title'		=> $title,
					);
					$this->db->sql_query('INSERT INTO ' . $this->smilies_category_table . $this->db->sql_build_array('INSERT', $sql_in));
				}
			}
		}

		$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_EDIT_CAT', time(), array($title));
		trigger_error($this->language->lang('SC_EDIT_SUCCESS') . adm_back_link($this->u_action));
	}

	/**
	 * Set page url
	 *
	 * @param string $u_action Custom form action
	 * @return null
	 * @access public
	 */
	public function set_page_url($u_action)
	{
		$this->u_action = $u_action;
	}
}


1			<?php
2			/**
3			*
4			* @package Breizh Smilies Categories Extension
5			* @copyright (c) 2020 Sylver35 https://breizhcode.com
6			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
7			*
8			*/
9
10			namespace sylver35\smiliescat\controller;
11
12			use sylver35\smiliescat\core\category;
13			use phpbb\config\config;
14			use phpbb\db\driver\driver_interface as db;
15			use phpbb\pagination;
16			use phpbb\request\request;
17			use phpbb\template\template;
18			use phpbb\user;
19			use phpbb\language\language;
20			use phpbb\log\log;
21
22			class admin_controller
23			{
24			/* @var \sylver35\smiliescat\core\category */
25			protected $category;
26
27			/** @var \phpbb\config\config */
28			protected $config;
29
30			/** @var \phpbb\db\driver\driver_interface */
31			protected $db;
32
33			/** @var \phpbb\pagination */
34			protected $pagination;
35
36			/** @var \phpbb\request\request */
37			protected $request;
38
39			/** @var \phpbb\template\template */
40			protected $template;
41
42			/** @var \phpbb\user */
43			protected $user;
44
45			/** @var \phpbb\language\language */
46			protected $language;
47
48			/** @var \phpbb\log\log */
49			protected $log;
50
51			/** @var string phpBB root path */
52			protected $root_path;
53
54			/** @var string Custom form action */
55			protected $u_action;
56
57			/**
58			* The database tables
59			*
60			* @var string */
61			protected $smilies_category_table;
62
63			/**
64			* Constructor
65			*/
66			public function __construct(category $category, config $config, db $db, pagination $pagination, request $request, template $template, user $user, language $language, log $log, $root_path, $smilies_category_table)
67			{
68			$this->category = $category;
69			$this->config = $config;
70			$this->db = $db;
71			$this->pagination = $pagination;
72			$this->request = $request;
73			$this->template = $template;
74			$this->user = $user;
75			$this->language = $language;
76			$this->log = $log;
77			$this->root_path = $root_path;
78			$this->smilies_category_table = $smilies_category_table;
79			}
80
81			public function acp_smilies_category()
82			{
83			$this->language->add_lang('acp/posting');
84			$action = (string) $this->request->variable('action', '');
85			$start = (int) $this->request->variable('start', 0);
86			$select = (int) $this->request->variable('select', -1);
87			$id = (int) $this->request->variable('id', -1);
88			$form_key = 'sylver35/smiliescat';
89			add_form_key($form_key);
90
91			if ($action)
92			{
93			switch ($action)
94			{
95			case 'edit':
96
97			$this->category->adm_edit_smiley($id, $this->u_action, $start);
98
99			break;
100
101			case 'modify':
102
103			if (!check_form_key($form_key))
104			{
105			trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
106			}
107
108			$cat_id = (int) $this->request->variable('cat_id', 0);
109			$ex_cat = (int) $this->request->variable('ex_cat', 0);
110
111			$sql = 'UPDATE ' . SMILIES_TABLE . " SET category = $cat_id WHERE smiley_id = $id";
112			$this->db->sql_query($sql);
113
114			// Decrement nb value if wanted
115			if ($ex_cat !== 0)
116			{
117			$sql = 'UPDATE ' . $this->smilies_category_table . " SET cat_nb = cat_nb - 1 WHERE cat_id = $ex_cat";
118			$this->db->sql_query($sql);
119			}
120			// Increment nb value if wanted
121			if ($cat_id !== 0)
122			{
123			$sql = 'UPDATE ' . $this->smilies_category_table . " SET cat_nb = cat_nb + 1 WHERE cat_id = $cat_id";
124			$this->db->sql_query($sql);
125			}
126
127			trigger_error($this->language->lang('SMILIES_EDITED', 1) . adm_back_link($this->u_action . '&start=' . $start . '#acp_smilies_category'));
128
129			break;
130			}
131
132			$this->template->assign_vars(array(
133			'IN_ACTION' => true,
134			));
135			}
136			else
137			{
138			$this->extract_list_smilies($select, $start);
139
140			$this->template->assign_vars(array(
141			'LIST_CATEGORY' => $this->category->select_categories($select, true),
142			'U_BACK' => ($select) ? $this->u_action : '',
143			'U_SELECT_CAT' => $this->u_action . '&select=' . $select,
144			));
145			}
146
147			$this->template->assign_vars(array(
148			'CATEGORIE_SMILIES' => true,
149			));
150			}
151
152			public function acp_categories_config()
153			{
154			$this->language->add_lang('acp/language');
155			$mode = (string) $this->request->variable('mode', '');
156			$action = (string) $this->request->variable('action', '');
157			$id = (int) $this->request->variable('id', 0);
158			$form_key = 'sylver35/smiliescat';
159			add_form_key($form_key);
160
161			if ($action)
162			{
163			if (in_array($action, array('config_cat', 'add_cat', 'edit_cat')) && !check_form_key($form_key))
164			{
165			trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
166			}
167
168			switch ($action)
169			{
170			case 'config_cat':
171
172			$this->config->set('smilies_per_page_cat', (int) $this->request->variable('smilies_per_page_cat', 15));
173
174			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_CONFIG', time());
175			trigger_error($this->language->lang('CONFIG_UPDATED') . adm_back_link($this->u_action));
176
177			break;
178
179			case 'add':
180
181			$this->category->adm_add_cat($this->u_action);
182
183			break;
184
185			case 'add_cat':
186
187			$this->add_category();
188
189			break;
190
191			case 'edit':
192
193			$this->category->adm_edit_cat($id, $this->u_action);
194
195			break;
196
197			case 'edit_cat':
198
199			$this->edit_category($id);
200
201			break;
202
203			case 'move_up':
204			case 'move_down':
205
206			$this->move_cat($action, $id);
207
208			break;
209
210			case 'delete':
211
212			if (confirm_box(true))
213			{
214			$this->delete_cat($id);
215			}
216			else
217			{
218			confirm_box(false, $this->language->lang('CONFIRM_OPERATION'), build_hidden_fields(array(
219			'mode' => $mode,
220			'id' => $id,
221			'action' => 'delete',
222			)));
223			}
224
225			break;
226
227			}
228
229			$this->template->assign_vars(array(
230			'IN_ACTION' => true,
231			));
232			}
233			else
234			{
235			$this->category->adm_list_cat($this->u_action);
236			}
237
238			$this->template->assign_vars(array(
239			'CATEGORIE_CONFIG' => true,
240			'SMILIES_PER_PAGE_CAT' => $this->config['smilies_per_page_cat'],
241			'U_ACTION_CONFIG' => $this->u_action . '&action=config_cat',
242			'U_ADD' => $this->u_action . '&action=add',
243			));
244			}
245
246			private function move_cat($action, $id)
247			{
248			$id = (int) $id;
249			// Get current order id and title...
250			$sql = 'SELECT cat_order, cat_title
251			FROM ' . $this->smilies_category_table . '
252			WHERE cat_id = ' . $id;
253			$result = $this->db->sql_query($sql);
254			$row = $this->db->sql_fetchrow($result);
255			$current_order = (int) $row['cat_order'];
256			$title = $row['cat_title'];
257			$this->db->sql_freeresult($result);
258
259			$switch_order_id = $this->set_order($action, $current_order);
260			if ($switch_order_id === 0)
261			{
262			return;
263			}
264
265			$sql = 'UPDATE ' . $this->smilies_category_table . "
266			SET cat_order = $current_order
267			WHERE cat_order = $switch_order_id
268			AND cat_id <> $id";
269			$this->db->sql_query($sql);
270			$move_executed = (bool) $this->db->sql_affectedrows();
271
272			// Only update the other entry too if the previous entry got updated
273			if ($move_executed)
274			{
275			$sql = 'UPDATE ' . $this->smilies_category_table . "
276			SET cat_order = $switch_order_id
277			WHERE cat_order = $current_order
278			AND cat_id = $id";
279			$this->db->sql_query($sql);
280			}
281
282			$this->category->reset_first_cat((int) $current_order, (int) $switch_order_id);
283			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_' . strtoupper($action) . '_CAT', time(), array($title));
284
285			trigger_error($this->language->lang('SC_MOVE_SUCCESS') . adm_back_link($this->u_action));
286			}
287
288			private function set_order($action, $current_order)
289			{
290			$switch_order_id = 0;
291			if ($current_order === 1 && $action === 'move_up')
292			{
293			return $switch_order_id;
294			}
295
296			$max_order = (int) $this->category->get_max_order();
297
298			if (($current_order === $max_order) && ($action === 'move_down'))
299			{
300			return $switch_order_id;
301			}
302
303			// on move_down, switch position with next order_id...
304			// on move_up, switch position with previous order_id...
305			$switch_order_id = ($action === 'move_down') ? $current_order + 1 : $current_order - 1;
306
307			return $switch_order_id;
308			}
309
310			private function extract_list_smilies($select, $start)
311			{
312			$i = 0;
313			$cat = -1;
314			$lang = $this->user->lang_name;
315			$smilies_count = (int) $this->category->smilies_count($select);
316
317			if ($select === 0)
318			{
319			$sql = $this->db->sql_build_query('SELECT', array(
320			'SELECT' => '*',
321			'FROM' => array(SMILIES_TABLE => ''),
322			'WHERE' => 'category = 0',
323			'ORDER_BY' => 'smiley_order ASC',
324			));
325			}
326			else
327			{
328			$sql = $this->db->sql_build_query('SELECT', array(
329			'SELECT' => 's., c.',
330			'FROM' => array(SMILIES_TABLE => 's'),
331			'LEFT_JOIN' => array(
332			array(
333			'FROM' => array($this->smilies_category_table => 'c'),
334			'ON' => "cat_id = category AND cat_lang = '$lang'",
335			),
336			),
337			'WHERE' => ($select == -1) ? "code <> ''" : "cat_id = $select AND code <> ''",
338			'ORDER_BY' => 'cat_order ASC, smiley_order ASC',
339			));
340			}
341			$result = $this->db->sql_query_limit($sql, (int) $this->config['smilies_per_page_cat'], $start);
342			while ($row = $this->db->sql_fetchrow($result))
343			{
344			$row['category'] = isset($row['category']) ? $row['category'] : 0;
345			$row['cat_name'] = ($row['category']) ? $row['cat_name'] : $this->language->lang('SC_CATEGORY_DEFAUT');
346
347			$this->template->assign_block_vars('items', array(
348			'SPACER_CAT' => ($cat !== (int) $row['category']) ? $this->language->lang('SC_CATEGORY_IN', $row['cat_name']) : '',
349			'IMG_SRC' => $row['smiley_url'],
350			'WIDTH' => $row['smiley_width'],
351			'HEIGHT' => $row['smiley_height'],
352			'CODE' => $row['code'],
353			'EMOTION' => $row['emotion'],
354			'CATEGORY' => $row['cat_name'],
355			'U_EDIT' => $this->u_action . '&action=edit&id=' . $row['smiley_id'] . '&start=' . $start,
356			));
357			$i++;
358
359			// Keep this value in memory
360			$cat = (int) $row['category'];
361			}
362			$this->db->sql_freeresult($result);
363
364			$this->template->assign_vars(array(
365			'NB_SMILIES' => $smilies_count,
366			'U_SMILIES' => $this->root_path . $this->config['smilies_path'] . '/',
367			));
368
369			$this->pagination->generate_template_pagination($this->u_action . '&select=' . $select, 'pagination', 'start', $smilies_count, (int) $this->config['smilies_per_page_cat'], $start);
370			}
371
372			private function delete_cat($id)
373			{
374			$id = (int) $id;
375			$sql = 'SELECT cat_title, cat_order
376			FROM ' . $this->smilies_category_table . '
377			WHERE cat_id = ' . $id;
378			$result = $this->db->sql_query($sql);
379			$row = $this->db->sql_fetchrow($result);
380			$title = $row['cat_title'];
381			$order = $row['cat_order'];
382			$this->db->sql_freeresult($result);
383
384			$sql_delete = 'DELETE FROM ' . $this->smilies_category_table . ' WHERE cat_id = ' . $id;
385			$this->db->sql_query($sql_delete);
386
387			// Decrement orders if needed
388			$sql_decrement = 'SELECT cat_id, cat_order
389			FROM ' . $this->smilies_category_table . '
390			WHERE cat_order > ' . (int) $order;
391			$result = $this->db->sql_query($sql_decrement);
392			while ($row = $this->db->sql_fetchrow($result))
393			{
394			$new_order = (int) $row['cat_order'] - 1;
395			$sql_order = 'UPDATE ' . $this->smilies_category_table . '
396			SET cat_order = ' . $new_order . '
397			WHERE cat_id = ' . $row['cat_id'] . ' AND cat_order = ' . $row['cat_order'];
398			$this->db->sql_query($sql_order);
399			}
400			$this->db->sql_freeresult($result);
401
402			// Reset appropriate smilies category id
403			$sql_update = 'UPDATE ' . SMILIES_TABLE . ' SET category = 0 WHERE category = ' . $id;
404			$this->db->sql_query($sql_update);
405
406			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_DELETE_CAT', time(), array($title));
407
408			trigger_error($this->language->lang('SC_DELETE_SUCCESS') . adm_back_link($this->u_action));
409			}
410
411			private function add_category()
412			{
413			$title = $this->request->variable('name_' . $this->user->lang_name, '', true);
414			$cat_order = (int) $this->request->variable('order', 0);
415			$cat_id = (int) $this->category->get_max_id() + 1;
416			$sql_in = array();
417			$i = 0;
418
419			$sql = 'SELECT lang_id, lang_iso
420			FROM ' . LANG_TABLE . "
421			ORDER BY lang_id ASC";
422			$result = $this->db->sql_query($sql);
423			while ($row = $this->db->sql_fetchrow($result))
424			{
425			$iso = $row['lang_iso'];
426			$lang = (string) $this->request->variable("lang_$iso", '', true);
427			$name = (string) $this->request->variable("name_$iso", '', true);
428			if ($name === '')
429			{
430			trigger_error($this->language->lang('SC_CATEGORY_ERROR') . adm_back_link($this->u_action . '&action=add'), E_USER_WARNING);
431			}
432			else
433			{
434			$sql_in[$i] = array(
435			'cat_id' => $cat_id,
436			'cat_order' => $cat_order,
437			'cat_lang' => $lang,
438			'cat_name' => $this->category->capitalize($name),
439			'cat_title' => $this->category->capitalize($title),
440			);
441			}
442			$i++;
443			}
444
445			for ($j = 0; $j < $i; $j++)
446			{
447			$this->db->sql_query('INSERT INTO ' . $this->smilies_category_table . $this->db->sql_build_array('INSERT', $sql_in[$j]));
448			}
449
450			if ($cat_order === 1)
451			{
452			$this->config->set('smilies_category_nb', $cat_id);
453			}
454
455			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_ADD_CAT', time(), array($title));
456			trigger_error($this->language->lang('SC_CREATE_SUCCESS') . adm_back_link($this->u_action));
457			}
458
459			private function edit_category($id)
460			{
461			$id = (int) $id;
462			$title = $this->category->capitalize($this->request->variable('name_' . $this->user->lang_name, '', true));
463
464			$sql = 'SELECT lang_id, lang_iso
465			FROM ' . LANG_TABLE . "
466			ORDER BY lang_id ASC";
467			$result = $this->db->sql_query($sql);
468			while ($row = $this->db->sql_fetchrow($result))
469			{
470			$iso = $row['lang_iso'];
471			$lang = (string) $this->request->variable("lang_$iso", '', true);
472			$sort = (string) $this->request->variable("sort_$iso", '');
473			$order = (int) $this->request->variable('order', 0);
474			$name = $this->category->capitalize($this->request->variable("name_$iso", '', true));
475			if ($name === '')
476			{
477			trigger_error($this->language->lang('SC_CATEGORY_ERROR') . adm_back_link($this->u_action . '&action=edit&id=' . $id), E_USER_WARNING);
478			}
479			else
480			{
481			if ($sort === 'edit')
482			{
483			$sql = 'UPDATE ' . $this->smilies_category_table . "
484			SET cat_name = '" . $name . "', cat_title = '" . $title . "'
485			WHERE cat_lang = '" . $this->db->sql_escape($lang) . "'
486			AND cat_id = $id";
487			$this->db->sql_query($sql);
488			}
489			else if ($sort === 'create')
490			{
491			$sql_in = array(
492			'cat_id' => $id,
493			'cat_order' => $order,
494			'cat_lang' => $lang,
495			'cat_name' => $name,
496			'cat_title' => $title,
497			);
498			$this->db->sql_query('INSERT INTO ' . $this->smilies_category_table . $this->db->sql_build_array('INSERT', $sql_in));
499			}
500			}
501			}
502
503			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_EDIT_CAT', time(), array($title));
504			trigger_error($this->language->lang('SC_EDIT_SUCCESS') . adm_back_link($this->u_action));
505			}
506
507			/**
508			* Set page url
509			*
510			* @param string $u_action Custom form action
511			* @return null
512			* @access public
513			*/
514			public function set_page_url($u_action)
515			{
516			$this->u_action = $u_action;
517			}
518			}
519

Sylver35 / smiliescat

Push — 1.3.0 ( 7a4e4b...8f251a )

admin_controller::__construct() A

Complexity

Size

Duplication

Importance

How to fix Many Parameters

Many Parameters

Duplication Side-by-Side

Filter issues like