admin_controller::extract_list_smilies() - Code Metrics - Inspection of "Add files via upload" - Sylver35/smiliescat - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — 1.1.0 ( c09b16...853fac )

by Sylver

created 2020-05-17 14:10 UTC

admin_controller::extract_list_smilies() C

↳ Parent: admin_controller

Complexity

Conditions	14
Paths	80

Size

Total Lines	73
Code Lines	54

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	14
eloc	54
c	1
b	0
f	0
nc	80
nop	2
dl	0
loc	73
rs	6.2666

How to fix Long Method Complexity

<?php
/**
*
* @package		Breizh Smilies Categories Extension
* @copyright	(c) 2020 Sylver35  https://breizhcode.com
* @license		http://opensource.org/licenses/gpl-license.php GNU Public License
*
*/

namespace sylver35\smiliescat\controller;

use sylver35\smiliescat\core\category;
use phpbb\config\config;
use phpbb\db\driver\driver_interface as db;
use phpbb\pagination;
use phpbb\request\request;
use phpbb\template\template;
use phpbb\user;
use phpbb\language\language;
use phpbb\log\log;

class admin_controller
{
	/* @var \sylver35\smiliescat\core\category */
	protected $category;

	/** @var \phpbb\config\config */
	protected $config;

	/** @var \phpbb\db\driver\driver_interface */
	protected $db;

	/** @var \phpbb\pagination */
	protected $pagination;

	/** @var \phpbb\request\request */
	protected $request;

	/** @var \phpbb\template\template */
	protected $template;

	/** @var \phpbb\user */
	protected $user;

	/** @var \phpbb\language\language */
	protected $language;

	/** @var \phpbb\log\log */
	protected $log;

	/** @var string phpBB root path */
	protected $root_path;

	/** @var string Custom form action */
	protected $u_action;

	/**
	 * The database tables
	 *
	 * @var string */
	protected $smilies_category_table;

	/**
	 * Constructor
	 */
	public function __construct(category $category, config $config, db $db, pagination $pagination, request $request, template $template, user $user, language $language, log $log, $root_path, $smilies_category_table)
	{
		$this->category = $category;
		$this->config = $config;
		$this->db = $db;
		$this->pagination = $pagination;
		$this->request = $request;
		$this->template = $template;
		$this->user = $user;
		$this->language = $language;
		$this->log = $log;
		$this->root_path = $root_path;
		$this->smilies_category_table = $smilies_category_table;
	}

	public function acp_categories_config()
	{
		$this->language->add_lang('acp/language');
		$mode = $this->request->variable('mode', '');
		$action = $this->request->variable('action', '');
		$id = $this->request->variable('id', 0);
		$form_key = 'sylver35/smiliescat';
		add_form_key($form_key);

		if ($action)
		{
			switch ($action)
			{
				case 'config_cat':

					if (!check_form_key($form_key))
					{
						trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
					}

					$this->config->set('smilies_per_page_cat', $this->request->variable('smilies_per_page_cat', 15));

					$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_CONFIG', time());
					trigger_error($this->language->lang('CONFIG_UPDATED') . adm_back_link($this->u_action));

				break;

				case 'add':

					$this->category->adm_add_cat();

					$this->template->assign_vars(array(
						'IN_ADD_ACTION'			=> true,
						'U_BACK'				=> $this->u_action,
						'U_ADD_CAT'				=> $this->u_action . '&amp;action=add_cat',
					));

				break;

				case 'add_cat':

					if (!check_form_key($form_key))
					{
						trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
					}

					$cat_order = $this->request->variable('order', 0);
					$title = $this->request->variable('name_' . $this->user->lang_name, '', true);
					
					$sql_in = array(
						'cat_id'		=> $this->category->get_max_id() + 1,
						'cat_order'		=> $cat_order,
					);
					
					$sql = 'SELECT lang_id, lang_iso
						FROM ' . LANG_TABLE . "
							ORDER BY lang_id ASC";
					$result = $this->db->sql_query($sql);
					while ($row = $this->db->sql_fetchrow($result))
					{
						$iso = $row['lang_iso'];
						$lang = $this->request->variable("lang_$iso", '', true);
						$name = $this->request->variable("name_$iso", '', true);
						if ($name === '')
						{
							trigger_error($this->language->lang('SC_CATEGORY_ERROR', $this->language->lang('SC_CATEGORY_NAME')) . adm_back_link($this->u_action . '&amp;action=add'), E_USER_WARNING);
						}
						else
						{
							$sql_in = array_merge($sql_in, array(
								'cat_lang'		=> $lang,
								'cat_name'		=> $this->category->capitalize($name),
								'cat_title'		=> $this->category->capitalize($title),
							));
							$this->db->sql_query('INSERT INTO ' . $this->smilies_category_table . $this->db->sql_build_array('INSERT', $sql_in));

							if ($cat_order == 1)
							{
								$this->config->set('smilies_category_nb', $sql_in['cat_id']);
							}
						}
					}

					$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_' . strtoupper($action), time(), array($title));
					trigger_error($this->language->lang('SC_CREATE_SUCCESS') . adm_back_link($this->u_action));

				break;

				case 'edit':

					$this->category->adm_edit_cat($id);

					$this->template->assign_vars(array(
						'U_BACK'		=> $this->u_action,
						'U_EDIT_CAT'	=> $this->u_action . '&amp;action=edit_cat&amp;id=' . $id,
					));

				break;

				case 'edit_cat':

					if (!check_form_key($form_key))
					{
						trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
					}

					$title = $this->request->variable('name_' . $this->user->lang_name, '', true);
					$sql = 'SELECT lang_id, lang_iso
						FROM ' . LANG_TABLE . "
							ORDER BY lang_id ASC";
					$result = $this->db->sql_query($sql);
					while ($row = $this->db->sql_fetchrow($result))
					{
						$iso = $row['lang_iso'];
						$lang = $this->request->variable("lang_$iso", '', true);
						$name = $this->request->variable("name_$iso", '', true);
						$sort = $this->request->variable("sort_$iso", '');
						$order = $this->request->variable('order', 0);
						if ($name === '')
						{
							trigger_error($this->language->lang('SC_CATEGORY_ERROR', $this->language->lang('SC_CATEGORY_NAME')) . adm_back_link($this->u_action . '&amp;action=edit&amp;id=' . $id), E_USER_WARNING);
						}
						else
						{
							if ($sort == 'edit')
							{
								$sql = 'UPDATE ' . $this->smilies_category_table . " SET cat_name = '" . $this->category->capitalize($name) . "', cat_title = '" . $this->category->capitalize($title) . "'
									WHERE cat_lang = '" . $this->db->sql_escape($lang) . "' AND cat_id = $id";
								$this->db->sql_query($sql);
							}
							else if ($sort == 'create')
							{
								$sql_in = array(
									'cat_id'		=> $id,
									'cat_order'		=> $order,
									'cat_lang'		=> $lang,
									'cat_name'		=> $this->category->capitalize($name),
									'cat_title'		=> $this->category->capitalize($title),
								);
								$this->db->sql_query('INSERT INTO ' . $this->smilies_category_table . $this->db->sql_build_array('INSERT', $sql_in));
							}
						}
					}

					$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_' . strtoupper($action), time(), array($title));
					trigger_error($this->language->lang('SC_EDIT_SUCCESS') . adm_back_link($this->u_action));

				break;

				case 'move_up':
				case 'move_down':

					if (!check_link_hash($this->request->variable('hash', ''), 'acp-main_module'))
					{
						trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
					}
					
					$result = $this->move_cat($action, $id);
					
					if ($result['return'] === false)
					{
						break;
					}

					$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_' . strtoupper($action) . '_CAT', time(), array($result['title']));

					if ($this->request->is_ajax())
					{
						trigger_error($this->language->lang('SC_MOVE_SUCCESS') . adm_back_link($this->u_action));
						$json_response = new \phpbb\json_response;
						$json_response->send(array(
							'MESSAGE_TITLE'	=> $this->language->lang('INFORMATION'),
							'MESSAGE_TEXT'	=> $this->language->lang('SC_MOVE_SUCCESS'),
							'REFRESH_DATA'	=> array('time'		=> 2),
						));
					}
					else
					{
						trigger_error($this->language->lang('SC_MOVE_SUCCESS') . adm_back_link($this->u_action));
					}

				break;

				case 'delete':

					if (confirm_box(true))
					{
						$this->delete_cat($id);

						if ($this->request->is_ajax())
						{
							trigger_error($this->language->lang('SC_DELETE_SUCCESS') . adm_back_link($this->u_action));
							$json_response = new \phpbb\json_response;
							$json_response->send(array(
								'MESSAGE_TITLE'	=> $this->language->lang('INFORMATION'),
								'MESSAGE_TEXT'	=> $this->language->lang('SC_DELETE_SUCCESS'),
								'REFRESH_DATA'	=> array('time' => 2),
							));
						}
						else
						{
							trigger_error($this->language->lang('SC_DELETE_SUCCESS') . adm_back_link($this->u_action));
						}
					}
					else
					{
						confirm_box(false, $this->language->lang('CONFIRM_OPERATION'), build_hidden_fields(array(
							'mode'		=> $mode,
							'id'		=> $id,
							'action'	=> 'delete',
						)));
					}

				break;
				
			}

			$this->template->assign_vars(array(
				'IN_ACTION'		=> true,
			));
		}
		else
		{
			$this->category->adm_list_cat($this->u_action);
		}

		$this->template->assign_vars(array(
			'CATEGORIE_CONFIG'		=> true,
			'SMILIES_PER_PAGE_CAT'	=> $this->config['smilies_per_page_cat'],
			'U_ADD'					=> $this->u_action . '&amp;action=add',
		));
	}

	public function acp_smilies_category()
	{
		$this->language->add_lang('acp/posting');
		$action = $this->request->variable('action', '');
		$start = $this->request->variable('start', 0);
		$select = $this->request->variable('select', -1);
		$id = $this->request->variable('id', -1);
		$form_key = 'sylver35/smiliescat';
		add_form_key($form_key);

		if ($action)
		{
			switch ($action)
			{
				case 'edit':

					$this->category->adm_edit_smiley($id, $this->u_action, $start);

				break;

				case 'modify':

					if (!check_form_key($form_key))
					{
						trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
					}

					$cat_id = $this->request->variable('cat_id', 0);
					$ex_cat = $this->request->variable('ex_cat', 0);

					$sql = 'UPDATE ' . SMILIES_TABLE . " SET category = $cat_id WHERE smiley_id = $id";
					$this->db->sql_query($sql);

					// Decrement nb value if wanted
					if ($ex_cat != 0)
					{
						$sql = 'UPDATE ' . $this->smilies_category_table . " SET cat_nb = cat_nb - 1 WHERE cat_id = $ex_cat";
						$this->db->sql_query($sql);
					}
					// Increment nb value if wanted
					if ($cat_id != 0)
					{
						$sql = 'UPDATE ' . $this->smilies_category_table . " SET cat_nb = cat_nb + 1 WHERE cat_id = $cat_id";
						$this->db->sql_query($sql);
					}

					trigger_error($this->language->lang('SMILIES_EDITED', 1) . adm_back_link($this->u_action . '&amp;start=' . $start . '#acp_smilies_category'));

				break;
			}

			$this->template->assign_vars(array(
				'IN_ACTION'			=> true,
			));
		}
		else
		{
			$this->extract_list_smilies($select, $start);
		}

		$this->template->assign_vars(array(
			'CATEGORIE_SMILIES'		=> true,
		));
	}
	
	private function move_cat($action, $id)
	{
		// Get current order id and title...
		$sql = 'SELECT cat_order, cat_title
			FROM ' . $this->smilies_category_table . "
				WHERE cat_id = $id";
		$result = $this->db->sql_query($sql);
		$row = $this->db->sql_fetchrow($result);
		$current_order = $row['cat_order'];
		$title = $row['cat_title'];
		$this->db->sql_freeresult($result);

		if ($current_order == 1 && $action == 'move_up')
		{
			return array(
				'return'	=> false,
				'title'		=> '',
			);
		}

		$max_order = $this->category->get_max_order();

		if ($current_order == $max_order && $action == 'move_down')
		{
			return array(
				'return'	=> false,
				'title'		=> '',
			);
		}

		// on move_down, switch position with next order_id...
		// on move_up, switch position with previous order_id...
		$switch_order_id = ($action == 'move_down') ? $current_order + 1 : $current_order - 1;

		$sql = 'UPDATE ' . $this->smilies_category_table . "
			SET cat_order = $current_order
			WHERE cat_order = $switch_order_id
				AND cat_id <> $id";
		$this->db->sql_query($sql);
		$move_executed = (bool) $this->db->sql_affectedrows();

		// Only update the other entry too if the previous entry got updated
		if ($move_executed)
		{
			$sql = 'UPDATE ' . $this->smilies_category_table . "
				SET cat_order = $switch_order_id
				WHERE cat_order = $current_order
					AND cat_id = $id";
			$this->db->sql_query($sql);

			if ($switch_order_id == 1)
			{
				$this->config->set('smilies_category_nb', $id);
			}
		}

		return array(
			'return'	=> true,
			'title'		=> $title,
		);
	}
	
	private function extract_list_smilies($select, $start)
	{
		$cat = $i = 0;
		$smiley_url = '';
		$lang = $this->user->lang_name;
		$smilies_count = $this->category->smilies_count($select);
		$cat_title = $this->language->lang('SC_CATEGORY_DEFAUT');
		$where = ($select !== -1) ? "cat_id = $select AND " : '';

		if ($select !== 0)
		{
			$sql = $this->db->sql_build_query('SELECT', array(
				'SELECT'	=> 's.*, c.*',
				'FROM'		=> array(SMILIES_TABLE => 's'),
				'LEFT_JOIN'	=> array(
					array(
						'FROM'	=> array($this->smilies_category_table => 'c'),
						'ON'	=> "cat_id = category AND cat_lang = '$lang'",
					),
				),
				'WHERE'		=> "$where code <> ''",
				'ORDER_BY'	=> 'cat_order ASC, smiley_order ASC',
			));
		}
		else
		{
			$sql = $this->db->sql_build_query('SELECT', array(
				'SELECT'	=> '*',
				'FROM'		=> array(SMILIES_TABLE => ''),
				'WHERE'		=> "category = 0",
				'ORDER_BY'	=> 'smiley_order ASC',
			));
		}
		$result = $this->db->sql_query_limit($sql, (int) $this->config['smilies_per_page_cat'], $start);
		while ($row = $this->db->sql_fetchrow($result))
		{
			if ($smiley_url === $row['smiley_url'])
			{
				continue;
			}
			$on_spacer = ($cat !== $row['category']) ? true : false;
			$title = ($row['category'] == 0) ? $this->language->lang('SC_SMILIES_NO_CATEGORY') : $this->language->lang('SC_CATEGORY_IN', $row['cat_name']);
			$this->template->assign_block_vars('items', array(
				'S_SPACER_CAT'	=> $on_spacer,
				'SPACER_CAT'	=> $title,
				'IMG_SRC'		=> $this->root_path . $this->config['smilies_path'] . '/' . $row['smiley_url'],
				'WIDTH'			=> $row['smiley_width'],
				'HEIGHT'		=> $row['smiley_height'],
				'CODE'			=> $row['code'],
				'EMOTION'		=> $row['emotion'],
				'CATEGORY'		=> (isset($row['cat_name'])) ? $row['cat_name'] : '',
				'U_EDIT'		=> $this->u_action . '&amp;action=edit&amp;id=' . $row['smiley_id'] . '&amp;start=' . $start,
			));
			$i++;
			$smiley_url = $row['smiley_url'];
			$cat = $row['category'];
			$cat_title = ($select > 0) ? $row['cat_name'] : $cat_title;
		}
		$this->db->sql_freeresult($result);
		$empty_row = ($i == 0) ? true : false;

		$this->template->assign_vars(array(
			'NB_SMILIES'		=> $smilies_count,
			'EMPTY_ROW'			=> $empty_row,
			'LIST_CATEGORY'		=> $this->category->select_categories($select),
			'S_SPACER_ANY'		=> ($cat == 0) ? true : false,
			'S_CAT_SELECT'		=> ($select) ? true : false,
			'CAT_SELECT_TITLE'	=> ($select) ? $this->language->lang('SC_CATEGORY_IN', $cat_title) : '',
			'U_BACK'			=> ($select) ? $this->u_action : false,
			'U_SELECT_CAT'		=> $this->u_action . '&amp;select=' . $select,
		));

		$this->pagination->generate_template_pagination($this->u_action . '&amp;select=' . $select, 'pagination', 'start', $smilies_count, (int) $this->config['smilies_per_page_cat'], $start);
	}

	private function delete_cat($id)
	{
		$sql = 'SELECT cat_title, cat_order
			FROM ' . $this->smilies_category_table . "
				WHERE cat_id = $id";
		$result = $this->db->sql_query($sql);
		$row = $this->db->sql_fetchrow($result);
		$title = $row['cat_title'];
		$order = $row['cat_order'];
		$this->db->sql_freeresult($result);

		$sql_delete = 'DELETE FROM ' . $this->smilies_category_table . " WHERE cat_id = $id";
		$this->db->sql_query($sql_delete);

		// Decrement orders if needed
		$sql_decrement = 'SELECT cat_id, cat_order
			FROM ' . $this->smilies_category_table . "
				WHERE cat_order > $order";
		$result = $this->db->sql_query($sql_decrement);
		while ($row = $this->db->sql_fetchrow($result))
		{
			$new_order = $row['cat_order'] - 1;
			$sql_order = 'UPDATE ' . $this->smilies_category_table . '
				SET cat_order = ' . $new_order . '
					WHERE cat_id = ' . $row['cat_id'] . ' AND cat_order = ' . $row['cat_order'];
			$this->db->sql_query($sql_order);
		}
		$this->db->sql_freeresult($result);

		// Reset appropriate smilies category id
		$sql_update = 'UPDATE ' . SMILIES_TABLE . " SET category = 0 WHERE category = $id";
		$this->db->sql_query($sql_update);

		$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_DELETE_CAT', time(), array($title));
	}

	/**
	 * Set page url
	 *
	 * @param string $u_action Custom form action
	 * @return null
	 * @access public
	 */
	public function set_page_url($u_action)
	{
		$this->u_action = $u_action;
	}
}


1			<?php
2			/**
3			*
4			* @package Breizh Smilies Categories Extension
5			* @copyright (c) 2020 Sylver35 https://breizhcode.com
6			* @license http://opensource.org/licenses/gpl-license.php GNU Public License
7			*
8			*/
9
10			namespace sylver35\smiliescat\controller;
11
12			use sylver35\smiliescat\core\category;
13			use phpbb\config\config;
14			use phpbb\db\driver\driver_interface as db;
15			use phpbb\pagination;
16			use phpbb\request\request;
17			use phpbb\template\template;
18			use phpbb\user;
19			use phpbb\language\language;
20			use phpbb\log\log;
21
22			class admin_controller
23			{
24			/* @var \sylver35\smiliescat\core\category */
25			protected $category;
26
27			/** @var \phpbb\config\config */
28			protected $config;
29
30			/** @var \phpbb\db\driver\driver_interface */
31			protected $db;
32
33			/** @var \phpbb\pagination */
34			protected $pagination;
35
36			/** @var \phpbb\request\request */
37			protected $request;
38
39			/** @var \phpbb\template\template */
40			protected $template;
41
42			/** @var \phpbb\user */
43			protected $user;
44
45			/** @var \phpbb\language\language */
46			protected $language;
47
48			/** @var \phpbb\log\log */
49			protected $log;
50
51			/** @var string phpBB root path */
52			protected $root_path;
53
54			/** @var string Custom form action */
55			protected $u_action;
56
57			/**
58			* The database tables
59			*
60			* @var string */
61			protected $smilies_category_table;
62
63			/**
64			* Constructor
65			*/
66			public function __construct(category $category, config $config, db $db, pagination $pagination, request $request, template $template, user $user, language $language, log $log, $root_path, $smilies_category_table)
67			{
68			$this->category = $category;
69			$this->config = $config;
70			$this->db = $db;
71			$this->pagination = $pagination;
72			$this->request = $request;
73			$this->template = $template;
74			$this->user = $user;
75			$this->language = $language;
76			$this->log = $log;
77			$this->root_path = $root_path;
78			$this->smilies_category_table = $smilies_category_table;
79			}
80
81			public function acp_categories_config()
82			{
83			$this->language->add_lang('acp/language');
84			$mode = $this->request->variable('mode', '');
85			$action = $this->request->variable('action', '');
86			$id = $this->request->variable('id', 0);
87			$form_key = 'sylver35/smiliescat';
88			add_form_key($form_key);
89
90			if ($action)
91			{
92			switch ($action)
93			{
94			case 'config_cat':
95
96			if (!check_form_key($form_key))
97			{
98			trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
99			}
100
101			$this->config->set('smilies_per_page_cat', $this->request->variable('smilies_per_page_cat', 15));
102
103			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_CONFIG', time());
104			trigger_error($this->language->lang('CONFIG_UPDATED') . adm_back_link($this->u_action));
105
106			break;
107
108			case 'add':
109
110			$this->category->adm_add_cat();
111
112			$this->template->assign_vars(array(
113			'IN_ADD_ACTION' => true,
114			'U_BACK' => $this->u_action,
115			'U_ADD_CAT' => $this->u_action . '&action=add_cat',
116			));
117
118			break;
119
120			case 'add_cat':
121
122			if (!check_form_key($form_key))
123			{
124			trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
125			}
126
127			$cat_order = $this->request->variable('order', 0);
128			$title = $this->request->variable('name_' . $this->user->lang_name, '', true);
129
130			$sql_in = array(
131			'cat_id' => $this->category->get_max_id() + 1,
132			'cat_order' => $cat_order,
133			);
134
135			$sql = 'SELECT lang_id, lang_iso
136			FROM ' . LANG_TABLE . "
137			ORDER BY lang_id ASC";
138			$result = $this->db->sql_query($sql);
139			while ($row = $this->db->sql_fetchrow($result))
140			{
141			$iso = $row['lang_iso'];
142			$lang = $this->request->variable("lang_$iso", '', true);
143			$name = $this->request->variable("name_$iso", '', true);
144			if ($name === '')
145			{
146			trigger_error($this->language->lang('SC_CATEGORY_ERROR', $this->language->lang('SC_CATEGORY_NAME')) . adm_back_link($this->u_action . '&action=add'), E_USER_WARNING);
147			}
148			else
149			{
150			$sql_in = array_merge($sql_in, array(
151			'cat_lang' => $lang,
152			'cat_name' => $this->category->capitalize($name),
153			'cat_title' => $this->category->capitalize($title),
154			));
155			$this->db->sql_query('INSERT INTO ' . $this->smilies_category_table . $this->db->sql_build_array('INSERT', $sql_in));
156
157			if ($cat_order == 1)
158			{
159			$this->config->set('smilies_category_nb', $sql_in['cat_id']);
160			}
161			}
162			}
163
164			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_' . strtoupper($action), time(), array($title));
165			trigger_error($this->language->lang('SC_CREATE_SUCCESS') . adm_back_link($this->u_action));
166
167			break;
168
169			case 'edit':
170
171			$this->category->adm_edit_cat($id);
172
173			$this->template->assign_vars(array(
174			'U_BACK' => $this->u_action,
175			'U_EDIT_CAT' => $this->u_action . '&action=edit_cat&id=' . $id,
176			));
177
178			break;
179
180			case 'edit_cat':
181
182			if (!check_form_key($form_key))
183			{
184			trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
185			}
186
187			$title = $this->request->variable('name_' . $this->user->lang_name, '', true);
188			$sql = 'SELECT lang_id, lang_iso
189			FROM ' . LANG_TABLE . "
190			ORDER BY lang_id ASC";
191			$result = $this->db->sql_query($sql);
192			while ($row = $this->db->sql_fetchrow($result))
193			{
194			$iso = $row['lang_iso'];
195			$lang = $this->request->variable("lang_$iso", '', true);
196			$name = $this->request->variable("name_$iso", '', true);
197			$sort = $this->request->variable("sort_$iso", '');
198			$order = $this->request->variable('order', 0);
199			if ($name === '')
200			{
201			trigger_error($this->language->lang('SC_CATEGORY_ERROR', $this->language->lang('SC_CATEGORY_NAME')) . adm_back_link($this->u_action . '&action=edit&id=' . $id), E_USER_WARNING);
202			}
203			else
204			{
205			if ($sort == 'edit')
206			{
207			$sql = 'UPDATE ' . $this->smilies_category_table . " SET cat_name = '" . $this->category->capitalize($name) . "', cat_title = '" . $this->category->capitalize($title) . "'
208			WHERE cat_lang = '" . $this->db->sql_escape($lang) . "' AND cat_id = $id";
209			$this->db->sql_query($sql);
210			}
211			else if ($sort == 'create')
212			{
213			$sql_in = array(
214			'cat_id' => $id,
215			'cat_order' => $order,
216			'cat_lang' => $lang,
217			'cat_name' => $this->category->capitalize($name),
218			'cat_title' => $this->category->capitalize($title),
219			);
220			$this->db->sql_query('INSERT INTO ' . $this->smilies_category_table . $this->db->sql_build_array('INSERT', $sql_in));
221			}
222			}
223			}
224
225			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_' . strtoupper($action), time(), array($title));
226			trigger_error($this->language->lang('SC_EDIT_SUCCESS') . adm_back_link($this->u_action));
227
228			break;
229
230			case 'move_up':
231			case 'move_down':
232
233			if (!check_link_hash($this->request->variable('hash', ''), 'acp-main_module'))
234			{
235			trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
236			}
237
238			$result = $this->move_cat($action, $id);
239
240			if ($result['return'] === false)
241			{
242			break;
243			}
244
245			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_' . strtoupper($action) . '_CAT', time(), array($result['title']));
246
247			if ($this->request->is_ajax())
248			{
249			trigger_error($this->language->lang('SC_MOVE_SUCCESS') . adm_back_link($this->u_action));
250			$json_response = new \phpbb\json_response;
251			$json_response->send(array(
252			'MESSAGE_TITLE' => $this->language->lang('INFORMATION'),
253			'MESSAGE_TEXT' => $this->language->lang('SC_MOVE_SUCCESS'),
254			'REFRESH_DATA' => array('time' => 2),
255			));
256			}
257			else
258			{
259			trigger_error($this->language->lang('SC_MOVE_SUCCESS') . adm_back_link($this->u_action));
260			}
261
262			break;
263
264			case 'delete':
265
266			if (confirm_box(true))
267			{
268			$this->delete_cat($id);
269
270			if ($this->request->is_ajax())
271			{
272			trigger_error($this->language->lang('SC_DELETE_SUCCESS') . adm_back_link($this->u_action));
273			$json_response = new \phpbb\json_response;
274			$json_response->send(array(
275			'MESSAGE_TITLE' => $this->language->lang('INFORMATION'),
276			'MESSAGE_TEXT' => $this->language->lang('SC_DELETE_SUCCESS'),
277			'REFRESH_DATA' => array('time' => 2),
278			));
279			}
280			else
281			{
282			trigger_error($this->language->lang('SC_DELETE_SUCCESS') . adm_back_link($this->u_action));
283			}
284			}
285			else
286			{
287			confirm_box(false, $this->language->lang('CONFIRM_OPERATION'), build_hidden_fields(array(
288			'mode' => $mode,
289			'id' => $id,
290			'action' => 'delete',
291			)));
292			}
293
294			break;
295
296			}
297
298			$this->template->assign_vars(array(
299			'IN_ACTION' => true,
300			));
301			}
302			else
303			{
304			$this->category->adm_list_cat($this->u_action);
305			}
306
307			$this->template->assign_vars(array(
308			'CATEGORIE_CONFIG' => true,
309			'SMILIES_PER_PAGE_CAT' => $this->config['smilies_per_page_cat'],
310			'U_ADD' => $this->u_action . '&action=add',
311			));
312			}
313
314			public function acp_smilies_category()
315			{
316			$this->language->add_lang('acp/posting');
317			$action = $this->request->variable('action', '');
318			$start = $this->request->variable('start', 0);
319			$select = $this->request->variable('select', -1);
320			$id = $this->request->variable('id', -1);
321			$form_key = 'sylver35/smiliescat';
322			add_form_key($form_key);
323
324			if ($action)
325			{
326			switch ($action)
327			{
328			case 'edit':
329
330			$this->category->adm_edit_smiley($id, $this->u_action, $start);
331
332			break;
333
334			case 'modify':
335
336			if (!check_form_key($form_key))
337			{
338			trigger_error($this->language->lang('FORM_INVALID') . adm_back_link($this->u_action), E_USER_WARNING);
339			}
340
341			$cat_id = $this->request->variable('cat_id', 0);
342			$ex_cat = $this->request->variable('ex_cat', 0);
343
344			$sql = 'UPDATE ' . SMILIES_TABLE . " SET category = $cat_id WHERE smiley_id = $id";
345			$this->db->sql_query($sql);
346
347			// Decrement nb value if wanted
348			if ($ex_cat != 0)
349			{
350			$sql = 'UPDATE ' . $this->smilies_category_table . " SET cat_nb = cat_nb - 1 WHERE cat_id = $ex_cat";
351			$this->db->sql_query($sql);
352			}
353			// Increment nb value if wanted
354			if ($cat_id != 0)
355			{
356			$sql = 'UPDATE ' . $this->smilies_category_table . " SET cat_nb = cat_nb + 1 WHERE cat_id = $cat_id";
357			$this->db->sql_query($sql);
358			}
359
360			trigger_error($this->language->lang('SMILIES_EDITED', 1) . adm_back_link($this->u_action . '&start=' . $start . '#acp_smilies_category'));
361
362			break;
363			}
364
365			$this->template->assign_vars(array(
366			'IN_ACTION' => true,
367			));
368			}
369			else
370			{
371			$this->extract_list_smilies($select, $start);
372			}
373
374			$this->template->assign_vars(array(
375			'CATEGORIE_SMILIES' => true,
376			));
377			}
378
379			private function move_cat($action, $id)
380			{
381			// Get current order id and title...
382			$sql = 'SELECT cat_order, cat_title
383			FROM ' . $this->smilies_category_table . "
384			WHERE cat_id = $id";
385			$result = $this->db->sql_query($sql);
386			$row = $this->db->sql_fetchrow($result);
387			$current_order = $row['cat_order'];
388			$title = $row['cat_title'];
389			$this->db->sql_freeresult($result);
390
391			if ($current_order == 1 && $action == 'move_up')
392			{
393			return array(
394			'return' => false,
395			'title' => '',
396			);
397			}
398
399			$max_order = $this->category->get_max_order();
400
401			if ($current_order == $max_order && $action == 'move_down')
402			{
403			return array(
404			'return' => false,
405			'title' => '',
406			);
407			}
408
409			// on move_down, switch position with next order_id...
410			// on move_up, switch position with previous order_id...
411			$switch_order_id = ($action == 'move_down') ? $current_order + 1 : $current_order - 1;
412
413			$sql = 'UPDATE ' . $this->smilies_category_table . "
414			SET cat_order = $current_order
415			WHERE cat_order = $switch_order_id
416			AND cat_id <> $id";
417			$this->db->sql_query($sql);
418			$move_executed = (bool) $this->db->sql_affectedrows();
419
420			// Only update the other entry too if the previous entry got updated
421			if ($move_executed)
422			{
423			$sql = 'UPDATE ' . $this->smilies_category_table . "
424			SET cat_order = $switch_order_id
425			WHERE cat_order = $current_order
426			AND cat_id = $id";
427			$this->db->sql_query($sql);
428
429			if ($switch_order_id == 1)
430			{
431			$this->config->set('smilies_category_nb', $id);
432			}
433			}
434
435			return array(
436			'return' => true,
437			'title' => $title,
438			);
439			}
440
441			private function extract_list_smilies($select, $start)
442			{
443			$cat = $i = 0;
444			$smiley_url = '';
445			$lang = $this->user->lang_name;
446			$smilies_count = $this->category->smilies_count($select);
447			$cat_title = $this->language->lang('SC_CATEGORY_DEFAUT');
448			$where = ($select !== -1) ? "cat_id = $select AND " : '';
449
450			if ($select !== 0)
451			{
452			$sql = $this->db->sql_build_query('SELECT', array(
453			'SELECT' => 's., c.',
454			'FROM' => array(SMILIES_TABLE => 's'),
455			'LEFT_JOIN' => array(
456			array(
457			'FROM' => array($this->smilies_category_table => 'c'),
458			'ON' => "cat_id = category AND cat_lang = '$lang'",
459			),
460			),
461			'WHERE' => "$where code <> ''",
462			'ORDER_BY' => 'cat_order ASC, smiley_order ASC',
463			));
464			}
465			else
466			{
467			$sql = $this->db->sql_build_query('SELECT', array(
468			'SELECT' => '*',
469			'FROM' => array(SMILIES_TABLE => ''),
470			'WHERE' => "category = 0",
471			'ORDER_BY' => 'smiley_order ASC',
472			));
473			}
474			$result = $this->db->sql_query_limit($sql, (int) $this->config['smilies_per_page_cat'], $start);
475			while ($row = $this->db->sql_fetchrow($result))
476			{
477			if ($smiley_url === $row['smiley_url'])
478			{
479			continue;
480			}
481			$on_spacer = ($cat !== $row['category']) ? true : false;
482			$title = ($row['category'] == 0) ? $this->language->lang('SC_SMILIES_NO_CATEGORY') : $this->language->lang('SC_CATEGORY_IN', $row['cat_name']);
483			$this->template->assign_block_vars('items', array(
484			'S_SPACER_CAT' => $on_spacer,
485			'SPACER_CAT' => $title,
486			'IMG_SRC' => $this->root_path . $this->config['smilies_path'] . '/' . $row['smiley_url'],
487			'WIDTH' => $row['smiley_width'],
488			'HEIGHT' => $row['smiley_height'],
489			'CODE' => $row['code'],
490			'EMOTION' => $row['emotion'],
491			'CATEGORY' => (isset($row['cat_name'])) ? $row['cat_name'] : '',
492			'U_EDIT' => $this->u_action . '&action=edit&id=' . $row['smiley_id'] . '&start=' . $start,
493			));
494			$i++;
495			$smiley_url = $row['smiley_url'];
496			$cat = $row['category'];
497			$cat_title = ($select > 0) ? $row['cat_name'] : $cat_title;
498			}
499			$this->db->sql_freeresult($result);
500			$empty_row = ($i == 0) ? true : false;
501
502			$this->template->assign_vars(array(
503			'NB_SMILIES' => $smilies_count,
504			'EMPTY_ROW' => $empty_row,
505			'LIST_CATEGORY' => $this->category->select_categories($select),
506			'S_SPACER_ANY' => ($cat == 0) ? true : false,
507			'S_CAT_SELECT' => ($select) ? true : false,
508			'CAT_SELECT_TITLE' => ($select) ? $this->language->lang('SC_CATEGORY_IN', $cat_title) : '',
509			'U_BACK' => ($select) ? $this->u_action : false,
510			'U_SELECT_CAT' => $this->u_action . '&select=' . $select,
511			));
512
513			$this->pagination->generate_template_pagination($this->u_action . '&select=' . $select, 'pagination', 'start', $smilies_count, (int) $this->config['smilies_per_page_cat'], $start);
514			}
515
516			private function delete_cat($id)
517			{
518			$sql = 'SELECT cat_title, cat_order
519			FROM ' . $this->smilies_category_table . "
520			WHERE cat_id = $id";
521			$result = $this->db->sql_query($sql);
522			$row = $this->db->sql_fetchrow($result);
523			$title = $row['cat_title'];
524			$order = $row['cat_order'];
525			$this->db->sql_freeresult($result);
526
527			$sql_delete = 'DELETE FROM ' . $this->smilies_category_table . " WHERE cat_id = $id";
528			$this->db->sql_query($sql_delete);
529
530			// Decrement orders if needed
531			$sql_decrement = 'SELECT cat_id, cat_order
532			FROM ' . $this->smilies_category_table . "
533			WHERE cat_order > $order";
534			$result = $this->db->sql_query($sql_decrement);
535			while ($row = $this->db->sql_fetchrow($result))
536			{
537			$new_order = $row['cat_order'] - 1;
538			$sql_order = 'UPDATE ' . $this->smilies_category_table . '
539			SET cat_order = ' . $new_order . '
540			WHERE cat_id = ' . $row['cat_id'] . ' AND cat_order = ' . $row['cat_order'];
541			$this->db->sql_query($sql_order);
542			}
543			$this->db->sql_freeresult($result);
544
545			// Reset appropriate smilies category id
546			$sql_update = 'UPDATE ' . SMILIES_TABLE . " SET category = 0 WHERE category = $id";
547			$this->db->sql_query($sql_update);
548
549			$this->log->add('admin', $this->user->data['user_id'], $this->user->ip, 'LOG_SC_DELETE_CAT', time(), array($title));
550			}
551
552			/**
553			* Set page url
554			*
555			* @param string $u_action Custom form action
556			* @return null
557			* @access public
558			*/
559			public function set_page_url($u_action)
560			{
561			$this->u_action = $u_action;
562			}
563			}
564

Sylver35 / smiliescat

Push — 1.1.0 ( c09b16...853fac )

admin_controller::extract_list_smilies() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like