Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | View Code Duplication | final class PutVariantBasedConfigurableItemToCart |
|
8 | { |
||
9 | /** |
||
10 | * @var string |
||
11 | */ |
||
12 | private $orderToken; |
||
13 | |||
14 | /** |
||
15 | * @var string |
||
16 | */ |
||
17 | private $product; |
||
18 | |||
19 | /** |
||
20 | * @var int |
||
21 | */ |
||
22 | private $quantity; |
||
23 | |||
24 | /** |
||
25 | * @var string |
||
26 | */ |
||
27 | private $productVariant; |
||
28 | |||
29 | /** |
||
30 | * @param string $orderToken |
||
31 | * @param string $product |
||
32 | * @param string $productVariant |
||
33 | * @param int $quantity |
||
34 | */ |
||
35 | public function __construct($orderToken, $product, $productVariant, $quantity) |
||
36 | { |
||
37 | Assert::string($orderToken, 'Expected order token to be string, got %s'); |
||
38 | Assert::string($product, 'Expected product code to be string, got %s'); |
||
39 | Assert::string($productVariant, 'Expected product variant code to be string, got %s'); |
||
40 | Assert::integer($quantity, 'Expected quantity to be integer, got %s'); |
||
41 | Assert::greaterThan($quantity, 0, 'Quantity should be greater than 0'); |
||
42 | |||
43 | $this->orderToken = $orderToken; |
||
44 | $this->product = $product; |
||
45 | $this->quantity = $quantity; |
||
46 | $this->productVariant = $productVariant; |
||
47 | } |
||
48 | |||
49 | /** |
||
50 | * @return string |
||
51 | */ |
||
52 | public function orderToken() |
||
56 | |||
57 | /** |
||
58 | * @return string |
||
59 | */ |
||
60 | public function product() |
||
64 | |||
65 | /** |
||
66 | * @return string |
||
67 | */ |
||
68 | public function productVariant() |
||
72 | |||
73 | /** |
||
74 | * @return int |
||
75 | */ |
||
76 | public function quantity() |
||
80 | } |
||
81 |