PaymentViewFactory::__construct() - Code Metrics - Inspection of "Changing plugin to the right naming convention" - Sylius/SyliusShopApiPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#290)

unknown

created 2018-08-20 12:49 UTC

PaymentViewFactory::__construct() A

↳ Parent: PaymentViewFactory

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	9
rs	9.9666
c	0
b	0
f	0
cc	1
nc	1
nop	3

<?php

declare(strict_types=1);

namespace Sylius\SyliusShopApiPlugin\Factory;

use Sylius\Component\Core\Model\PaymentInterface;
use Sylius\ShopApiPlugin\View\PaymentView;

final class PaymentViewFactory implements PaymentViewFactoryInterface
{
    /** @var PaymentMethodViewFactoryInterface */
    private $paymentMethodViewFactory;

    /** @var PriceViewFactoryInterface */
    private $priceViewFactory;

    /** @var string */
    private $paymentViewClass;

    public function __construct(
        PaymentMethodViewFactoryInterface $paymentMethodViewFactory,
        PriceViewFactoryInterface $priceViewFactory,
        string $paymentViewClass
    ) {
        $this->paymentMethodViewFactory = $paymentMethodViewFactory;
        $this->priceViewFactory = $priceViewFactory;
        $this->paymentViewClass = $paymentViewClass;
    }

    /**
     * {@inheritdoc}
     */
    public function create(PaymentInterface $payment, string $locale): PaymentView
    {
        /** @var PaymentView $paymentView */
        $paymentView = new $this->paymentViewClass();

        $paymentView->state = $payment->getState();
        $paymentView->method = $this->paymentMethodViewFactory->create($payment->getMethod(), $locale);

        $paymentView->price = $this->priceViewFactory->create($payment->getAmount(), $payment->getCurrencyCode());

        return $paymentView;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Sylius\SyliusShopApiPlugin\Factory;
6
7			use Sylius\Component\Core\Model\PaymentInterface;
8			use Sylius\ShopApiPlugin\View\PaymentView;
9
10			final class PaymentViewFactory implements PaymentViewFactoryInterface
11			{
12			/** @var PaymentMethodViewFactoryInterface */
13			private $paymentMethodViewFactory;
14
15			/** @var PriceViewFactoryInterface */
16			private $priceViewFactory;
17
18			/** @var string */
19			private $paymentViewClass;
20
21			public function __construct(
22			PaymentMethodViewFactoryInterface $paymentMethodViewFactory,
23			PriceViewFactoryInterface $priceViewFactory,
24			string $paymentViewClass
25			) {
26			$this->paymentMethodViewFactory = $paymentMethodViewFactory;
27			$this->priceViewFactory = $priceViewFactory;
28			$this->paymentViewClass = $paymentViewClass;
29			}
30
31			/**
32			* {@inheritdoc}
33			*/
34			public function create(PaymentInterface $payment, string $locale): PaymentView
35			{
36			/** @var PaymentView $paymentView */
37			$paymentView = new $this->paymentViewClass();
38
39			$paymentView->state = $payment->getState();
40			$paymentView->method = $this->paymentMethodViewFactory->create($payment->getMethod(), $locale);
			0 ignored issues – show Compatibility introduced 2017-05-11 10:11 UTC by Report Bug Copy Issue Report `$payment->getMethod()` of type `object<Sylius\Component\...PaymentMethodInterface>` is not a sub-type of `object<Sylius\Component\...PaymentMethodInterface>`. It seems like you assume a child interface of the interface `Sylius\Component\Payment...\PaymentMethodInterface` to be always present. This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass. Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type. Loading history...
41			$paymentView->price = $this->priceViewFactory->create($payment->getAmount(), $payment->getCurrencyCode());
42
43			return $paymentView;
44			}
45			}
46

Sylius / SyliusShopApiPlugin

Pull Request — master (#290)

PaymentViewFactory::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like