Sylius\SyliusShopApiPlugin\Checker\PromotionCouponEligibilityChecker

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	isEligible()	0	20	3

<?php

declare(strict_types=1);

namespace Sylius\SyliusShopApiPlugin\Checker;

use Sylius\Component\Core\Model\OrderInterface;
use Sylius\Component\Core\Model\PromotionInterface;
use Sylius\Component\Promotion\Checker\Eligibility\PromotionCouponEligibilityCheckerInterface;
use Sylius\Component\Promotion\Checker\Eligibility\PromotionEligibilityCheckerInterface;
use Sylius\Component\Promotion\Model\PromotionCouponInterface;
use Sylius\Component\Promotion\Model\PromotionSubjectInterface;
use Webmozart\Assert\Assert;

final class PromotionCouponEligibilityChecker implements PromotionCouponEligibilityCheckerInterface
{
    /**
     * @var PromotionEligibilityCheckerInterface
     */
    private $promotionEligibilityChecker;

    /**
     * @var PromotionCouponEligibilityCheckerInterface
     */
    private $couponEligibilityChecker;

    /**
     * @param PromotionEligibilityCheckerInterface $promotionEligibilityChecker
     * @param PromotionCouponEligibilityCheckerInterface $couponEligibilityChecker
     */
    public function __construct(
        PromotionEligibilityCheckerInterface $promotionEligibilityChecker,
        PromotionCouponEligibilityCheckerInterface $couponEligibilityChecker
    ) {
        $this->promotionEligibilityChecker = $promotionEligibilityChecker;
        $this->couponEligibilityChecker = $couponEligibilityChecker;
    }

    /**
     * {@inheritdoc}
     */
    public function isEligible(PromotionSubjectInterface $cart, PromotionCouponInterface $coupon): bool
    {
        /** @var OrderInterface $cart */
        Assert::isInstanceOf($cart, OrderInterface::class);

        /** @var PromotionInterface $promotion */
        $promotion = $coupon->getPromotion();

        $cart->setPromotionCoupon($coupon);

        $isEligible =
            $promotion->hasChannel($cart->getChannel())

It seems like $cart->getChannel() can be null; however, hasChannel() does not accept null, maybe add an additional type check?

            && $this->couponEligibilityChecker->isEligible($cart, $coupon)
            && $this->promotionEligibilityChecker->isEligible($cart, $coupon->getPromotion())
        ;

        $cart->setPromotionCoupon(null);

        return $isEligible;
    }
}