AddressOrder::__construct() - Code Metrics - Inspection of "Changing plugin to the right naming convention" - Sylius/SyliusShopApiPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#290)

unknown

created 2018-08-20 12:57 UTC

AddressOrder::__construct() A

↳ Parent: AddressOrder

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	3

<?php

declare(strict_types=1);

namespace Sylius\SyliusShopApiPlugin\Command;

use Sylius\SyliusShopApiPlugin\Model\Address;
use Webmozart\Assert\Assert;

final class AddressOrder
{
    /**
     * @var string
     */
    private $orderToken;

    /**
     * @var Address
     */
    private $address;

    /**
     * @var Address
     */
    private $billingAddress;

    /**
     * @param string $orderToken
     * @param Address $shippingAddress
     * @param Address $billingAddress
     */
    public function __construct($orderToken, Address $shippingAddress, Address $billingAddress)
    {
        Assert::string($orderToken);

        $this->orderToken = $orderToken;
        $this->address = $shippingAddress;
        $this->billingAddress = $billingAddress;
    }

    /**
     * @return string
     */
    public function orderToken()
    {
        return $this->orderToken;
    }

    /**
     * @return Address
     */
    public function shippingAddress()
    {
        return $this->address;
    }

    /**
     * @return Address
     */
    public function billingAddress()
    {
        return $this->billingAddress;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Sylius\SyliusShopApiPlugin\Command;
6
7			use Sylius\SyliusShopApiPlugin\Model\Address;
8			use Webmozart\Assert\Assert;
9
10			final class AddressOrder
11			{
12			/**
13			* @var string
14			*/
15			private $orderToken;
16
17			/**
18			* @var Address
19			*/
20			private $address;
21
22			/**
23			* @var Address
24			*/
25			private $billingAddress;
26
27			/**
28			* @param string $orderToken
29			* @param Address $shippingAddress
30			* @param Address $billingAddress
31			*/
32			public function __construct($orderToken, Address $shippingAddress, Address $billingAddress)
33			{
34			Assert::string($orderToken);
35
36			$this->orderToken = $orderToken;
37			$this->address = $shippingAddress;
38			$this->billingAddress = $billingAddress;
39			}
40
41			/**
42			* @return string
43			*/
44			public function orderToken()
45			{
46			return $this->orderToken;
47			}
48
49			/**
50			* @return Address
51			*/
52			public function shippingAddress()
53			{
54			return $this->address;
55			}
56
57			/**
58			* @return Address
59			*/
60			public function billingAddress()
61			{
62			return $this->billingAddress;
63			}
64			}
65

Sylius / SyliusShopApiPlugin

Pull Request — master (#290)

AddressOrder::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like