AddProductReviewByCode::productCode() - Code Metrics - Inspection of "Changing plugin to the right naming convention" - Sylius/SyliusShopApiPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#290)

unknown

created 2018-08-20 12:57 UTC

AddProductReviewByCode::productCode() A

↳ Parent: AddProductReviewByCode

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

declare(strict_types=1);

namespace Sylius\SyliusShopApiPlugin\Command;

final class AddProductReviewByCode

{
    /**
     * @var string
     */
    private $productCode;

    /**
     * @var string
     */
    private $channelCode;

    /**
     * @var string
     */
    private $title;

    /**
     * @var int
     */
    private $rating;

    /**
     * @var string
     */
    private $comment;

    /**
     * @var string
     */
    private $email;

    public function __construct(string $productCode, string $channelCode, string $title, int $rating, string $comment, string $email)
    {
        $this->productCode = $productCode;
        $this->channelCode = $channelCode;
        $this->title = $title;
        $this->rating = $rating;
        $this->comment = $comment;
        $this->email = $email;
    }

    public function productCode(): string
    {
        return $this->productCode;
    }

    public function channelCode(): string
    {
        return $this->channelCode;
    }

    public function title(): string
    {
        return $this->title;
    }

    public function rating(): int
    {
        return $this->rating;
    }

    public function comment(): string
    {
        return $this->comment;
    }

    public function email(): string
    {
        return $this->email;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Sylius\SyliusShopApiPlugin\Command;
6
7	View Code Duplication	final class AddProductReviewByCode
		0 ignored issues – show Duplication introduced 2017-07-10 10:15 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
8		{
9		/**
10		* @var string
11		*/
12		private $productCode;
13
14		/**
15		* @var string
16		*/
17		private $channelCode;
18
19		/**
20		* @var string
21		*/
22		private $title;
23
24		/**
25		* @var int
26		*/
27		private $rating;
28
29		/**
30		* @var string
31		*/
32		private $comment;
33
34		/**
35		* @var string
36		*/
37		private $email;
38
39		public function __construct(string $productCode, string $channelCode, string $title, int $rating, string $comment, string $email)
40		{
41		$this->productCode = $productCode;
42		$this->channelCode = $channelCode;
43		$this->title = $title;
44		$this->rating = $rating;
45		$this->comment = $comment;
46		$this->email = $email;
47		}
48
49		public function productCode(): string
50		{
51		return $this->productCode;
52		}
53
54		public function channelCode(): string
55		{
56		return $this->channelCode;
57		}
58
59		public function title(): string
60		{
61		return $this->title;
62		}
63
64		public function rating(): int
65		{
66		return $this->rating;
67		}
68
69		public function comment(): string
70		{
71		return $this->comment;
72		}
73
74		public function email(): string
75		{
76		return $this->email;
77		}
78		}
79

Sylius / SyliusShopApiPlugin

Pull Request — master (#290)

AddProductReviewByCode::productCode() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like