UpdateCustomerRequest::__construct() - Code Metrics - Inspection of "[WIP] Customer profile edit" - Sylius/SyliusShopApiPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#234)

unknown

created 2017-11-03 13:40 UTC

UpdateCustomerRequest::__construct() A

↳ Parent: UpdateCustomerRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	1

<?php

declare(strict_types=1);

namespace Sylius\ShopApiPlugin\Request;

use DateTimeInterface;
use Sylius\ShopApiPlugin\Command\UpdateCustomer;
use Symfony\Component\HttpFoundation\Request;

final class UpdateCustomerRequest
{
    /**
     * @var string
     */
    private $firstName;

    /**
     * @var string
     */
    private $lastName;

    /**
     * @var string|null
     */
    private $email;

    /**
     * @var DateTimeInterface|null
     */
    private $birthday;

    /**
     * @var string
     */
    private $gender;

    /**
     * @var string|null
     */
    private $phoneNumber;

    /**
     * @var bool
     */
    private $subscribedToNewsletter;

    /**
     * @param Request $request
     */
    public function __construct(Request $request)
    {
        $this->firstName = $request->request->get('firstName');
        $this->lastName = $request->request->get('lastName');
        $this->email = $request->request->get('email');
        $this->birthday = $request->request->get('birthday');
        $this->gender = $request->request->get('gender');
        $this->phoneNumber = $request->request->get('phoneNumber');
        $this->subscribedToNewsletter = (bool) $request->request->get('subscribedToNewsletter') ?? false;
    }

    /**
     * @return UpdateCustomer
     */
    public function getCommand()
    {
        return new UpdateCustomer($this->firstName, $this->lastName, $this->email, $this->birthday, $this->gender, $this->phoneNumber, $this->subscribedToNewsletter);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Sylius\ShopApiPlugin\Request;
6
7			use DateTimeInterface;
8			use Sylius\ShopApiPlugin\Command\UpdateCustomer;
9			use Symfony\Component\HttpFoundation\Request;
10
11			final class UpdateCustomerRequest
12			{
13			/**
14			* @var string
15			*/
16			private $firstName;
17
18			/**
19			* @var string
20			*/
21			private $lastName;
22
23			/**
24			* @var string\|null
25			*/
26			private $email;
27
28			/**
29			* @var DateTimeInterface\|null
30			*/
31			private $birthday;
32
33			/**
34			* @var string
35			*/
36			private $gender;
37
38			/**
39			* @var string\|null
40			*/
41			private $phoneNumber;
42
43			/**
44			* @var bool
45			*/
46			private $subscribedToNewsletter;
47
48			/**
49			* @param Request $request
50			*/
51			public function __construct(Request $request)
52			{
53			$this->firstName = $request->request->get('firstName');
54			$this->lastName = $request->request->get('lastName');
55			$this->email = $request->request->get('email');
56			$this->birthday = $request->request->get('birthday');
57			$this->gender = $request->request->get('gender');
58			$this->phoneNumber = $request->request->get('phoneNumber');
59			$this->subscribedToNewsletter = (bool) $request->request->get('subscribedToNewsletter') ?? false;
60			}
61
62			/**
63			* @return UpdateCustomer
64			*/
65			public function getCommand()
66			{
67			return new UpdateCustomer($this->firstName, $this->lastName, $this->email, $this->birthday, $this->gender, $this->phoneNumber, $this->subscribedToNewsletter);
68			}
69			}
70

Sylius / SyliusShopApiPlugin

Pull Request — master (#234)

UpdateCustomerRequest::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like