CreateAddressRequest::__construct() - Code Metrics - Inspection of "[WIP] Address book" - Sylius/SyliusShopApiPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#229)

unknown

created 2017-10-26 14:43 UTC

CreateAddressRequest::__construct() A

↳ Parent: CreateAddressRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	1

<?php

namespace Sylius\ShopApiPlugin\Request;

use Sylius\ShopApiPlugin\Command\CreateAddress;
use Symfony\Component\HttpFoundation\Request;

class CreateAddressRequest
{
    /**
     * @var string
     */
    private $firstName;

    /**
     * @var string
     */
    private $lastName;

    /**
     * @var string
     */
    private $company;

    /**
     * @var string
     */
    private $street;

    /**
     * @var string
     */
    private $countryCode;

    /**
     * @var string
     */
    private $provinceCode;

    /**
     * @var string
     */
    private $city;

    /**
     * @var string
     */
    private $postcode;

    /**
     * @var string
     */
    private $phoneNumber;

    /**
     * CreateAddressRequest constructor.
     * @param Request $request
     */
    public function __construct(Request $request)
    {
        $this->firstName = $request->request->get('firstName');
        $this->lastName = $request->request->get('lastName');
        $this->company = $request->request->get('company');
        $this->street = $request->request->get('street');
        $this->countryCode = $request->request->get('countryCode');
        $this->provinceCode = $request->request->get('provinceCode');
        $this->city = $request->request->get('city');
        $this->postcode = $request->request->get('postcode');
        $this->phoneNumber = $request->request->get('phoneNumber');
    }

    /**
     * @return CreateAddress
     */
    public function getCommand()
    {
        return new CreateAddress(
            $this->firstName,
            $this->lastName,
            $this->company,
            $this->street,
            $this->countryCode,
            $this->provinceCode,
            $this->city,
            $this->postcode,
            $this->phoneNumber
        );
    }

}

1			<?php
2
3			namespace Sylius\ShopApiPlugin\Request;
4
5			use Sylius\ShopApiPlugin\Command\CreateAddress;
6			use Symfony\Component\HttpFoundation\Request;
7
8			class CreateAddressRequest
9			{
10			/**
11			* @var string
12			*/
13			private $firstName;
14
15			/**
16			* @var string
17			*/
18			private $lastName;
19
20			/**
21			* @var string
22			*/
23			private $company;
24
25			/**
26			* @var string
27			*/
28			private $street;
29
30			/**
31			* @var string
32			*/
33			private $countryCode;
34
35			/**
36			* @var string
37			*/
38			private $provinceCode;
39
40			/**
41			* @var string
42			*/
43			private $city;
44
45			/**
46			* @var string
47			*/
48			private $postcode;
49
50			/**
51			* @var string
52			*/
53			private $phoneNumber;
54
55			/**
56			* CreateAddressRequest constructor.
57			* @param Request $request
58			*/
59			public function __construct(Request $request)
60			{
61			$this->firstName = $request->request->get('firstName');
62			$this->lastName = $request->request->get('lastName');
63			$this->company = $request->request->get('company');
64			$this->street = $request->request->get('street');
65			$this->countryCode = $request->request->get('countryCode');
66			$this->provinceCode = $request->request->get('provinceCode');
67			$this->city = $request->request->get('city');
68			$this->postcode = $request->request->get('postcode');
69			$this->phoneNumber = $request->request->get('phoneNumber');
70			}
71
72			/**
73			* @return CreateAddress
74			*/
75			public function getCommand()
76			{
77			return new CreateAddress(
78			$this->firstName,
79			$this->lastName,
80			$this->company,
81			$this->street,
82			$this->countryCode,
83			$this->provinceCode,
84			$this->city,
85			$this->postcode,
86			$this->phoneNumber
87			);
88			}
89
90			}

Sylius / SyliusShopApiPlugin

Pull Request — master (#229)

CreateAddressRequest::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like