CreateAddressRequest::__construct() - Code Metrics - Inspection of "[WIP] Address book" - Sylius/SyliusShopApiPlugin - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — master (#229)

unknown

created 2017-10-27 08:37 UTC

CreateAddressRequest::__construct() A

↳ Parent: CreateAddressRequest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	1

<?php

declare(strict_types=1);

namespace Sylius\ShopApiPlugin\Request;

use Sylius\ShopApiPlugin\Command\CreateAddress;
use Symfony\Component\HttpFoundation\Request;

class CreateAddressRequest
{
    /**
     * @var string
     */
    private $firstName;

    /**
     * @var string
     */
    private $lastName;

    /**
     * @var string
     */
    private $company;

    /**
     * @var string
     */
    private $street;

    /**
     * @var string
     */
    private $countryCode;

    /**
     * @var string
     */
    private $provinceCode;

    /**
     * @var string
     */
    private $city;

    /**
     * @var string
     */
    private $postcode;

    /**
     * @var string
     */
    private $phoneNumber;

    /**
     * CreateAddressRequest constructor.
     *
     * @param Request $request
     */
    public function __construct(Request $request)
    {
        $this->firstName = $request->request->get('firstName');
        $this->lastName = $request->request->get('lastName');
        $this->company = $request->request->get('company');
        $this->street = $request->request->get('street');
        $this->countryCode = $request->request->get('countryCode');
        $this->provinceCode = $request->request->get('provinceCode');
        $this->city = $request->request->get('city');
        $this->postcode = $request->request->get('postcode');
        $this->phoneNumber = $request->request->get('phoneNumber');
    }

    /**
     * @return CreateAddress
     */
    public function getCommand()
    {
        return new CreateAddress(
            $this->firstName,
            $this->lastName,
            $this->company,
            $this->street,
            $this->countryCode,
            $this->provinceCode,
            $this->city,
            $this->postcode,
            $this->phoneNumber
        );
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Sylius\ShopApiPlugin\Request;
6
7			use Sylius\ShopApiPlugin\Command\CreateAddress;
8			use Symfony\Component\HttpFoundation\Request;
9
10			class CreateAddressRequest
11			{
12			/**
13			* @var string
14			*/
15			private $firstName;
16
17			/**
18			* @var string
19			*/
20			private $lastName;
21
22			/**
23			* @var string
24			*/
25			private $company;
26
27			/**
28			* @var string
29			*/
30			private $street;
31
32			/**
33			* @var string
34			*/
35			private $countryCode;
36
37			/**
38			* @var string
39			*/
40			private $provinceCode;
41
42			/**
43			* @var string
44			*/
45			private $city;
46
47			/**
48			* @var string
49			*/
50			private $postcode;
51
52			/**
53			* @var string
54			*/
55			private $phoneNumber;
56
57			/**
58			* CreateAddressRequest constructor.
59			*
60			* @param Request $request
61			*/
62			public function __construct(Request $request)
63			{
64			$this->firstName = $request->request->get('firstName');
65			$this->lastName = $request->request->get('lastName');
66			$this->company = $request->request->get('company');
67			$this->street = $request->request->get('street');
68			$this->countryCode = $request->request->get('countryCode');
69			$this->provinceCode = $request->request->get('provinceCode');
70			$this->city = $request->request->get('city');
71			$this->postcode = $request->request->get('postcode');
72			$this->phoneNumber = $request->request->get('phoneNumber');
73			}
74
75			/**
76			* @return CreateAddress
77			*/
78			public function getCommand()
79			{
80			return new CreateAddress(
81			$this->firstName,
82			$this->lastName,
83			$this->company,
84			$this->street,
85			$this->countryCode,
86			$this->provinceCode,
87			$this->city,
88			$this->postcode,
89			$this->phoneNumber
90			);
91			}
92			}
93

Sylius / SyliusShopApiPlugin

Pull Request — master (#229)

CreateAddressRequest::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like