The return type of return $this->services; (Zend\Stdlib\PriorityQueue) is incompatible with the return type declared by the interface Sylius\Component\Registr...eRegistryInterface::all of type Sylius\Component\Registry\iterable.
If you return a value from a function or method, it should be a sub-type of the
type that is given by the parent type f.e. an interface, or abstract method.
This is more formally defined by the
Lizkov substitution principle,
and guarantees that classes that depend on the parent type can use any instance
of a child type interchangably. This principle also belongs to the
SOLID principles
for object oriented design.
Our function my_function expects a Post object, and outputs the author
of the post. The base class Post returns a simple string and outputting a
simple string will work just fine. However, the child class BlogPost which
is a sub-type of Post instead decided to return an object, and is
therefore violating the SOLID principles. If a BlogPost were passed to
my_function, PHP would not complain, but ultimately fail when executing the
strtoupper call in its body.
Loading history...
57
}
58
59
/**
60
* {@inheritdoc}
61
*/
62
public function register($service, int $priority = 0): void
63
{
64
$this->assertServiceHaveType($service);
65
$this->services->insert($service, $priority);
66
}
67
68
/**
69
* {@inheritdoc}
70
*/
71
public function unregister($service): void
72
{
73
if (!$this->has($service)) {
74
throw new NonExistingServiceException($this->context, gettype($service), array_keys($this->services->toArray()));
75
}
76
77
$this->services->remove($service);
78
}
79
80
/**
81
* {@inheritdoc}
82
*/
83
public function has($service): bool
84
{
85
$this->assertServiceHaveType($service);
86
87
return $this->services->contains($service);
88
}
89
90
/**
91
* @param object $service
92
*/
93
private function assertServiceHaveType($service): void
94
{
95
Assert::isInstanceOf(
96
$service,
97
$this->interface,
98
$this->context . ' needs to implement "%2$s", "%s" given.'
Sylius /
Sylius
Mark McKelvie
If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.
Let’s take a look at an example:
Our function
my_functionexpects aPostobject, and outputs the author of the post. The base classPostreturns a simple string and outputting a simple string will work just fine. However, the child classBlogPostwhich is a sub-type ofPostinstead decided to return anobject, and is therefore violating the SOLID principles. If aBlogPostwere passed tomy_function, PHP would not complain, but ultimately fail when executing thestrtouppercall in its body.