ReviewChangeListener - Code Metrics - Inspection of "Merge branch '1.0'" - Sylius/Sylius - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6570ae...141d1f )

by Kamil

created 2017-10-09 12:03 UTC

ReviewChangeListener A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
wmc	6
c	2
b	1
f	0
lcom	1
cbo	3
dl	0
loc	53
rs	10

5 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	postPersist()	4	1
A	postUpdate()	4	1
A	recalculateSubjectRating()	10	2
A	postRemove()	4	1

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Sylius\Bundle\ReviewBundle\EventListener;

use Doctrine\ORM\Event\LifecycleEventArgs;
use Sylius\Bundle\ReviewBundle\Updater\ReviewableRatingUpdaterInterface;
use Sylius\Component\Resource\Exception\UnexpectedTypeException;
use Sylius\Component\Review\Model\ReviewInterface;

/**
 * @author Mateusz Zalewski <[email protected]>
 */
final class ReviewChangeListener
{
    /**
     * @var ReviewableRatingUpdaterInterface
     */
    private $averageRatingUpdater;

    /**
     * @param ReviewableRatingUpdaterInterface $averageRatingUpdater
     */
    public function __construct(ReviewableRatingUpdaterInterface $averageRatingUpdater)
    {
        $this->averageRatingUpdater = $averageRatingUpdater;
    }

    /**
     * @param LifecycleEventArgs $args
     */
    public function postPersist(LifecycleEventArgs $args)
    {
        $this->recalculateSubjectRating($args);
    }

    /**
     * @param LifecycleEventArgs $args
     */
    public function postUpdate(LifecycleEventArgs $args)
    {
        $this->recalculateSubjectRating($args);
    }

    /**
     * @param LifecycleEventArgs $args
     */
    public function postRemove(LifecycleEventArgs $args)
    {
        $this->recalculateSubjectRating($args);
    }

    /**
     * @param LifecycleEventArgs $args
     */
    public function recalculateSubjectRating(LifecycleEventArgs $args): void
    {
        $subject = $args->getObject();

        if (!$subject instanceof ReviewInterface) {
            return;
        }

        $this->averageRatingUpdater->update($subject->getReviewSubject());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }
}


1			<?php
2
3			/*
4			* This file is part of the Sylius package.
5			*
6			* (c) Paweł Jędrzejewski
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Sylius\Bundle\ReviewBundle\EventListener;
15
16			use Doctrine\ORM\Event\LifecycleEventArgs;
17			use Sylius\Bundle\ReviewBundle\Updater\ReviewableRatingUpdaterInterface;
18			use Sylius\Component\Resource\Exception\UnexpectedTypeException;
19			use Sylius\Component\Review\Model\ReviewInterface;
20
21			/**
22			* @author Mateusz Zalewski <[email protected]>
23			*/
24			final class ReviewChangeListener
25			{
26			/**
27			* @var ReviewableRatingUpdaterInterface
28			*/
29			private $averageRatingUpdater;
30
31			/**
32			* @param ReviewableRatingUpdaterInterface $averageRatingUpdater
33			*/
34			public function __construct(ReviewableRatingUpdaterInterface $averageRatingUpdater)
35			{
36			$this->averageRatingUpdater = $averageRatingUpdater;
37			}
38
39			/**
40			* @param LifecycleEventArgs $args
41			*/
42			public function postPersist(LifecycleEventArgs $args)
43			{
44			$this->recalculateSubjectRating($args);
45			}
46
47			/**
48			* @param LifecycleEventArgs $args
49			*/
50			public function postUpdate(LifecycleEventArgs $args)
51			{
52			$this->recalculateSubjectRating($args);
53			}
54
55			/**
56			* @param LifecycleEventArgs $args
57			*/
58			public function postRemove(LifecycleEventArgs $args)
59			{
60			$this->recalculateSubjectRating($args);
61			}
62
63			/**
64			* @param LifecycleEventArgs $args
65			*/
66			public function recalculateSubjectRating(LifecycleEventArgs $args): void
67			{
68			$subject = $args->getObject();
69
70			if (!$subject instanceof ReviewInterface) {
71			return;
72			}
73
74			$this->averageRatingUpdater->update($subject->getReviewSubject());
			0 ignored issues – show Bug introduced 2017-08-24 09:36 UTC by Report Bug Copy Issue Report It seems like `$subject->getReviewSubject()` can be `null`; however, `update()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
75			}
76			}
77

Sylius / Sylius

Push — master ( 6570ae...141d1f )

ReviewChangeListener A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

Duplication Side-by-Side

Filter issues like