Sylius / Sylius

src/Sylius/Behat/Service/Resolver/CurrentPageResolver.php

<?php

/*
 * This file is part of the Sylius package.
 *
 * (c) Paweł Jędrzejewski
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Sylius\Behat\Service\Resolver;

use Behat\Mink\Session;
use Sylius\Behat\Page\SymfonyPageInterface;
use Symfony\Component\Routing\Matcher\UrlMatcherInterface;
use Webmozart\Assert\Assert;

/**
 * @author Łukasz Chruściel <lukasz.chrusciel@lakion.com>
 */
final class CurrentPageResolver implements CurrentPageResolverInterface
{
    /**
     * @var Session
     */
    private $session;

    /**
     * @var UrlMatcherInterface
     */
    private $urlMatcher;

    /**
     * @param Session $session
     * @param UrlMatcherInterface $urlMatcher
     */
    public function __construct(Session $session, UrlMatcherInterface $urlMatcher)
    {
        $this->session = $session;
        $this->urlMatcher = $urlMatcher;
    }

    /**
     * {@inheritdoc}
     *
     * @throws \LogicException
     */
    public function getCurrentPageWithForm(array $pages)
    {
        $routeParameters = $this->urlMatcher->match(parse_url($this->session->getCurrentUrl(), PHP_URL_PATH));

It seems like parse_url($this->session->getCurrentUrl(), PHP_URL_PATH) targeting parse_url() can also be of type false; however, Symfony\Component\Routing\Matcher\UrlMatcherInterface::match() does only seem to accept string, did you maybe forget to handle an error condition?

        Assert::allIsInstanceOf($pages, SymfonyPageInterface::class);

        foreach ($pages as $page) {
            if ($routeParameters['_route'] === $page->getRouteName()) {
                return $page;
            }
        }

        throw new \LogicException('Route name could not be matched to provided pages.');
    }
}