Suven\FlintRedis\FlintRedisCacheFactory

Complexity

Total Complexity

18

Size/Duplication

Total Lines	90
Duplicated Lines	10 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getKey()	0	4	1
A	getFullKey()	0	5	1
A	create()	0	10	2
C	retrieveOldInstance()	9	21	10
B	newCacheInstance()	0	22	4

<?php
namespace Suven\FlintRedis;

abstract class FlintRedisCacheFactory
{
    const STRATEGY_REDIS = 1;
    const STRATEGY_FLINTSTONE = 2;

    private static $cachedInstances = [];

    private static function getKey($realm, $strategy)
    {
        return "${realm}.${strategy}";
    }

    private static function getFullKey($key, $options)
    {
        $optionsKey = md5(json_encode($options));
        return "${key}.${optionsKey}";
    }

    /**
     * Retrieves a new or previously created cache-instance for the provided
     * parameters.
     *
     * If you previously created an instance for a collection 'foo' with a
     * strategy [and options] and are later 'creating' in instance but only
     * provide the realm 'foo', you will retreive your previously created instance.
     *
     * That way you only have to provide the strategy and options once per $realm.
     *
     * @param  string  $realm    Your collections name
     * @param  number  $strategy Either FlintRedisCacheFactory::STRATEGY_REDIS
     *                           or FlintRedisCacheFactory:: STRATEGY_FLINTSTONE
     * @param  array   $options  Options you want to pass to predis/flintstone
     * @return FlintRedisCache
     */
    public static function create($realm, $strategy = false, $options = false)
    {
        $instance = self::retrieveOldInstance($strategy, $realm, $options);

        if (!$instance) {
            $instance = self::newCacheInstance($strategy, $realm, $options);
        }

        return $instance;
    }

    private static function retrieveOldInstance($strategy, $realm, $options)
    {
        $key = self::getKey($realm, $strategy);
        $fullKey = self::getFullKey($key, $options);

        $instance = false;

        if ($strategy && $options && isset(self::$cachedInstances[$fullKey])) {

This code seems to be duplicated across your project.

            $instance = self::$cachedInstances[$fullKey];
        }

        if ($strategy && !$options && isset(self::$cachedInstances[$key])) {

This code seems to be duplicated across your project.

            $instance = self::$cachedInstances[$key];
        }

        if (!$strategy && !$options && isset(self::$cachedInstances[$realm])) {

This code seems to be duplicated across your project.

            $instance = self::$cachedInstances[$realm];
        }

        return $instance;
    }

    private static function newCacheInstance($strategy, $realm, $options)
    {
        $strategy = $strategy ? $strategy : self::STRATEGY_REDIS;
        $options = $options ? $options : [];

        $key = self::getKey($realm, $strategy);
        $fullKey = self::getFullKey($key, $options);

        $instance;

The variable $instance seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition?

        if ($strategy === self::STRATEGY_REDIS) {
            $instance = new FlintRedisCacheRedis($realm, $options);
        } else {
            $instance = new FlintRedisCacheFlintstone($realm, $options);
        }

        self::$cachedInstances[$fullKey] = &$instance;
        self::$cachedInstances[$key] = &$instance;
        self::$cachedInstances[$realm] = &$instance;

        return $instance;
    }
}